mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed sockfd/socketBio resource leak.

Browse Source
This commit is contained in:
Armin Novak 2018-10-25 13:13:14 +02:00
parent 7aebf8ebd2
commit 42014e80d0
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libfreerdp/core/gateway/rpc.c
View File

@ -671,24 +671,36 @@ static BOOL rpc_channel_tls_connect(RpcChannel* channel, int timeout)
socketBio = BIO_new(BIO_s_simple_socket()); socketBio = BIO_new(BIO_s_simple_socket());
if (!socketBio) if (!socketBio)
{
close(sockfd);
return FALSE; return FALSE;
}
BIO_set_fd(socketBio, sockfd, BIO_CLOSE); BIO_set_fd(socketBio, sockfd, BIO_CLOSE);
bufferedBio = BIO_new(BIO_s_buffered_socket()); bufferedBio = BIO_new(BIO_s_buffered_socket());
if (!bufferedBio) if (!bufferedBio)
{
BIO_free_all(socketBio);
return FALSE; return FALSE;
}
bufferedBio = BIO_push(bufferedBio, socketBio); bufferedBio = BIO_push(bufferedBio, socketBio);
if (!BIO_set_nonblock(bufferedBio, TRUE)) if (!BIO_set_nonblock(bufferedBio, TRUE))
{
BIO_free_all(bufferedBio);
return FALSE; return FALSE;
}
if (channel->client->isProxy) if (channel->client->isProxy)
{ {
if (!proxy_connect(settings, bufferedBio, proxyUsername, proxyPassword, settings->GatewayHostname, if (!proxy_connect(settings, bufferedBio, proxyUsername, proxyPassword, settings->GatewayHostname,
settings->GatewayPort)) settings->GatewayPort))
{
BIO_free_all(bufferedBio);
return FALSE; return FALSE;
}
} }
channel->bio = bufferedBio; channel->bio = bufferedBio;