mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed clang-scanbuild warnings

Browse Source
This commit is contained in:
Armin Novak 2022-02-22 15:32:20 +01:00 committed by akallabeth
parent c0a39c2db8
commit 3bb36f4caa
5 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/freerdp/server/proxy/proxy_config.h
View File

@ -198,7 +198,7 @@ extern "C"
* @brief pf_config_plugin Register a proxy plugin handling event filtering * @brief pf_config_plugin Register a proxy plugin handling event filtering
* defined in the configuration. * defined in the configuration.
* *
* @param plugins_manager * @param plugins_manager The plugin manager
* @param userdata A proxyConfig* to use as reference * @param userdata A proxyConfig* to use as reference
* *
* @return TRUE for success, FALSE for failure * @return TRUE for success, FALSE for failure

4
server/proxy/channels/pf_channel_rdpdr.c
View File

@ -1131,7 +1131,9 @@ BOOL pf_channel_rdpdr_client_handle(pClientContext* pc, UINT16 channelId, const
pf_channel_client_context* rdpdr; pf_channel_client_context* rdpdr;
pServerContext* ps; pServerContext* ps;
wStream* s; wStream* s;
#if defined(WITH_PROXY_EMULATE_SMARTCARD)
UINT16 packetid; UINT16 packetid;
#endif
WINPR_ASSERT(pc); WINPR_ASSERT(pc);
WINPR_ASSERT(pc->pdata); WINPR_ASSERT(pc->pdata);
@ -1248,10 +1250,10 @@ BOOL pf_channel_rdpdr_client_handle(pClientContext* pc, UINT16 channelId, const
return FALSE; return FALSE;
} }
} }
break;
#else #else
return pf_channel_rdpdr_client_send_to_server(ps, s); return pf_channel_rdpdr_client_send_to_server(ps, s);
#endif #endif
break;
default: default:
WLog_ERR(TAG, WLog_ERR(TAG,
"[%s]: Channel %s [0x%04" PRIx16 "[%s]: Channel %s [0x%04" PRIx16

4
server/proxy/modules/capture/cap_protocol.c
View File

@ -49,12 +49,12 @@ wStream* capture_plugin_create_session_info_packet(pClientContext* pc)
if ((username_length == 0) || (username_length > UINT16_MAX)) if ((username_length == 0) || (username_length > UINT16_MAX))
return NULL; return NULL;
s = capture_plugin_packet_new(SESSION_INFO_PDU_BASE_SIZE + username_length, s = capture_plugin_packet_new(SESSION_INFO_PDU_BASE_SIZE + (UINT32)username_length,
MESSAGE_TYPE_SESSION_INFO); MESSAGE_TYPE_SESSION_INFO);
if (!s) if (!s)
return NULL; return NULL;
Stream_Write_UINT16(s, username_length); /* username length (2 bytes) */ Stream_Write_UINT16(s, (UINT16)username_length); /* username length (2 bytes) */
Stream_Write(s, settings->Username, username_length); /* username */ Stream_Write(s, settings->Username, username_length); /* username */
Stream_Write_UINT32(s, settings->DesktopWidth); /* desktop width (4 bytes) */ Stream_Write_UINT32(s, settings->DesktopWidth); /* desktop width (4 bytes) */
Stream_Write_UINT32(s, settings->DesktopHeight); /* desktop height (4 bytes) */ Stream_Write_UINT32(s, settings->DesktopHeight); /* desktop height (4 bytes) */

3
winpr/libwinpr/crypto/cipher.c
View File

@ -813,6 +813,7 @@ err:
mbedtls_md_free(&ctx); mbedtls_md_free(&ctx);
SecureZeroMemory(md_buf, 64); SecureZeroMemory(md_buf, 64);
return rv; return rv;
#endif #else
return 0; return 0;
#endif
} }

2
winpr/libwinpr/registry/registry_reg.c
View File

@ -210,6 +210,7 @@ static RegVal* reg_load_value(const Reg* reg, RegKey* key)
value->data.dword = (DWORD)val; value->data.dword = (DWORD)val;
} }
}
break; break;
case REG_QWORD: case REG_QWORD:
{ {
@ -257,7 +258,6 @@ static RegVal* reg_load_value(const Reg* reg, RegKey* key)
reg_data_type_string(value->type)); reg_data_type_string(value->type));
break; break;
} }
}
if (!key->values) if (!key->values)
{ {