mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

winpr/sspi/ntlm: fix computer name len calculation

Browse Source 
The lpnSize parameter for GetComputerNameEx specifies the total
size of the buffer (in characters).
However, the current code calculated the amount of bytes.
Since only GetComputerNameExA was used and because sizeof(CHAR) == 1
the result was correct but the math was wrong.
Credit goes to @byteboon
This commit is contained in:
Norbert Federa 2016-06-30 17:15:40 +02:00
parent c42d2ef0d1
commit 333a1110f5
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
winpr/libwinpr/sspi/NTLM/ntlm.c
View File

@ -47,7 +47,7 @@ int ntlm_SetContextWorkstation(NTLM_CONTEXT* context, char* Workstation)
int status;
char* ws = Workstation;
CHAR computerName[MAX_COMPUTERNAME_LENGTH + 1];
DWORD nSize = sizeof(computerName) * sizeof(CHAR);
DWORD nSize = sizeof(computerName) / sizeof(CHAR);
if (!Workstation)
{
@ -108,12 +108,11 @@ int ntlm_SetContextTargetName(NTLM_CONTEXT* context, char* TargetName)
{
int status;
CHAR computerName[MAX_COMPUTERNAME_LENGTH + 1];
DWORD nSize = sizeof(computerName) * sizeof(CHAR);
DWORD nSize = sizeof(computerName) / sizeof(CHAR);
char* name = TargetName;
if (!name)
{
if (!GetComputerNameExA(ComputerNameDnsHostname, computerName, &nSize))
return -1;

2
winpr/libwinpr/sspi/NTLM/ntlm_av_pairs.c
View File

@ -174,7 +174,7 @@ int ntlm_get_target_computer_name(PUNICODE_STRING pName, COMPUTER_NAME_FORMAT ty
char* name;
int status;
CHAR computerName[MAX_COMPUTERNAME_LENGTH + 1];
DWORD nSize = sizeof(computerName) * sizeof(CHAR);
DWORD nSize = sizeof(computerName) / sizeof(CHAR);
if (!GetComputerNameExA(type, computerName, &nSize))
return -1;