mirrors
/
FreeRDP
mirror of https://github.com/FreeRDP/FreeRDP
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed missing argument checks. 

The arguments for rdpgfx_send_frame_acknowledge_pdu must be checked
as in some call stacks they might be NULL.
This commit is contained in:
Armin Novak 2019-05-07 13:46:24 +02:00
parent 8fdf8eaeb7
commit 1bb933b991
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
channels/rdpgfx/client/rdpgfx_main.c
View File

@ -258,8 +258,22 @@ static UINT rdpgfx_send_frame_acknowledge_pdu(RdpgfxClientContext* context,
UINT error; UINT error;
wStream* s; wStream* s;
RDPGFX_HEADER header; RDPGFX_HEADER header;
RDPGFX_PLUGIN* gfx = (RDPGFX_PLUGIN*) context->handle; RDPGFX_PLUGIN* gfx;
RDPGFX_CHANNEL_CALLBACK* callback = gfx->listener_callback->channel_callback; RDPGFX_CHANNEL_CALLBACK* callback;
if (!context || !pdu)
return ERROR_BAD_ARGUMENTS;
gfx = (RDPGFX_PLUGIN*) context->handle;
if (!gfx)
return ERROR_BAD_CONFIGURATION;
callback = gfx->listener_callback->channel_callback;
if (!callback)
return ERROR_BAD_CONFIGURATION;
header.flags = 0; header.flags = 0;
header.cmdId = RDPGFX_CMDID_FRAMEACKNOWLEDGE; header.cmdId = RDPGFX_CMDID_FRAMEACKNOWLEDGE;
header.pduLength = RDPGFX_HEADER_SIZE + 12; header.pduLength = RDPGFX_HEADER_SIZE + 12;