mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #914 from hardening/certDump

Browse Source 
Fix parsing of certificate serial number
This commit is contained in:
Marc-André Moreau 2013-01-19 16:37:39 -08:00
commit 18f1405e51
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libfreerdp/core/certificate.c
View File

@ -531,10 +531,13 @@ BOOL certificate_read_server_x509_certificate_chain(rdpCertificate* certificate,
DEBUG_CERTIFICATE("License Server Certificate");
ret = certificate_read_x509_certificate(&certificate->x509_cert_chain->array[i], &cert_info);
DEBUG_LICENSE("modulus length:%d", (int) cert_info.ModulusLength);
if(cert_info.Modulus)
if (cert_info.Modulus)
free(cert_info.Modulus);
if(!ret)
if (!ret) {
printf("failed to read License Server, content follows:\n");
winpr_HexDump(certificate->x509_cert_chain->array[i].data, certificate->x509_cert_chain->array[i].length);
return FALSE;
}
}
else if (numCertBlobs - i == 1)
{

8
libfreerdp/crypto/ber.c
View File

@ -21,6 +21,7 @@
#include "config.h"
#endif
#include <stdio.h>
#include <freerdp/crypto/ber.h>
BOOL ber_read_length(STREAM* s, int* length)
@ -372,7 +373,7 @@ BOOL ber_read_integer(STREAM* s, UINT32* value)
if (value == NULL)
{
// even if we don't care the integer value, check the announced size
if(length < 1 || length > 4)
if(length < 1 || length > 8)
return FALSE;
stream_seek(s, length);
return TRUE;
@ -391,6 +392,11 @@ BOOL ber_read_integer(STREAM* s, UINT32* value)
}
else if (length == 4)
stream_read_UINT32_be(s, *value);
else if (length == 8)
{
printf("%s: should implement reading an 8 bytes integer\n", __func__);
return FALSE;
}
else
return FALSE;