Merge pull request #6088 from akallabeth/cppcheck

Fix #6085: Java string comparison should prefer equals
This commit is contained in:
David Fort 2020-04-16 10:52:53 +02:00 committed by GitHub
commit 1301042f0d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -113,7 +113,7 @@ public class HomeActivity extends AppCompatActivity
String curSection = separatedListAdapter.getSectionForPosition(position);
Log.v(TAG, "Clicked on item id " + separatedListAdapter.getItemId(position) +
" in section " + curSection);
if (curSection == sectionLabelBookmarks)
if (curSection.equals(sectionLabelBookmarks))
{
String refStr = view.getTag().toString();
if (ConnectionReference.isManualBookmarkReference(refStr) ||