mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[core,client] add argument checks & assertions

Browse Source 
* freerdp_get_event_handles
* freerdp_channels_process_pending_messages
This commit is contained in:
akallabeth 2024-09-17 17:11:26 +02:00
parent 26003e59cc
commit 0fe89241f8
No known key found for this signature in database
GPG Key ID: A49454A3FC909FD5
1 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
libfreerdp/core/client.c
View File

@ -198,10 +198,15 @@ void freerdp_channels_free(rdpChannels* channels)
return;
HashTable_Free(channels->channelEvents);
MessageQueue_Free(channels->queue);
DeleteCriticalSection(&channels->channelsLock);
if (channels->queue)
{
MessageQueue_Free(channels->queue);
channels->queue = NULL;
}
free(channels);
}
@ -719,8 +724,8 @@ BOOL freerdp_channels_get_fds(rdpChannels* channels, freerdp* instance, void** r
void* freerdp_channels_get_static_channel_interface(rdpChannels* channels, const char* name)
{
void* pInterface = NULL;
CHANNEL_OPEN_DATA* pChannelOpenData = NULL;
pChannelOpenData = freerdp_channels_find_channel_open_data_by_name(channels, name);
CHANNEL_OPEN_DATA* pChannelOpenData =
freerdp_channels_find_channel_open_data_by_name(channels, name);
if (pChannelOpenData)
pInterface = pChannelOpenData->pInterface;
@ -730,7 +735,9 @@ void* freerdp_channels_get_static_channel_interface(rdpChannels* channels, const
HANDLE freerdp_channels_get_event_handle(freerdp* instance)
{
WINPR_ASSERT(instance);
if (!instance)
return INVALID_HANDLE_VALUE;
WINPR_ASSERT(instance->context);
rdpChannels* channels = instance->context->channels;
@ -753,13 +760,16 @@ static BOOL channels_process(const void* key, void* value, void* arg)
int freerdp_channels_process_pending_messages(freerdp* instance)
{
WINPR_ASSERT(instance);
if (!instance)
return -1;
WINPR_ASSERT(instance->context);
rdpChannels* channels = instance->context->channels;
WINPR_ASSERT(channels);
if (WaitForSingleObject(MessageQueue_Event(channels->queue), 0) == WAIT_OBJECT_0)
const DWORD status = WaitForSingleObject(MessageQueue_Event(channels->queue), 0);
if (status == WAIT_OBJECT_0)
{
if (!freerdp_channels_process_sync(channels, instance))
return -1;