From 00cd1c7130708dab604a2a6ee3484e0ec1cee801 Mon Sep 17 00:00:00 2001 From: akallabeth Date: Thu, 4 Apr 2024 21:36:14 +0200 Subject: [PATCH] [cmake] do not set NO_SONAME if set the linker might insert full paths to dependencies --- cmake/AddTargetWithResourceFile.cmake | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/cmake/AddTargetWithResourceFile.cmake b/cmake/AddTargetWithResourceFile.cmake index 3a160a355..355902ed2 100644 --- a/cmake/AddTargetWithResourceFile.cmake +++ b/cmake/AddTargetWithResourceFile.cmake @@ -64,7 +64,7 @@ macro(AddTargetWithResourceFile nameAndTarget is_exe version sources) set(OUTPUT_FILENAME "${name}") if (VERSIONING) - set(OUTPUT_FILENAME "${name}${RC_VERSION_MAJOR}") + string(APPEND OUTPUT_FILENAME "${RC_VERSION_MAJOR}") endif() if (IS_EXE) @@ -80,7 +80,7 @@ macro(AddTargetWithResourceFile nameAndTarget is_exe version sources) PROPERTIES OUTPUT_NAME ${OUTPUT_FILENAME} ) - set (OUTPUT_FILENAME "${OUTPUT_FILENAME}${CMAKE_EXECUTABLE_SUFFIX}" ) + string(APPEND OUTPUT_FILENAME "${CMAKE_EXECUTABLE_SUFFIX}") else() message("add_library(${target}) [${lib_options}]") add_library(${target} @@ -96,7 +96,6 @@ macro(AddTargetWithResourceFile nameAndTarget is_exe version sources) ) else() set_target_properties(${target} PROPERTIES PREFIX "") - set_target_properties(${target} PROPERTIES NO_SONAME 1) endif() set_target_properties(