FreeRDP/client/X11/xf_graphics.c

572 lines
14 KiB
C
Raw Normal View History

/**
2012-10-09 07:02:04 +04:00
* FreeRDP: A Remote Desktop Protocol Implementation
* X11 Graphical Objects
*
* Copyright 2011 Marc-Andre Moreau <marcandre.moreau@gmail.com>
* Copyright 2016 Thincast Technologies GmbH
* Copyright 2016 Armin Novak <armin.novak@thincast.com>
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#ifdef HAVE_CONFIG_H
#include "config.h"
#endif
2011-10-21 02:18:45 +04:00
#include <X11/Xlib.h>
#include <X11/Xutil.h>
#ifdef WITH_XCURSOR
#include <X11/Xcursor/Xcursor.h>
#endif
#include <winpr/crt.h>
#include <freerdp/codec/bitmap.h>
#include <freerdp/codec/rfx.h>
#include "xf_graphics.h"
#include "xf_gdi.h"
2014-09-12 19:13:01 +04:00
#include <freerdp/log.h>
#define TAG CLIENT_TAG("x11")
2017-01-25 10:33:36 +03:00
BOOL xf_decode_color(xfContext* xfc, const UINT32 srcColor, XColor* color)
2016-08-03 11:54:50 +03:00
{
2017-01-25 10:33:36 +03:00
rdpGdi* gdi;
rdpSettings* settings;
2016-08-03 11:54:50 +03:00
UINT32 SrcFormat;
2017-01-25 10:33:36 +03:00
BYTE r, g, b, a;
if (!xfc || !color)
return FALSE;
gdi = xfc->context.gdi;
2016-08-03 11:54:50 +03:00
2017-01-25 10:33:36 +03:00
if (!gdi)
2016-08-03 11:54:50 +03:00
return FALSE;
2017-01-25 10:33:36 +03:00
settings = xfc->context.settings;
2016-08-03 11:54:50 +03:00
2017-01-25 10:33:36 +03:00
if (!settings)
return FALSE;
2017-02-01 13:00:24 +03:00
switch (settings->ColorDepth)
{
case 32:
case 24:
SrcFormat = PIXEL_FORMAT_BGR24;
break;
case 16:
SrcFormat = PIXEL_FORMAT_RGB16;
break;
case 15:
SrcFormat = PIXEL_FORMAT_RGB15;
break;
case 8:
SrcFormat = PIXEL_FORMAT_RGB8;
break;
default:
return FALSE;
}
2017-01-25 10:33:36 +03:00
SplitColor(srcColor, SrcFormat, &r, &g, &b, &a, &gdi->palette);
color->blue = (unsigned short)(b << 8);
color->green = (unsigned short)(g << 8);
color->red = (unsigned short)(r << 8);
color->flags = DoRed | DoGreen | DoBlue;
if (XAllocColor(xfc->display, xfc->colormap, color) == 0)
return FALSE;
2016-08-03 11:54:50 +03:00
return TRUE;
}
2011-10-21 02:18:45 +04:00
/* Bitmap Class */
static BOOL xf_Bitmap_New(rdpContext* context, rdpBitmap* bitmap)
{
BOOL rc = FALSE;
UINT32 depth;
BYTE* data;
2016-08-03 15:16:20 +03:00
rdpGdi* gdi;
xfBitmap* xbitmap = (xfBitmap*)bitmap;
xfContext* xfc = (xfContext*) context;
if (!context || !bitmap || !context->gdi)
return FALSE;
2016-08-03 15:16:20 +03:00
gdi = context->gdi;
xf_lock_x11(xfc, FALSE);
2016-04-14 00:13:04 +03:00
depth = GetBitsPerPixel(bitmap->format);
xbitmap->pixmap = XCreatePixmap(xfc->display, xfc->drawable, bitmap->width,
bitmap->height, xfc->depth);
if (!xbitmap->pixmap)
goto unlock;
if (bitmap->data)
{
2014-09-12 09:03:19 +04:00
XSetFunction(xfc->display, xfc->gc, GXcopy);
if (depth != xfc->depth)
{
if (!(data = _aligned_malloc(bitmap->width * bitmap->height * 4, 16)))
goto unlock;
if (!freerdp_image_copy(data, gdi->dstFormat, 0, 0, 0,
bitmap->width, bitmap->height,
bitmap->data, bitmap->format,
0, 0, 0, &context->gdi->palette, FREERDP_FLIP_NONE))
{
_aligned_free(data);
goto unlock;
}
_aligned_free(bitmap->data);
bitmap->data = data;
2016-08-03 15:16:20 +03:00
bitmap->format = gdi->dstFormat;
}
xbitmap->image = XCreateImage(xfc->display, xfc->visual, xfc->depth,
ZPixmap, 0, (char*) bitmap->data, bitmap->width, bitmap->height,
xfc->scanline_pad, 0);
if (!xbitmap->image)
goto unlock;
XPutImage(xfc->display, xbitmap->pixmap, xfc->gc, xbitmap->image, 0, 0, 0, 0, bitmap->width,
2016-10-04 10:00:00 +03:00
bitmap->height);
}
rc = TRUE;
unlock:
xf_unlock_x11(xfc, FALSE);
return rc;
}
static void xf_Bitmap_Free(rdpContext* context, rdpBitmap* bitmap)
{
xfContext* xfc = (xfContext*) context;
xfBitmap* xbitmap = (xfBitmap*)bitmap;
if (!xfc || !xbitmap)
return;
xf_lock_x11(xfc, FALSE);
if (xbitmap->pixmap != 0)
XFreePixmap(xfc->display, xbitmap->pixmap);
if (xbitmap->image)
XFree(xbitmap->image);
xf_unlock_x11(xfc, FALSE);
}
static BOOL xf_Bitmap_Paint(rdpContext* context, rdpBitmap* bitmap)
{
int width, height;
xfContext* xfc = (xfContext*) context;
xfBitmap* xbitmap = (xfBitmap*)bitmap;
BOOL ret;
if (!context || !xbitmap)
return FALSE;
width = bitmap->right - bitmap->left + 1;
height = bitmap->bottom - bitmap->top + 1;
xf_lock_x11(xfc, FALSE);
XSetFunction(xfc->display, xfc->gc, GXcopy);
XPutImage(xfc->display, xfc->primary, xfc->gc,
xbitmap->image, 0, 0, bitmap->left, bitmap->top, width, height);
ret = gdi_InvalidateRegion(xfc->hdc, bitmap->left, bitmap->top, width, height);
xf_unlock_x11(xfc, FALSE);
return ret;
}
2016-07-14 17:08:06 +03:00
static BOOL xf_Bitmap_SetSurface(rdpContext* context, rdpBitmap* bitmap,
2016-10-04 10:00:00 +03:00
BOOL primary)
2011-10-21 02:18:45 +04:00
{
xfContext* xfc = (xfContext*) context;
if (!context || (!bitmap && !primary))
return FALSE;
xf_lock_x11(xfc, FALSE);
2011-10-21 02:18:45 +04:00
if (primary)
xfc->drawing = xfc->primary;
2011-10-21 02:18:45 +04:00
else
xfc->drawing = ((xfBitmap*) bitmap)->pixmap;
xf_unlock_x11(xfc, FALSE);
return TRUE;
2011-10-21 02:18:45 +04:00
}
/* Pointer Class */
static BOOL xf_Pointer_New(rdpContext* context, rdpPointer* pointer)
2011-10-21 02:18:45 +04:00
{
2016-09-09 09:58:26 +03:00
#ifdef WITH_XCURSOR
2016-10-10 10:19:43 +03:00
UINT32 CursorFormat;
2016-09-09 09:58:26 +03:00
size_t size;
XcursorImage ci;
xfContext* xfc = (xfContext*) context;
xfPointer* xpointer = (xfPointer*)pointer;
2016-08-03 15:16:20 +03:00
if (!context || !pointer || !context->gdi)
return FALSE;
2016-10-10 10:19:43 +03:00
if (!xfc->invert)
CursorFormat = PIXEL_FORMAT_RGBA32;
else
CursorFormat = PIXEL_FORMAT_BGRA32;
xf_lock_x11(xfc, FALSE);
ZeroMemory(&ci, sizeof(ci));
2011-10-21 02:18:45 +04:00
ci.version = XCURSOR_IMAGE_VERSION;
ci.size = sizeof(ci);
ci.width = pointer->width;
ci.height = pointer->height;
ci.xhot = pointer->xPos;
ci.yhot = pointer->yPos;
2016-09-09 09:58:26 +03:00
size = ci.height * ci.width * GetBytesPerPixel(CursorFormat);
2016-10-04 10:00:00 +03:00
2016-09-09 09:58:26 +03:00
if (!(ci.pixels = (XcursorPixel*) _aligned_malloc(size, 16)))
{
xf_unlock_x11(xfc, FALSE);
return FALSE;
}
2011-10-21 02:18:45 +04:00
2016-10-04 15:14:39 +03:00
if (!freerdp_image_copy_from_pointer_data(
2016-10-04 10:00:00 +03:00
(BYTE*) ci.pixels, CursorFormat,
0, 0, 0, pointer->width, pointer->height,
pointer->xorMaskData, pointer->lengthXorMask,
pointer->andMaskData, pointer->lengthAndMask,
2016-10-04 15:14:39 +03:00
pointer->xorBpp, &context->gdi->palette))
2015-08-05 18:32:46 +03:00
{
2016-09-09 09:58:26 +03:00
_aligned_free(ci.pixels);
2015-08-05 18:32:46 +03:00
xf_unlock_x11(xfc, FALSE);
return FALSE;
2011-10-21 02:18:45 +04:00
}
2016-09-09 09:58:26 +03:00
xpointer->cursor = XcursorImageLoadCursor(xfc->display, &ci);
_aligned_free(ci.pixels);
xf_unlock_x11(xfc, FALSE);
#endif
return TRUE;
2011-10-21 02:18:45 +04:00
}
static void xf_Pointer_Free(rdpContext* context, rdpPointer* pointer)
2011-10-21 02:18:45 +04:00
{
#ifdef WITH_XCURSOR
xfContext* xfc = (xfContext*) context;
xf_lock_x11(xfc, FALSE);
if (((xfPointer*) pointer)->cursor)
XFreeCursor(xfc->display, ((xfPointer*) pointer)->cursor);
xf_unlock_x11(xfc, FALSE);
#endif
2011-10-21 02:18:45 +04:00
}
static BOOL xf_Pointer_Set(rdpContext* context,
2016-10-04 10:00:00 +03:00
const rdpPointer* pointer)
2011-10-21 02:18:45 +04:00
{
#ifdef WITH_XCURSOR
xfContext* xfc = (xfContext*) context;
xf_lock_x11(xfc, FALSE);
xfc->pointer = (xfPointer*) pointer;
2011-11-24 22:01:34 +04:00
/* in RemoteApp mode, window can be null if none has had focus */
if (xfc->window)
XDefineCursor(xfc->display, xfc->window->handle, xfc->pointer->cursor);
xf_unlock_x11(xfc, FALSE);
#endif
return TRUE;
2011-10-21 02:18:45 +04:00
}
static BOOL xf_Pointer_SetNull(rdpContext* context)
{
#ifdef WITH_XCURSOR
xfContext* xfc = (xfContext*) context;
static Cursor nullcursor = None;
xf_lock_x11(xfc, FALSE);
if (nullcursor == None)
{
XcursorImage ci;
XcursorPixel xp = 0;
ZeroMemory(&ci, sizeof(ci));
ci.version = XCURSOR_IMAGE_VERSION;
ci.size = sizeof(ci);
ci.width = ci.height = 1;
ci.xhot = ci.yhot = 0;
ci.pixels = &xp;
nullcursor = XcursorImageLoadCursor(xfc->display, &ci);
}
xfc->pointer = NULL;
if ((xfc->window) && (nullcursor != None))
XDefineCursor(xfc->display, xfc->window->handle, nullcursor);
xf_unlock_x11(xfc, FALSE);
#endif
return TRUE;
}
static BOOL xf_Pointer_SetDefault(rdpContext* context)
{
#ifdef WITH_XCURSOR
xfContext* xfc = (xfContext*) context;
xf_lock_x11(xfc, FALSE);
xfc->pointer = NULL;
if (xfc->window)
XUndefineCursor(xfc->display, xfc->window->handle);
xf_unlock_x11(xfc, FALSE);
#endif
return TRUE;
}
static BOOL xf_Pointer_SetPosition(rdpContext* context, UINT32 x, UINT32 y)
2015-02-02 17:32:49 +03:00
{
xfContext* xfc = (xfContext*) context;
XWindowAttributes current;
XSetWindowAttributes tmp;
BOOL ret = FALSE;
2015-02-02 17:32:49 +03:00
if (!xfc->focused || !xfc->window)
return TRUE;
2015-02-02 17:32:49 +03:00
xf_lock_x11(xfc, FALSE);
if (XGetWindowAttributes(xfc->display, xfc->window->handle, &current) == 0)
goto out;
tmp.event_mask = (current.your_event_mask & ~(PointerMotionMask));
2016-07-14 17:08:06 +03:00
if (XChangeWindowAttributes(xfc->display, xfc->window->handle, CWEventMask,
2016-10-04 10:00:00 +03:00
&tmp) == 0)
goto out;
XWarpPointer(xfc->display, None, xfc->window->handle, 0, 0, 0, 0, x, y);
tmp.event_mask = current.your_event_mask;
XChangeWindowAttributes(xfc->display, xfc->window->handle, CWEventMask, &tmp);
ret = TRUE;
out:
xf_unlock_x11(xfc, FALSE);
return ret;
2015-02-02 17:32:49 +03:00
}
/* Glyph Class */
static BOOL xf_Glyph_New(rdpContext* context, const rdpGlyph* glyph)
{
int scanline;
XImage* image;
xfGlyph* xf_glyph;
xf_glyph = (xfGlyph*) glyph;
xfContext* xfc = (xfContext*) context;
xf_lock_x11(xfc, FALSE);
scanline = (glyph->cx + 7) / 8;
2016-07-14 17:08:06 +03:00
xf_glyph->pixmap = XCreatePixmap(xfc->display, xfc->drawing, glyph->cx,
2016-10-04 10:00:00 +03:00
glyph->cy, 1);
image = XCreateImage(xfc->display, xfc->visual, 1,
2016-10-04 10:00:00 +03:00
ZPixmap, 0, (char*) glyph->aj, glyph->cx, glyph->cy, 8, scanline);
image->byte_order = MSBFirst;
image->bitmap_bit_order = MSBFirst;
XInitImage(image);
2016-07-14 17:08:06 +03:00
XPutImage(xfc->display, xf_glyph->pixmap, xfc->gc_mono, image, 0, 0, 0, 0,
2016-10-04 10:00:00 +03:00
glyph->cx, glyph->cy);
XFree(image);
xf_unlock_x11(xfc, FALSE);
return TRUE;
}
static void xf_Glyph_Free(rdpContext* context, rdpGlyph* glyph)
{
xfContext* xfc = (xfContext*) context;
xf_lock_x11(xfc, FALSE);
2011-11-24 22:01:34 +04:00
if (((xfGlyph*) glyph)->pixmap != 0)
XFreePixmap(xfc->display, ((xfGlyph*) glyph)->pixmap);
xf_unlock_x11(xfc, FALSE);
2016-07-20 11:06:45 +03:00
free(glyph->aj);
free(glyph);
}
static BOOL xf_Glyph_Draw(rdpContext* context, const rdpGlyph* glyph, UINT32 x,
2016-10-04 10:00:00 +03:00
UINT32 y, UINT32 w, UINT32 h, UINT32 sx, UINT32 sy,
BOOL fOpRedundant)
{
2011-11-24 22:01:34 +04:00
xfGlyph* xf_glyph;
xfContext* xfc = (xfContext*) context;
2011-11-24 22:01:34 +04:00
xf_glyph = (xfGlyph*) glyph;
xf_lock_x11(xfc, FALSE);
2016-08-17 10:26:59 +03:00
if (!fOpRedundant)
{
XSetFillStyle(xfc->display, xfc->gc, FillOpaqueStippled);
XFillRectangle(xfc->display, xfc->drawable, xfc->gc, x, y, w, h);
}
XSetFillStyle(xfc->display, xfc->gc, FillStippled);
XSetStipple(xfc->display, xfc->gc, xf_glyph->pixmap);
2016-08-17 10:26:59 +03:00
if (sx || sy)
WLog_ERR(TAG, "");
//XSetClipOrigin(xfc->display, xfc->gc, sx, sy);
XSetTSOrigin(xfc->display, xfc->gc, x, y);
2016-08-17 10:26:59 +03:00
XFillRectangle(xfc->display, xfc->drawing, xfc->gc, x, y, w, h);
xf_unlock_x11(xfc, FALSE);
return TRUE;
}
static BOOL xf_Glyph_BeginDraw(rdpContext* context, UINT32 x, UINT32 y,
2016-10-04 10:00:00 +03:00
UINT32 width, UINT32 height, UINT32 bgcolor,
UINT32 fgcolor, BOOL fOpRedundant)
{
xfContext* xfc = (xfContext*) context;
2016-08-10 18:01:54 +03:00
XRectangle rect;
2017-01-25 10:33:36 +03:00
XColor xbgcolor, xfgcolor;
2016-07-18 13:36:22 +03:00
2017-01-25 10:33:36 +03:00
if (!xf_decode_color(xfc, bgcolor, &xbgcolor))
2016-07-18 13:36:22 +03:00
return FALSE;
2017-01-25 10:33:36 +03:00
if (!xf_decode_color(xfc, fgcolor, &xfgcolor))
2016-07-18 13:36:22 +03:00
return FALSE;
2016-08-10 18:01:54 +03:00
rect.x = x;
rect.y = y;
rect.width = width;
rect.height = height;
xf_lock_x11(xfc, FALSE);
2016-08-17 10:26:59 +03:00
if (!fOpRedundant)
{
2017-01-25 10:33:36 +03:00
XSetForeground(xfc->display, xfc->gc, xfgcolor.pixel);
XSetBackground(xfc->display, xfc->gc, xfgcolor.pixel);
2016-08-17 10:26:59 +03:00
XSetFillStyle(xfc->display, xfc->gc, FillOpaqueStippled);
XFillRectangle(xfc->display, xfc->drawable, xfc->gc, x, y, width, height);
}
2017-01-25 10:33:36 +03:00
XSetForeground(xfc->display, xfc->gc, xbgcolor.pixel);
XSetBackground(xfc->display, xfc->gc, xfgcolor.pixel);
xf_unlock_x11(xfc, FALSE);
return TRUE;
}
static BOOL xf_Glyph_EndDraw(rdpContext* context, UINT32 x, UINT32 y,
2016-10-04 10:00:00 +03:00
UINT32 width, UINT32 height,
UINT32 bgcolor, UINT32 fgcolor)
{
xfContext* xfc = (xfContext*) context;
BOOL ret = TRUE;
2017-01-25 10:33:36 +03:00
XColor xfgcolor, xbgcolor;
2016-08-10 18:01:54 +03:00
2017-01-25 10:33:36 +03:00
if (!xf_decode_color(xfc, bgcolor, &xbgcolor))
2016-08-10 18:01:54 +03:00
return FALSE;
2017-01-25 10:33:36 +03:00
if (!xf_decode_color(xfc, fgcolor, &xfgcolor))
2016-08-10 18:01:54 +03:00
return FALSE;
if (xfc->drawing == xfc->primary)
ret = gdi_InvalidateRegion(xfc->hdc, x, y, width, height);
return ret;
}
2011-10-21 02:18:45 +04:00
/* Graphics Module */
2016-07-18 15:16:13 +03:00
BOOL xf_register_pointer(rdpGraphics* graphics)
{
rdpPointer* pointer = NULL;
if (!(pointer = (rdpPointer*) calloc(1, sizeof(rdpPointer))))
return FALSE;
pointer->size = sizeof(xfPointer);
pointer->New = xf_Pointer_New;
pointer->Free = xf_Pointer_Free;
pointer->Set = xf_Pointer_Set;
pointer->SetNull = xf_Pointer_SetNull;
pointer->SetDefault = xf_Pointer_SetDefault;
pointer->SetPosition = xf_Pointer_SetPosition;
graphics_register_pointer(graphics, pointer);
free(pointer);
return TRUE;
}
2011-10-21 02:18:45 +04:00
BOOL xf_register_graphics(rdpGraphics* graphics)
{
2016-07-21 11:07:42 +03:00
rdpBitmap bitmap;
rdpGlyph glyph;
2016-07-21 11:07:42 +03:00
if (!graphics || !graphics->Bitmap_Prototype || !graphics->Glyph_Prototype)
return FALSE;
2016-07-21 11:07:42 +03:00
bitmap = *graphics->Bitmap_Prototype;
glyph = *graphics->Glyph_Prototype;
bitmap.size = sizeof(xfBitmap);
bitmap.New = xf_Bitmap_New;
bitmap.Free = xf_Bitmap_Free;
bitmap.Paint = xf_Bitmap_Paint;
bitmap.SetSurface = xf_Bitmap_SetSurface;
graphics_register_bitmap(graphics, &bitmap);
glyph.size = sizeof(xfGlyph);
glyph.New = xf_Glyph_New;
glyph.Free = xf_Glyph_Free;
glyph.Draw = xf_Glyph_Draw;
glyph.BeginDraw = xf_Glyph_BeginDraw;
glyph.EndDraw = xf_Glyph_EndDraw;
graphics_register_glyph(graphics, &glyph);
return TRUE;
}
2016-08-03 15:16:20 +03:00
UINT32 xf_get_local_color_format(xfContext* xfc, BOOL aligned)
{
UINT32 DstFormat;
make cppcheck even more happier: [channels/tsmf/client/gstreamer/tsmf_X11.c:317] -> [channels/tsmf/client/gstreamer/tsmf_X11.c:322]: (warning) Either the condition '!decoder' is redundant or there is possible null pointer dereference: decoder. [channels/tsmf/client/gstreamer/tsmf_X11.c:470] -> [channels/tsmf/client/gstreamer/tsmf_X11.c:475]: (warning) Either the condition '!decoder' is redundant or there is possible null pointer dereference: decoder. [channels/tsmf/client/gstreamer/tsmf_X11.c:472] -> [channels/tsmf/client/gstreamer/tsmf_X11.c:475]: (warning) Either the condition '!decoder' is redundant or there is possible null pointer dereference: decoder. [channels/tsmf/client/tsmf_media.c:179] -> [channels/tsmf/client/tsmf_media.c:181]: (warning) Either the condition '!stream' is redundant or there is possible null pointer dereference: stream. [client/Windows/wf_cliprdr.c:2219] -> [client/Windows/wf_cliprdr.c:2222]: (warning) Either the condition '!formatDataResponse' is redundant or there is possible null pointer dereference: formatDataResponse [client/Windows/wf_cliprdr.c:2445] -> [client/Windows/wf_cliprdr.c:2448]: (warning) Either the condition '!fileContentsResponse' is redundant or there is possible null pointer dereference: fileContentsResponse. [client/X11/xf_cliprdr.c:911] -> [client/X11/xf_cliprdr.c:913]: (warning) Either the condition '!clipboard' is redundant or there is possible null pointer dereference: clipboard. [client/X11/xf_graphics.c:504] -> [client/X11/xf_graphics.c:506]: (warning) Either the condition '!xfc' is redundant or there is possible null pointer dereference: xfc. [libfreerdp/core/transport.c:861] -> [libfreerdp/core/transport.c:863]: (warning) Either the condition '!transport' is redundant or there is possible null pointer dereference: transport. [server/shadow/shadow_server.c:777] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server. [server/shadow/shadow_server.c:778] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server. [server/shadow/shadow_server.c:779] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server. [server/shadow/shadow_server.c:781] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server. [server/shadow/shadow_server.c:782] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server. [server/shadow/shadow_server.c:783] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server. [server/shadow/shadow_server.c:784] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server. [server/shadow/shadow_server.c:785] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server. [server/shadow/shadow_server.c:787] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server. [server/shadow/shadow_server.c:789] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server.
2017-01-26 12:44:19 +03:00
BOOL invert = FALSE;
2016-08-03 15:16:20 +03:00
if (!xfc)
return 0;
make cppcheck even more happier: [channels/tsmf/client/gstreamer/tsmf_X11.c:317] -> [channels/tsmf/client/gstreamer/tsmf_X11.c:322]: (warning) Either the condition '!decoder' is redundant or there is possible null pointer dereference: decoder. [channels/tsmf/client/gstreamer/tsmf_X11.c:470] -> [channels/tsmf/client/gstreamer/tsmf_X11.c:475]: (warning) Either the condition '!decoder' is redundant or there is possible null pointer dereference: decoder. [channels/tsmf/client/gstreamer/tsmf_X11.c:472] -> [channels/tsmf/client/gstreamer/tsmf_X11.c:475]: (warning) Either the condition '!decoder' is redundant or there is possible null pointer dereference: decoder. [channels/tsmf/client/tsmf_media.c:179] -> [channels/tsmf/client/tsmf_media.c:181]: (warning) Either the condition '!stream' is redundant or there is possible null pointer dereference: stream. [client/Windows/wf_cliprdr.c:2219] -> [client/Windows/wf_cliprdr.c:2222]: (warning) Either the condition '!formatDataResponse' is redundant or there is possible null pointer dereference: formatDataResponse [client/Windows/wf_cliprdr.c:2445] -> [client/Windows/wf_cliprdr.c:2448]: (warning) Either the condition '!fileContentsResponse' is redundant or there is possible null pointer dereference: fileContentsResponse. [client/X11/xf_cliprdr.c:911] -> [client/X11/xf_cliprdr.c:913]: (warning) Either the condition '!clipboard' is redundant or there is possible null pointer dereference: clipboard. [client/X11/xf_graphics.c:504] -> [client/X11/xf_graphics.c:506]: (warning) Either the condition '!xfc' is redundant or there is possible null pointer dereference: xfc. [libfreerdp/core/transport.c:861] -> [libfreerdp/core/transport.c:863]: (warning) Either the condition '!transport' is redundant or there is possible null pointer dereference: transport. [server/shadow/shadow_server.c:777] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server. [server/shadow/shadow_server.c:778] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server. [server/shadow/shadow_server.c:779] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server. [server/shadow/shadow_server.c:781] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server. [server/shadow/shadow_server.c:782] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server. [server/shadow/shadow_server.c:783] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server. [server/shadow/shadow_server.c:784] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server. [server/shadow/shadow_server.c:785] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server. [server/shadow/shadow_server.c:787] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server. [server/shadow/shadow_server.c:789] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server.
2017-01-26 12:44:19 +03:00
invert = xfc->invert;
2016-08-03 15:16:20 +03:00
if (xfc->depth == 32)
2016-08-03 22:22:06 +03:00
DstFormat = (!invert) ? PIXEL_FORMAT_RGBA32 : PIXEL_FORMAT_BGRA32;
2016-08-03 15:16:20 +03:00
else if (xfc->depth == 24)
{
if (aligned)
2016-08-03 22:22:06 +03:00
DstFormat = (!invert) ? PIXEL_FORMAT_RGBX32 : PIXEL_FORMAT_BGRX32;
2016-08-03 15:16:20 +03:00
else
2016-08-03 22:22:06 +03:00
DstFormat = (!invert) ? PIXEL_FORMAT_RGB24 : PIXEL_FORMAT_BGR24;
2016-08-03 15:16:20 +03:00
}
else if (xfc->depth == 16)
2017-01-19 19:14:16 +03:00
DstFormat = PIXEL_FORMAT_RGB16;
2016-08-03 15:16:20 +03:00
else if (xfc->depth == 15)
2017-01-19 19:14:16 +03:00
DstFormat = PIXEL_FORMAT_RGB15;
2016-08-03 15:16:20 +03:00
else
2016-08-03 22:22:06 +03:00
DstFormat = (!invert) ? PIXEL_FORMAT_RGBX32 : PIXEL_FORMAT_BGRX32;
2016-08-03 15:16:20 +03:00
return DstFormat;
}