mirrors/Bochs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Allow BX_SHARE_PATH to be used in BIOS paths (#288)

Browse Source 
This allows the Window's Environment variable BX_SHARE_PATH to be used
in paths within your bochsrc file.

Environment variable:
`BX_SHARE_PATH`
Value:
`D:\some\path`

Before:
`romimage: file=D:/some/path/bios/BIOS-bochs-latest`
After:
`romimage: file=$BXSHARE/bios/BIOS-bochs-latest`

Please note that I don't know why the parameter was initially empty. Was
this to catch a base/default parameter?
If the `lpValueName` parameter is NULL or an empty string, Windows will
return a (possibly non-existent) default value.
With this PR, we specify the actual parameter of `BX_SHARE_PATH`.
This commit is contained in:
Benjamin David Lunt 2024-03-17 22:03:07 -07:00 committed by GitHub
parent d94445257e
commit e3274339e2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bochs/config.cc
View File

@ -2097,7 +2097,7 @@ const char *get_builtin_variable(const char *varname)
if (code == ERROR_SUCCESS) {
data[0] = 0;
size = MAX_PATH;
if (RegQueryValueEx(hkey, "", NULL, (LPDWORD)&type, (LPBYTE)data,
if (RegQueryValueEx(hkey, "BX_SHARE_PATH", NULL, (LPDWORD)&type, (LPBYTE)data,
(LPDWORD)&size) == ERROR_SUCCESS) {
RegCloseKey(hkey);
return data;