mirrors/Bochs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

- Somebody was convinced that the enter instruction with level>0 was broken,

Browse Source 
and they added a panic.  Apparantly this instruction is not used very often
  because it went for a long time before anyone noticed.  Peter Tattam started
  running into the panic while emulating his OS called Petros, and through
  a comparison between vmware and bochs results he believes that enter is
  doing the right thing.  So, I have changed the panic into a BX_ERROR for now,
  and added code to ensure that it only gets printed once per bochs run.
This commit is contained in:
Bryce Denney 2002-03-05 15:50:17 +00:00
parent 6f3d73741a
commit 95467fa241
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
bochs/cpu/stack32.cc
View File

@ -1,5 +1,5 @@
///////////////////////////////////////////////////////////////////////// /////////////////////////////////////////////////////////////////////////
// $Id: stack32.cc,v 1.7 2001-10-03 13:10:37 bdenney Exp $ // $Id: stack32.cc,v 1.8 2002-03-05 15:50:17 bdenney Exp $
///////////////////////////////////////////////////////////////////////// /////////////////////////////////////////////////////////////////////////
// //
// Copyright (C) 2001 MandrakeSoft S.A. // Copyright (C) 2001 MandrakeSoft S.A.
@ -325,6 +325,7 @@ BX_CPU_C::ENTER_IwIb(BxInstruction_t *i)
Bit32u frame_ptr32; Bit32u frame_ptr32;
Bit16u frame_ptr16; Bit16u frame_ptr16;
Bit8u level; Bit8u level;
static Bit8u first_time = 1;
level = i->Ib2; level = i->Ib2;
@ -332,7 +333,10 @@ BX_CPU_C::ENTER_IwIb(BxInstruction_t *i)
level %= 32; level %= 32;
/* ??? */ /* ??? */
if (level) BX_PANIC(("enter(): level > 0")); if (first_time && level>0) {
BX_ERROR(("enter() with level > 0. The emulation of this instruction may not be complete. This warning will be printed only once per bochs run."));
first_time = 0;
}
//if (BX_CPU_THIS_PTR sregs[BX_SEG_REG_SS].cache.u.segment.d_b && i->os_32==0) { //if (BX_CPU_THIS_PTR sregs[BX_SEG_REG_SS].cache.u.segment.d_b && i->os_32==0) {
// BX_INFO(("enter(): stacksize!=opsize: I'm unsure of the code for this")); // BX_INFO(("enter(): stacksize!=opsize: I'm unsure of the code for this"));
// BX_PANIC((" The Intel manuals are a mess on this one!")); // BX_PANIC((" The Intel manuals are a mess on this one!"));