mirrors/Bochs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

- fix bug introduced by Bryce's revision 1.16, that causes you to get

Browse Source 
stuck at breakpoints forever.  Added a comment that says what code
  does that, so that future hackers will be warned.
This commit is contained in:
Bryce Denney 2001-09-27 23:41:18 +00:00
parent 198f783f8b
commit 610a7f5c1b
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
bochs/cpu/cpu.cc
View File

@ -724,14 +724,11 @@ BX_CPU_C::dbg_is_begin_instr_bpoint(Bit32u cs, Bit32u eip, Bit32u laddr,
Boolean valid;
dbg_xlate_linear2phy(BX_CPU_THIS_PTR guard_found.laddr,
&phy, &valid);
// why the condition "guard_found.icount!=0"? That means that
// breakpoints only occur when you're using "continue" but never
// when you're using "step". I'm going to try disabling taht
// condition and see what happens. This caused it to stop at
// a breakpoint even while trace-on is on.
if ( valid
//&& (BX_CPU_THIS_PTR guard_found.icount!=0)
) {
// The "guard_found.icount!=0" condition allows you to step or
// continue beyond a breakpoint. Bryce tried removing it once,
// and once you get to a breakpoint you are stuck there forever.
// Not pretty.
if (valid && (BX_CPU_THIS_PTR guard_found.icount!=0)) {
for (unsigned i=0; i<bx_guard.iaddr.num_physical; i++) {
if ( bx_guard.iaddr.phy[i].addr == phy ) {
BX_CPU_THIS_PTR guard_found.guard_found = BX_DBG_GUARD_IADDR_PHY;