From 5767dd64abf05f16cbc2b4f8372c58a084078cb7 Mon Sep 17 00:00:00 2001 From: Volker Ruppert Date: Mon, 4 Nov 2024 16:30:25 +0100 Subject: [PATCH] Banshee/Voodoo3: Report some more unsupported features. The most important unimplemented feature is the combined desktop / overlay display mode as shown in issue #369. --- bochs/iodev/display/banshee.cc | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/bochs/iodev/display/banshee.cc b/bochs/iodev/display/banshee.cc index 05ecb46b0..fbe4d90bf 100644 --- a/bochs/iodev/display/banshee.cc +++ b/bochs/iodev/display/banshee.cc @@ -731,6 +731,8 @@ void bx_banshee_c::write(Bit32u address, Bit32u value, unsigned io_len) } else if ((v->banshee.io[reg] & 0x180) == 0x100) { BX_INFO(("3D overlay mode enabled")); v->vtimer_running = 1; + } else if ((v->banshee.io[reg] & 0x180) == 0x180) { + BX_ERROR(("Desktop / overlay mode not supported yet")); } } v->banshee.hwcursor.enabled = ((v->banshee.io[reg] >> 27) & 1); @@ -750,6 +752,12 @@ void bx_banshee_c::write(Bit32u address, Bit32u value, unsigned io_len) if ((v->banshee.io[reg] >> 5) & 1) { BX_ERROR(("vidProcCfg: chromaKey mode not supported yet")); } + if ((v->banshee.io[reg] >> 14) & 1) { + BX_ERROR(("vidProcCfg: overlay horizontal scaling not supported yet")); + } + if ((v->banshee.io[reg] >> 15) & 1) { + BX_ERROR(("vidProcCfg: overlay vertical scaling not supported yet")); + } if ((v->banshee.io[reg] >> 16) & 3) { BX_ERROR(("vidProcCfg: overlay filter mode %d not supported yet", (v->banshee.io[reg] >> 16) & 3)); }