mirrors/Bochs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix buffer overflow

Browse Source
This commit is contained in:
Stanislav Shwartsman 2010-11-03 21:46:09 +00:00
parent d9734249b9
commit 4aef7661aa
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bochs/gui/textconfig.cc
View File

@ -1,5 +1,5 @@
/////////////////////////////////////////////////////////////////////////
// $Id: textconfig.cc,v 1.87 2010-04-04 11:28:33 vruppert Exp $
// $Id: textconfig.cc,v 1.88 2010-11-03 21:46:09 sshwarts Exp $
/////////////////////////////////////////////////////////////////////////
//
// Copyright (C) 2009 The Bochs Project
@ -786,7 +786,7 @@ void bx_param_string_c::text_print(FILE *fp)
for (int i=0; i<maxsize; i++) {
char eachbyte[16];
sprintf(eachbyte, "%s%02x", (i>0)?sep_string : "", (unsigned int)0xff&val[i]);
strncat(buffer, eachbyte, sizeof(buffer));
strncat(buffer, eachbyte, sizeof(eachbyte));
}
if (strlen(buffer) > sizeof(buffer)-4) {
assert(0); // raw byte print buffer is probably overflowing. increase the max or make it dynamic