ee8cf35f07
This patch makes "UnitTester BNode" pass. Several tests which attempt to create or access a directory entry that exceeds the maximum length assume that B_NAME_TOO_LONG status will be returned, since that is what BeOS does. When constructing a BNode with a path like "/tmp/some really long filename larger than 256 characters...", the vfs eventually calls bfs_lookup() which calls BPlusTree::Find(). In the case of a really long entry, Find() returns B_BAD_VALUE. This patch just changes BPlusTree::Find to return the more specific error that matches BeOS. Additionally this patch fixes some assertions in NodeTest. BeOS seems to have been missing some error checking code in the initialization of BNode, specifically with BNode(Directory*, const char*) and the equivalent SetTo method. If you provide an empty string for the child entry name to either of those, B_OK will be returned. But either way you initialize the object, when you try to use it, like with BNode::GetAttrInfo(), you'll get B_BAD_VALUE. This just changes any assertions for this situation to expect B_ENTRY_NOT_FOUND, which is the actual initialization error Haiku sets. This and the change to bfs resolves many assertions the following storage tests: * TestCaller BFile::Init Test 1 * TestCaller BFile::Init Test 2 * TestCaller BNode::Init Test1 * TestCaller BNode::Init Test2 * TestCaller BSymLink::Init Test 1 * TestCaller BSymLink::Init Test 2 Change-Id: I8598352aa341ffcab9f7bc3e6740ae1cb3dbab8c Reviewed-on: https://review.haiku-os.org/c/haiku/+/2490 Reviewed-by: waddlesplash <waddlesplash@gmail.com> |
||
|---|---|---|
| 3rdparty | ||
| build | ||
| data | ||
| docs | ||
| headers | ||
| src | ||
| .editorconfig | ||
| .gitignore | ||
| .gitreview | ||
| configure | ||
| Jamfile | ||
| Jamrules | ||
| lgtm.yml | ||
| License.md | ||
| ReadMe.Compiling.md | ||
| ReadMe.md | ||
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.