haiku/headers/private/media/MediaMisc.h
Jérôme Duval 9c9a810c41 Media Kit: BBufferCache: if not reclaimed, only mark the buffer for deletion
hrev53379 clears the buffer cache for disconnected clients, and also delete buffers.
This is too early (see #15263, media_addon_server crash), and should only happen
after the buffer is recycled. This can be resolved by abusing the fFlags field of
BBuffer to mark the buffer for deletion, and mark the buffer to be reclaimed.
Some BBuffers don't reside in the SharedBufferList, so we have to mark them as to
be reclaimed. For those in the SharedBufferList, call a new RemoveBuffer(), which
can check whether the buffer is still to be reclaimed. For reclaimed BBuffers,
delete them right away, others can be marked for deletion.
fixes #15606 #15263, possibly #15433

Change-Id: I66e94138e7e10a40d4c48e2ac042f816c79f5aab
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2245
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Reviewed-by: X512 <danger_mail@list.ru>
Reviewed-by: Ryan Leavengood <leavengood@gmail.com>
2020-02-16 08:38:49 +00:00

60 lines
1.6 KiB
C++

/*
* Copyright (c) 2003 Marcus Overhagen.
* All Rights Reserved.
*
* This file may be used under the terms of the MIT License.
*/
#ifndef _MEDIA_MISC_H_
#define _MEDIA_MISC_H_
// Used by Haiku apps to make media services notifications
void
progress_startup(int stage,
bool (*progress)(int stage, const char* message, void* cookie),
void* cookie);
void
progress_shutdown(int stage,
bool (*progress)(int stage, const char* message, void* cookie),
void* cookie);
#define IS_INVALID_NODE(_node) ((_node).node <= 0 || (_node).port <= 0)
#define IS_INVALID_NODEID(_id) ((_id) <= 0)
#define IS_INVALID_SOURCE(_src) ((_src).port <= 0)
#define IS_INVALID_DESTINATION(_dest) ((_dest).port <= 0)
#define NODE_JUST_CREATED_ID -1
#define NODE_UNREGISTERED_ID -2
#define NODE_SYSTEM_TIMESOURCE_ID 1
#define BAD_MEDIA_SERVER_PORT -222
#define BAD_MEDIA_ADDON_SERVER_PORT -444
#define IS_SYSTEM_TIMESOURCE(_node) ((_node).node == NODE_SYSTEM_TIMESOURCE_ID)
#define NODE_KIND_USER_MASK 0x00000000FFFFFFFFULL
#define NODE_KIND_COMPARE_MASK 0x000000007FFFFFFFULL
#define NODE_KIND_NO_REFCOUNTING 0x0000000080000000ULL
#define NODE_KIND_SHADOW_TIMESOURCE 0x0000000100000000ULL
#define ROUND_UP_TO_PAGE(size) (((size) + B_PAGE_SIZE - 1) & ~(B_PAGE_SIZE - 1))
#define MEDIA_SERVER_PORT_NAME "__media_server_port"
#define MEDIA_ADDON_SERVER_PORT_NAME "__media_addon_server_port"
#define BUFFER_TO_RECLAIM 0x20000000
#define BUFFER_MARKED_FOR_DELETION 0x40000000
extern const char *B_MEDIA_ADDON_SERVER_SIGNATURE;
namespace BPrivate { namespace media {
extern team_id team;
} } // BPrivate::media
using namespace BPrivate::media;
#endif