def61273ed
Fixes #6423 and helps with #14626. In BringUpInterfaces, line 772 creates an error which only adds a missing interface if one does not already exist (i.e., !_testInterface()). This can lead to a missing WiFi interface if an Ethernet connection has been configured and set in the /boot/system/settings/network/interfaces before the WiFi has had a chance to be added to /dev/net. To properly configure a missing device, such as a WiFi connection, and allow the user to choose amongst configured interfaces (i.e., add it to the list of devices in /dev/net and e.g., see WiFi as an option), removing the 'if' statement on line 772 is necessary. Two edge cases may arise: 1. A user may disable an interface -- don't add device Solution: The code currently handles this. _ConfigureInterfacesFromSettings, called at line 746, checks for interfaces in fSettings to see if they are disabled (706-711). If so, they are disabled and not set as a missingDevice if the interface is disabled (709). The next interface is checked... etc. 2. Devices must not be added twice (i.e., Checking for An Existing configured Network) Solution: The code currently checks for this. On lines 716-720, a device that is found in fSettings (missingDevice), is set to the interface which is later added to the /dev/net within that (unnecessary?) if statement (772). The missingDevice will only be set and added to /dev/net if an entry does not exist in the settings already (716) (hence the identifier missingDevice). Change-Id: Ifc303371b88f18c30141a651a7d97a3c860e864f Reviewed-on: https://review.haiku-os.org/767 Reviewed-by: waddlesplash <waddlesplash@gmail.com> |
||
|---|---|---|
| 3rdparty | ||
| build | ||
| data | ||
| docs | ||
| headers | ||
| src | ||
| .editorconfig | ||
| .gitignore | ||
| .gitreview | ||
| configure | ||
| Jamfile | ||
| Jamrules | ||
| License.md | ||
| ReadMe.Compiling.md | ||
| ReadMe.md | ||
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our OpenGrok servers:
- http://xref.plausible.coop/ (provided by Landon Fuller)
- http://code.metager.de/source/xref/haiku (provided by MetaGer)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.