e01bbf955f
This issue only manifested itself when the navigation toolbar was shown. The scrollbar appeared to have no border while the rest did. This issue manifested when the scrollbar insets were adjusted in hrev49654. The scroll bar insets were really hiding the bug underlying bug though. I'll try to explain what was happening and how I fixed it. The PoseView container, called BorderedView, was showing its top border when the navigation bar was hidden, and hiding its top border when the navigation bar was shown. This (almost) worked because the menu bar provided a bottom border while the navigation toolbar didn't. However hiding BorderedView's top border also hid the scroll bar border. My solution was to draw a bottom border on the navigation toolbar and then remove the top border from BorderedView unconditionally. So either the menu bar or the navigation toolbar provides a bottom border and the BorderedView has no top border. Fixes #12392
114 lines
3.0 KiB
C++
114 lines
3.0 KiB
C++
/*
|
|
Open Tracker License
|
|
|
|
Terms and Conditions
|
|
|
|
Copyright (c) 1991-2000, Be Incorporated. All rights reserved.
|
|
|
|
Permission is hereby granted, free of charge, to any person obtaining a copy of
|
|
this software and associated documentation files (the "Software"), to deal in
|
|
the Software without restriction, including without limitation the rights to
|
|
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
|
|
of the Software, and to permit persons to whom the Software is furnished to do
|
|
so, subject to the following conditions:
|
|
|
|
The above copyright notice and this permission notice applies to all licensees
|
|
and shall be included in all copies or substantial portions of the Software.
|
|
|
|
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF TITLE, MERCHANTABILITY,
|
|
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
BE INCORPORATED BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN
|
|
AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF, OR IN CONNECTION
|
|
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
Except as contained in this notice, the name of Be Incorporated shall not be
|
|
used in advertising or otherwise to promote the sale, use or other dealings in
|
|
this Software without prior written authorization from Be Incorporated.
|
|
|
|
Tracker(TM), Be(R), BeOS(R), and BeIA(TM) are trademarks or registered trademarks
|
|
of Be Incorporated in the United States and other countries. Other brand product
|
|
names are registered trademarks or trademarks of their respective holders.
|
|
All rights reserved.
|
|
*/
|
|
#ifndef _NAVIGATOR_H
|
|
#define _NAVIGATOR_H
|
|
|
|
|
|
#include <ToolBar.h>
|
|
|
|
#include "ContainerWindow.h"
|
|
#include "Model.h"
|
|
|
|
|
|
class BTextControl;
|
|
class BEntry;
|
|
|
|
namespace BPrivate {
|
|
|
|
enum NavigationAction
|
|
{
|
|
kActionSet,
|
|
kActionForward,
|
|
kActionBackward,
|
|
kActionUp,
|
|
kActionLocation,
|
|
kActionUpdatePath,
|
|
|
|
kNavigatorCommandBackward = 'NVBW',
|
|
kNavigatorCommandForward = 'NVFW',
|
|
kNavigatorCommandUp = 'NVUP',
|
|
kNavigatorCommandLocation = 'NVLC',
|
|
kNavigatorCommandSetFocus = 'NVSF'
|
|
};
|
|
|
|
|
|
class BNavigator : public BToolBar {
|
|
public:
|
|
BNavigator(const Model* model);
|
|
~BNavigator();
|
|
|
|
void UpdateLocation(const Model* newmodel, int32 action);
|
|
|
|
BContainerWindow* Window() const;
|
|
|
|
protected:
|
|
virtual void MessageReceived(BMessage* msg);
|
|
virtual void AttachedToWindow();
|
|
virtual void AllAttached();
|
|
virtual void Draw(BRect updateRect);
|
|
|
|
void GoForward(bool option);
|
|
// is option key held down?
|
|
void GoBackward(bool option);
|
|
void GoUp(bool option);
|
|
void SendNavigationMessage(NavigationAction, BEntry*, bool option);
|
|
|
|
void GoTo();
|
|
|
|
private:
|
|
BPath fPath;
|
|
BTextControl* fLocation;
|
|
|
|
BObjectList<BPath> fBackHistory;
|
|
BObjectList<BPath> fForwHistory;
|
|
|
|
typedef BView _inherited;
|
|
};
|
|
|
|
|
|
inline
|
|
BContainerWindow*
|
|
BNavigator::Window() const
|
|
{
|
|
return dynamic_cast<BContainerWindow*>(_inherited::Window());
|
|
}
|
|
|
|
|
|
} // namespace BPrivate
|
|
|
|
using namespace BPrivate;
|
|
|
|
|
|
#endif // _NAVIGATOR_H
|