a34c877fd0
FontFamily is babysitted by the FontManager. It doesn't own FontStyle references, there's no place in it to release them. FontManager owns a reference to the FontStyle, and it is in fStyleHashTable. Putting a style there acquires a new reference, so we can release the one from the new style. Removing a style from the map releases the reference. We need to clear the map before shutting down FreeType to get rid of our last references and let the styles die now instead of afterwards to avoid double freeing the faces. These solve the new crash from the previous patch. It didn't crash before because even after the map was destroyed there were still dangling references to the styles. On removing a user font, the style will remove itself from the family through the manager if that was the last reference, and the manager will remove and delete the family if it has no more styles. Change-Id: I460ff830fa8a8a5adb90dc8ea12120e1e50a5912 Reviewed-on: https://review.haiku-os.org/c/haiku/+/6052 Reviewed-by: waddlesplash <waddlesplash@gmail.com> |
||
|---|---|---|
| 3rdparty | ||
| build | ||
| data | ||
| docs | ||
| headers | ||
| src | ||
| .editorconfig | ||
| .gitignore | ||
| .gitreview | ||
| configure | ||
| Jamfile | ||
| Jamrules | ||
| lgtm.yml | ||
| License.md | ||
| ReadMe.Compiling.md | ||
| ReadMe.md | ||
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.