7065a89fc6
The ioctl call cannot know the expected number of arguments because it depends on the specific ioctl being used, and the same value could be used to do different things by different devices. Without knowing that, it is not safe to use va_arg (at best a random value will be read from the stack, at worst, it will just crash). This changes the implementation of ioctl in two ways: - For C++ code: a 4 argument function with default values for arguments 3 and 4. - For C code: wrap arguments 3 and 4 in a struct with the help of a macro, providing something that behaves like the C++ version. So, with this new code: - Calling ioctl with only 3 arguments sets the 4th one to 0 - Calling ioctl with only 2 arguments sets the 3rd and 4th to 0 - Calling with 1 or 5+ arguments is a compile time error The existing ioctl symbol is preserved for ABI compatibility. Change-Id: I6d4d1d38fccd8cc9bd94203d3e11aeac6da8efc3 Reviewed-on: https://review.haiku-os.org/c/haiku/+/3360 Reviewed-by: Adrien Destugues <pulkomandy@gmail.com> |
||
|---|---|---|
| 3rdparty | ||
| build | ||
| data | ||
| docs | ||
| headers | ||
| src | ||
| .editorconfig | ||
| .gitignore | ||
| .gitreview | ||
| configure | ||
| Jamfile | ||
| Jamrules | ||
| lgtm.yml | ||
| License.md | ||
| ReadMe.Compiling.md | ||
| ReadMe.md | ||
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.