3f7f989680
The level parameter in the CopyEngine::CollectCopyInfo() and CopyEngine::Copy() methods was introduced in hrev30395 to allow the CopyEngine to decide which directories should be copied. Since then, this class has been rewritten and it is no longer necessary for that purpose. This change refactors the CopyEngine and removes the level parameter from the class interface. Furthermore, it was broken to begin with; it was passed as reference to the internal recursive _Copy() and _CollectCopyInfo() methods, meaning they acted like a global counter. The global counter was increased at the beginning and decreased at the end of those methods. Execution could terminate early though, leaving the level counter out of sync with the recursion level. There is one use of the level parameter, namely in the WorkerThread::EntryFilter::ShouldClobberFolder() method, but the use of the parameter was wrong (it would have been at level 3 at the point of the check, not level 2) and the logic is functional without the level check. Change-Id: Id92ef89b015e9b1185bde061273f61e492664bce Reviewed-on: https://review.haiku-os.org/c/haiku/+/3139 Reviewed-by: Adrien Destugues <pulkomandy@gmail.com> Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.