107712bf01
AutoRaise needs to load bitmaps stored as resources in the AppRaise image. The strategy it used before was to store the path to itself in its settings file. It stored the entry_ref to the image in the settings, which may not be stable across reboots with packagefs. In addition, the path could change at some point for any other reason. This patch changes AutoRaise to just use the same method as other tray applets, which is to search the process for the image containing the AutoRaise code, and then to get the path from the image_info. Most of the initialization work is performed by TrayView::_init(), which is called by the constructor. Some of the operations performed by this method can fail, leaving TrayView partially initialized. Any error is handled by returning early after telling Deskbar to remove this item so that it will not continue running in a partially initialized state. Deskbar will invoke the destructor so even a partially initialized TrayView will be cleaned up. Fixes #16473 Change-Id: Id1ac1ef78d410a7d191cfe88f1ba1db30e258adc Reviewed-on: https://review.haiku-os.org/c/haiku/+/3341 Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.