0615a177b7
This moves the entire 64 bit handling into _GetBarInfo() and applies it to the PCI address and size too. Previously only the RAM address was handled for the 64 bit case. Also fixes the 64 bit check to be done after the type determination. Previously it would theoretically be possible for an IO BAR with the lowest address bit set for that type (bit 3) to be mistaken to be 64 bit and then skipping/mishandling the next BAR. Due to alignment this would have needed to be a 4 byte IO BAR though. This also corrects the limit for 64 bit BARs of type 1 devices. As there are only two slots, only slot 0 can be 64 bit. Also removes a copy&paste error that would lead to the high address of 64 bit BARs of type 1 devices to get taken from the h0 instead of h1 struct, corrupting its value. Make the mandatory arguments to _GetBarInfo() references to make the distinction more obvious and replace 0 with NULL in the default values. Change-Id: Iae59f2875c93f15411a4d9791e71e69ba7a42287 Reviewed-on: https://review.haiku-os.org/c/haiku/+/3022 Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.