Commit Graph

51213 Commits

Author SHA1 Message Date
Philippe Saint-Pierre
c4f80d1ee8 CID 1108469: Use after free 2014-07-15 16:11:51 -04:00
Philippe Saint-Pierre
eda1d21fde CID 991761: potential double close (and white space fix) 2014-07-15 15:34:36 -04:00
Puck Meerburg
d32cb23734 Fix Coverity bug 603941: Negative array index read
Signed-off-by: Philippe Saint-Pierre <stpere@gmail.com>
2014-07-15 15:14:56 -04:00
Philippe Saint-Pierre
37b6c4337c CID 1162772: Missing break (and typos fixed) 2014-07-15 14:46:27 -04:00
Philippe Saint-Pierre
fcd2bfb773 Style fix, no functional changes
Thanks Axel!
2014-07-15 14:06:49 -04:00
Colin Günther
172c55faf1 FFMPEG plugin: Refactor video decoding function.
- We factor out the code that does the decoding, deinterlacing and color space
  converting into its own function. This prepares auto detection of video frame
  properties in a later commit. Auto detection means (for example), that you
  don't need to know the size of the decoded video frame -before- intitializing
  the video codec as it is the case with the current implementation.

- Use the already existent private member variable fHeader to fill out and
  return video frame properties.

- Rename some variables to be more self describing.

- No functional change intended.

Signed-off-by: Colin Günther <coling@gmx.de>
(cherry picked from commit 6beab04f48e98022041895750f38c5a35a5f4f9e)
2014-07-15 15:49:22 +02:00
Colin Günther
29da3b5548 FFMPEG plugin: Add links to useful FFMPEG-API documentation.
- As it is rather hard to find useful documentation, on how to use FFMPEG's API
  we cut of some research time by just documenting it at the place where it is
  most visible to other FFMPEG plugin developers :)

Signed-off-by: Colin Günther <coling@gmx.de>
(cherry picked from commit b0ed15d2196ca45de8ab2d5913d760602aacc5f3)
2014-07-15 15:49:17 +02:00
Colin Günther
9e52cc7480 FFMPEG plugin: Use member variables instead of local ones.
- This small refactoring is in preparation for implementing decoding of partial
  video frame data, where one needs to preserve encoded data between multiple
  calls to  AVCodecDecoder::_DecodeVideo().

- Note: The names fChunkBuffer and fChunkBufferSize are open for discussion.
  I'd rather prefer fEncodedDataChunkBuffer and fEncodedDataChunkBufferSize.
  But I'd like to take small refactoring steps, and changing the naming would
  also touch the AVCodecDecoder::_DecodeAudio() function. I'd rather focus
  on improving the video part for now, leaving the audio part alone.

- No functional change intended.

Signed-off-by: Colin Günther <coling@gmx.de>
(cherry picked from commit f2da1e752458b926aebe50642bf6af19e9903f17)
2014-07-15 15:49:13 +02:00
Philippe Saint-Pierre
384eec8fb3 Ticket #3385: inconsistencies when single window + disks icon
When using the Show Disks icon option, single window navigaton mode,
and starting navigation by the Disks icon, these bugs would occurs
upon entering child poses :

*) The draggable icon at the top right wouldn't appear
*) The file menu wouldn't update properly (for example, the New folder
menu item won't show)

Based in part on dru_ed's patch.
2014-07-14 21:16:35 -04:00
John Scipione
18842fc23e Add newline to end of BShape docs 2014-07-14 19:16:06 -04:00
John Scipione
24588f6b80 BShape: Rename these params back in header.
Accidentally renamed these in the header, rename them back to
match the cpp file. These param names might not be very good but
they match the struct variable names. They are private methods
anyway. No functional change intended in either commit.
2014-07-14 19:15:13 -04:00
John Scipione
cb65c3a037 Document BShape and BShapeIterator 2014-07-14 19:03:20 -04:00
John Scipione
db1ef05aef BShape: Style fixes for docs 2014-07-14 19:02:44 -04:00
John Scipione
22da33b202 Add a few missing \fn's to BFont docs 2014-07-14 19:02:12 -04:00
Jérôme Duval
4fab93c7fc clean up files unrelated to the FreeBSD 9.3 driver update. 2014-07-14 18:21:38 +02:00
Ingo Weinhold
fa50ee854d package: Add checksum command 2014-07-14 00:46:20 +02:00
Ingo Weinhold
03b36acbe6 package recompress: Small cleanup 2014-07-14 00:45:45 +02:00
Ingo Weinhold
e1e6c12480 BPackageWriter::Recompress(): Change param to BPositionIO*
Besides that this is a nicer interface, it allows us to get a the HPKG
header as a side effect of initializing the reader, thus preventing
seeking backward in the file. This makes "package recompress - <file>"
work.
2014-07-13 17:57:57 +02:00
Ingo Weinhold
43a6b92c64 PackageReaderImpl: Delay reading sections until ParseContent() 2014-07-13 17:57:56 +02:00
Ingo Weinhold
3cc6297e22 package recompress: Add stdin/stdout support
stdin doesn't work quite yet. We'll need to convince the BPackageReader
to skip parsing the TOC and package attributes sections.
2014-07-13 17:57:56 +02:00
Ingo Weinhold
1606450b32 ReaderImplBase::Init(): Make file size check optional
If the file doesn't support GetSize(), skip the header total size file
size check.
2014-07-13 17:57:56 +02:00
Ingo Weinhold
05b565f4f2 Add private BDataPositionIOWrapper
Implements the BPositionIO interface on top of a BDataIO, requiring the
{Read,Write}At() accesses to be sequential.
2014-07-13 17:57:56 +02:00
Ingo Weinhold
44c4771163 BPackageWriter: Add BPositionIO support 2014-07-13 17:57:55 +02:00
Julian Harnath
b916156a83 Move libroot synchronization functions to private namespace
* Prefix lock functions with __ to mark them as private. Add
  forwarding macros to keep existing code working.

* Avoids symbol name clashes with kernel lock APIs, occuring when
  using kernellandemu-lib in userlandfs. Thanks to Ingo for the
  suggestion.
2014-07-13 16:19:08 +02:00
Julian Harnath
2e75b75292 Fix building Haiku from Haiku
* Always include cdefs.h to have __[BEGIN|END]_DECLS defined.
  Somehow, this didn't affect cross-build, but it made building
  from Haiku fail.
2014-07-13 15:35:31 +02:00
Ingo Weinhold
f9ecc54e69 package: Explicitly use B_HPKG_COMPRESSION_NONE 2014-07-12 23:13:11 +02:00
Ingo Weinhold
8f5130edfa package kit: Actually add support for B_HPKG_COMPRESSION_NONE
Until now we always declared in the HPKG header that the package file is
zlib compressed. For uncompressed files we would just store all
individual chunks uncompressed. Now we handle completely uncompressed
files slightly differently: We don't write the redundant chunk size
table anymore. The size savings are minor, but it makes the uncompressed
format read-streamable which may be handy.
2014-07-12 23:12:21 +02:00
Ingo Weinhold
e8681d9409 Increase boot loader size for x86* boot floppy a bit 2014-07-12 18:41:09 +02:00
Ingo Weinhold
e527b79631 Switch package file accessor classes to use BPositionIO
* PackageFileHeap{Reader,Writer} as well as Package{Reader,Writer} and
  their implementation and super classes do now internally use a
  BPositionIO instead of a FD to access the package file. This provides
  more flexibility needed for features to come.
* BPackageReader has already grown a new Init() version with a
  BPositionIO* parameter.
2014-07-12 15:40:22 +02:00
Ingo Weinhold
01e6d687c0 boot loader: Add pwrite(), lseek(), ftruncate()
ftruncate() is just a stub (needed for BFdIO).
2014-07-12 15:40:22 +02:00
Ingo Weinhold
c55a06055f Add private class BFdIO
Simple BPositionIO implementation using the POSIX API on a FD. In effect
similar to BFile, but more easily ported to kernel and boot loader (and
the FD is reusable).
2014-07-12 15:40:21 +02:00
Ingo Weinhold
8546c4160e BPositionIO: Add {Read,Write}AtExactly()
Analoguous to {Read,Write}Exactly(), just for the *At() versions.
2014-07-12 15:40:21 +02:00
Ingo Weinhold
1b50eb7d91 Remove unnecessary zlib build feature dependency 2014-07-12 15:40:21 +02:00
Jérôme Duval
57f444065f Update FreeBSD network drivers with the 9.3 release 2014-07-12 14:32:52 +02:00
Rene Gollent
712e51d79a Build fix. 2014-07-11 20:16:01 -04:00
Rene Gollent
e4adab2698 Debugger: Fix minor issue noted in #11003.
- Reset tooltip when it's no longer needed (i.e. if the file path changes).
  Otherwise, we'd erroneously show the old tooltip if the new path was short
  enough to no longer be truncated, as would often happen after locating a
  missing source file.
2014-07-11 20:07:25 -04:00
Julian Harnath
2f1684345e Use BPathFinder to find userlandfs add-ons
* ...to make it work with packaged and non-packaged.
2014-07-12 02:00:10 +02:00
Julian Harnath
604770b313 Adapt kernelland_emu to kernel API changes
* Adapt to changes in kernel synchronization APIs.

* Makes userlandfs work again.
2014-07-12 02:00:08 +02:00
Julian Harnath
a0d87686f4 Adapt userlandfs kernel-addon to atomic_* API changes.
* Remove volatile qualifiers, use atomic_get() for safe access

* Fixes build of userlandfs
2014-07-12 02:00:05 +02:00
Akshay Jaggi
192f01c669 XHCI USB: Some more fixes.
* Fix device speed identification.
* Fix Max Packet Size for Full-Speed devices.
* Fix IRQ rate.
* Update slot context for LS/FS devices connected to non-root HS hub.
* Fix typo.

Signed-off-by: Jérôme Duval <jerome.duval@gmail.com>
2014-07-12 00:11:39 +02:00
Jérôme Duval
74e1a530f8 Revert unrelated part of 17aa359b5d. 2014-07-11 22:23:21 +02:00
Akshay Jaggi
17aa359b5d XHCI USB: Fixes.
* Add support for hubs in AllocateDevice().
* Prevent page fault in FinishTransfers().
* Set fCapabilityLength
* Correct in BIOS ownership code
* Fix context errors in _InsertEndpointForPipe().
* Update constants according to latest Specification (v1.1)
* Fix SMI code (reference
http://lkml.iu.edu/hypermail/linux/kernel/1204.2/02460.html).
* Fix Memory/Device-Slot leaks.
* Fix area allocation for TRBs.
* Fix for Intel Lynx Point and Panther Point chipsets. Also move init
of xhci before ehci, to switch USB 2.0 ports before the ehci module
discovers them.

Signed-off-by: Jérôme Duval <jerome.duval@gmail.com>
2014-07-11 22:14:05 +02:00
John Scipione
8674959175 Input Server: Fix double free.
CID610594
2014-07-11 13:04:26 -04:00
John Scipione
b128ce7eff Input Server: style fix, compare with 0 explicitly 2014-07-11 13:02:51 -04:00
Augustin Cavalier
7481292e36 CDPlayer: remove from image & delete
* Does not work on recent hardware
  * It now lives at: https://github.com/HaikuArchives/CDPlayer

Signed-off-by: Axel Dörfler <axeld@pinc-software.de>
2014-07-09 22:54:51 +02:00
Axel Dörfler
de9c061339 bfs: Use the QueryParserUtils instead of its own copy.
* Ingo copied the methods into a shared location, and then obviously
  "forgot" to let BFS use them. As a side note for Ingo: the complete
  error GCC reported was "std::fssh_size_t" not defined with the macro
  wrapper as code location. The actual problem was a "using std::size_t"
  in some C++ header that accidentally got included after the wrapper.
* The shared Query code is not yet used. That'll be done another time.
* Renamed BFS_SHELL define to FS_SHELL, such that QueryParserUtils can be
  used in any file system shell, not just the bfs_shell.
2014-07-09 22:54:39 +02:00
Axel Dörfler
ba32021824 bfs: fixed wrong key comparison in validator.
* bplustree_header::DataType() is not compatible with the type constants
  compareKeys() expects. Use _CompareKeys() instead.
2014-07-09 22:54:39 +02:00
Augustin Cavalier
e35fa24e16 Update BePDF package and its dependencies.
Signed-off-by: Oliver Tappe <zooey@hirschkaefer.de>
2014-07-09 22:18:03 +02:00
Augustin Cavalier
8566c721c7 file_systems/cdda: Various fixes.
* When restoring shared attributes, don't affect CDDB:lookup status
 * Volume renames should not affect CDDB:lookup status, only file renames should

This fixes some of the "cddb_daemon not updating CD info" problems.

Signed-off-by: Jérôme Duval <jerome.duval@gmail.com>
2014-07-09 20:54:38 +02:00
Jérôme Duval
e8f82cdb6e file_systems/cdda: avoid leaking the attributes fd.
* see bug #9528.
2014-07-09 20:54:11 +02:00