Thanks to mmlr for pointing out element could not be NULL.
Change-Id: I89d85fdd2cc30efd54c81f6c50a5497208bab5d2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3259
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
The previous code tried to add a boolean to the quit requested message,
but that is not propagated from the app to the window QuitRequested, so
it didn't work. Instead, split the task between the app and the window'
QuitRequested functions.
Remove use of custom list class where it is not
really required in the area of Depots. Also
convert the use of Depots to be wrapped in
BReference to match other model objects. At the
same time some data-loading logic has been
simplified.
Relates To #15534
Change-Id: Ie6fcc35f258a0c69c44990e4b09f6c32ec79945d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3225
Reviewed-by: Rene Gollent <rene@gollent.com>
Just like post-install scripts which run shortly after a package is
installed, pre-uninstall scripts are run just before a package is
removed. Implements enhancement #13427
* Fix script exit code handling vs script launch errors.
* Bump package and repo file version numbers due to new attribute,
unfortunately makes new .hpkg files not backwards compatible.
* Add pre-uninstall functionality, mostly cloning the post-install
except in a few places.
* Discover that _RunQueuedScripts() is never called, a future TODO:?
* Update package documentation for pre-uninstall scripts, and use of
the boot/post-install directory.
Change-Id: I45596255ce74bc102f6e5b606cbf83e4e4347a17
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1504
Reviewed-by: Alexander G. M. Smith <agmsmith@ncf.ca>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
When the window was deactivated once, cursor wouldn't blink anymore on next activation. Fixes#16388
Change-Id: Id7042e078df2a5c5b397763cf544626efc5e589a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3258
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
The brightness is saved in the screen configurations of the first
workspace. For now, all screens get the same brightness (I can't get
screen IDs to work today). Since we only support setting the brightness
for laptop displays for now, this shouldn't matter. It can be fixed when
app_server gets actual multiple display support.
Fixes#14254
Change-Id: Ib33aa65a73407a65bd469d0efa8542210fec02d4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/362
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
* Essentially, EFI system partitions are just FAT32 formatted.
* We really haven't tried EFI booting on MBR (normal choice is GPT)
* I see no reason to *not* allow folks to create these.
* Align partition name to GPT's naming
Change-Id: I4cd52d542ea618f1ffe52927e15237fc10bb386c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3224
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Only does the parameter error checking.
Change-Id: Idee4a8e8e183d45c4a14236c32ff40e52ccb2555
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1534
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Split apart the work done in https://review.haiku-os.org/c/haiku/+/2695
in smaller, easier to review parts.
This commit contains self-contained/local changes that are unlikely to
cause problems.
Change-Id: Idae27ca440791423e3d090bcfe33f4cc83bbea3d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3174
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Use BStringList instead of bespoke List class for
lists of strings.
Also fix the prominences so that the sort
ordering in the featured packages uses the sorting
algorithm properly.
Relates To #15534
Change-Id: I56e67931aa08e6bfee6d2be21a459152216790e2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3232
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
This is a version of the qsort function allowing you to pass a "cookie" to the function.
Change-Id: I60c645213b9c9590e38b112634fcac1d7969b6d9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2449
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
MediaPlayer is basing its time on both the audio and video frames. This
doesn't go so well when there is a single video frame, resulting in the
whole file being one single "timepoint".
Avoid this problem by having the video decoder set the frame time to
"infinite" when the video stream is finished, which allows for the audio
timings to be used in this case.
Also improve the framerate handling of ffmpeg further, to avoid
MediaPlayer trying to frameskip at 90000fps (it would give up
frameskipping after a few frames and eventually notice that the next
frame was the end of stream, but still, not very clean). Now we report
an FPS of 0 instead, which should make it clear to applications what to
expect from single-frame files.
It seems the cover art is now hidden by a black screen, I'm not sure
why. But I'll leave debugging this for another day.
Fixes#13622.
Change-Id: Ie1dd1358cbb41c11649103dfce52a0e1317b26f8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2562
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
* add break statement to the last clause of switch/cases
* fix some other minor issues
Change-Id: I9ac3dac0cda0b14043b975938caea88b79bb749f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1299
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
* don't reset the APERF and MPERF MSRs, they could be in use otherwise.
* use EPP or EPB to select power-save or performance mode
* HWP_REQUEST_PACKAGE disabled (as other OSes seem to do).
Change-Id: I26eb0b05c402b131a4ab174ad6f9ddf8e9367709
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3222
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
also update model list from Linux intel_pstate_cpu_ids.
Change-Id: I20926dc8553fbf1ade8afcccaaedfc2846787bb3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3221
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
when the cpufreq module is loaded, we let the scheduler update its policy.
Improve assert report
CoreEntry::GetLoad() could return more than kMaxLoad.
Change-Id: I127f9b3e8062b5996872aae30b4021b9904fa179
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3216
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
Combined with a buildtools CL, this will change the AR variable
to be more in line with conventions, where AR points at the binary and
ARFLAGS are the arguments to AR, while keeping compatibility with the
original style of using the AR variable.
Change-Id: I2b9797b9e5ab35929970487b3d1b8dddb9476c1f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3227
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
implement on x86 with APERFMPERF.
Change-Id: Ia484854c76dee76c5447983de15800a25d791d39
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3213
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
to call a function on the target cpu. Early mechanism not available.
Change-Id: I9d049e618c319c59729d1ab53fb313b748f82315
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3212
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
- InstallerWindow.cpp announces a message with a boolean that defines whether the install has been completed. That boolean will define InstallerApp.cpp's behavior.
- Changed the method that was used (unsuccessfully) to open FirstBootPrompt within the Installer itself, upon quitting.
Change-Id: Ibbba2f0ee3b79e091032294afcb3ed404e898f5c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3218
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
BSecureSocket currently only checks for trust anchors in the CA file,
this change will add the openssl certs/ directory as a trust anchor dir.
this matches the behaviour openssl has on the commandline and allows
users to install their own trust anchors to verify against for TLS
Change-Id: I9db5c3f3b063607e092dded3d5b141dba340a8e2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3207
Reviewed-by: Fredrik Holmqvist <fredrik.holmqvist@gmail.com>
