Commit Graph

45503 Commits

Author SHA1 Message Date
Pawel Dziepak
2723b9eba4 nfs4: Fix CID 991506: memory leak in case of error 2013-03-19 02:22:14 +01:00
Pawel Dziepak
246c199c40 nfs4: Fix memory leaks in case of error in ReplyInterpreter::_DecodeAttrs()
This patch fixes CID 991505, 991504, 991502, 991500, 991499, 991496.
2013-03-19 01:34:22 +01:00
Pawel Dziepak
f73dd62491 nfs4: Fix CID 991294: error handling issues in Auth::CreateSys() 2013-03-19 01:24:06 +01:00
Pawel Dziepak
b0e5bfeab5 nfs4: Fix CID 991246: use name of the old entry when reporting removal 2013-03-19 01:24:05 +01:00
Pawel Dziepak
b42b242f62 nfs4: Fix CID 991174: improve error checking in NFS4Inode::OpenFile() 2013-03-19 01:24:04 +01:00
Pawel Dziepak
271d1540b1 nfs4: Do not rely on implementation defined casting uint32 to int32
This solves CID 991172.
2013-03-19 01:24:03 +01:00
Pawel Dziepak
a43c0e5ce0 nfs4: Fix error checking in NFS4Server::_Renewal()
This fixes CID 990985.
2013-03-19 01:24:02 +01:00
Pawel Dziepak
c689b9f5f1 nfs4: Fix CID 990984 and 991173: missing assignment in error check 2013-03-19 01:24:01 +01:00
Pawel Dziepak
e975b31db3 nfs4: Ensure that a string is NULL terminated after strncpy()
This fixes CID 990971.
2013-03-19 01:24:00 +01:00
Pawel Dziepak
62e43541d7 nfs4: Fix wrong parenthesising in ReplyInterpreter::_FlattenPathname
This patch solves CID 990966.
2013-03-19 01:23:59 +01:00
John Scipione
6e8749b27f Update BMessage documentation adding Get* methods.
Also, lots of little cleanups: formatting, adding return statements and
return values where they were missing, fix spelling mistakes, add newlines to
separate command blocks, remove trailing whitespace.
2013-03-18 20:05:45 -04:00
Axel Dörfler
bc4dd456f9 ActivityMonitor: fixed minor issue CID 609788.
* If the circular buffer was created with a size of zero, fBuffer would
  be freed without being initialized.
2013-03-19 00:56:47 +01:00
Axel Dörfler
161400fbcc intel_extreme: sanitize EDID modes as well.
* Since we add those modes to our mode list, we should better accept them.
* This may help with bug #9145, and #7523 if they still occur.
2013-03-18 22:11:26 +01:00
John Scipione
cf7c89ff4a Use the new Get* BMessage methods to simplify code.
Thanks Axel!
2013-03-18 11:48:58 -04:00
Siarzhuk Zharski
c7047b8fd2 Improve handling of mbyte chars in UTF8Char::IsSpace
* Switch UTF8Char's IsSpace, IsAlNum, ToLower functions to use
  system-wide BUnicodeChar service routines;
* Switch TermView::CharClassifier to use UTF8Char instead of
  raw char* string ponter. That reduces count of conversions
  and simplify code;

  Fixes #7423.
2013-03-17 16:45:49 +01:00
Siarzhuk Zharski
53953e3e68 Remove useless font style/family settings defaults
No need for PREF_HALF_FONT_FAMILY/_STYLE defaults to be defined explicitly,
these entries will be filled with corresponding params of the current system
fixed font if they are not available from the settings file.

Fixes #9531.
2013-03-17 16:45:44 +01:00
Siarzhuk Zharski
c2577509f9 Optimize SIGWINCH Shell notification
Fixes issue with missed SIGWINCH shell notification in case the
Terminal frame was resized by using any of "Settings"->"Window size"
menu items.

Fixes #9293 - original problem was pointed out by Ziusudra. Thank you!
2013-03-17 16:45:38 +01:00
Siarzhuk Zharski
1dd3b537c3 Fix Alternate/Normal screen's current attributes handling
Handle the current attributes of the TextBuffer consistently with other
Alt/Normal buffer sensitive variables. That fixes, for example, issues
with wrong background coloring of new lines in normal text buffer after
maximizing the terminal window running applications (like MC) performing
output onto alternate screen.
2013-03-17 16:45:29 +01:00
Siarzhuk Zharski
13d0439623 Terminal data flow debug capture improved
This modification moves the debug characters capture call directly into
the _NextParseChar(). That allows to capture all data flow without
missing things like OSC control sequences.
2013-03-17 16:45:23 +01:00
Siarzhuk Zharski
0ac0b4d4a6 Fix Terminal cursor Save/Restore behaviour
Yet another fix for the terminal cursor save/restore functionality.
Fixes wrong cursor positions observed in modern versions of the
Midnight Commander during switching between Alternate and Normal buffers.
2013-03-17 16:45:18 +01:00
Siarzhuk Zharski
15e83c4548 Omit Terminal Id title in case single app instance running
Hide the current index of Terminal window from it's title if only
ony instance of the Terminal application is running in the system.

Fixes #9530.
2013-03-17 16:45:12 +01:00
Siarzhuk Zharski
ef60154123 Handle font style on loading default Terminal preferences
Fix the PrefHandler::_ConfirmFont to take into account not only the
font family but the font style too. This improves the popup menu
checkmark synchronization in the Preferences View. This problem can
be reproduced on very first start of application without previously
stored Terminal settings. Default family/style for this case is
currently defined as "Courier 19BT"/"Regular" but default fixed
font has correspondently "DejaVu Sans Mono"/"Book". Previous version
of _ConfirmFont() process only the family and left the style in default
"Regular" one. So opening Preferences View and attempting to set the
checkmark on corresponding family/style menuitem was usually failed.
2013-03-17 16:45:06 +01:00
John Scipione
d58ff0b187 Add BTextView class docs 2013-03-16 17:22:56 -04:00
John Scipione
ab21cedcce Remove docs and refactor style of TextView class.
* Make pointer style consistent, const char* name instead of const char *name.
* Lots of parameter renaming.
* in parameters don't get anything special, just font, or length instead of
  inFont, inLength.
* out parameters get a leading _ so *outWidth becomes *_width for example.
* We don't detail private function in the Haiku book and this class has a bunch
  so keep the documentation in the file but use regular comments instead.
* Normalize the parameter names between cpp file and header.
* Some minor whitespace fixes.

No functional change intended.
2013-03-16 17:05:09 -04:00
John Scipione
ca9a59bbc5 add a newline 2013-03-16 17:04:44 -04:00
John Scipione
163a2afd4f Use the single parameter version of SetInsets()
While I'm at it, I can reduce the LayoutBuilder indent by 1.
2013-03-16 16:11:12 -04:00
John Scipione
c0778509d2 Copy pasta error, double checked this time 2013-03-16 11:55:27 -04:00
John Scipione
4c45b1d99e Perform settings checking again partially reverting 43917ef.
Also storedSettings to prefs as it is shorter, easier to read the code.
2013-03-16 11:30:42 -04:00
John Scipione
e1c882014b Update screen prefs layout. Fixes #8817
* Center monitor info and Workspaces label.
* Use font-relative spacing.
* Update the header including copyright year, sort contributors by name and add
  myself as well.
2013-03-16 10:15:30 -04:00
John Scipione
4307b2e057 Diskprobe open window layout fixes 2013-03-16 08:59:28 -04:00
John Scipione
d3a0b2dccf Deskbar prefs i18n updates. Fixes #8562
* AddGlue() to the Menu box to make it expand with wider translations.
* Order checkboxes vertically to better accomidate wider translations.
2013-03-16 08:12:50 -04:00
Niels Sascha Reedijk
cadffca7e5 Update translations from Pootle 2013-03-16 06:22:01 +01:00
John Scipione
fe9f33d1c2 Reorder Default and Revert buttons in Appearance.
To match at least a couple other preflets that have Default and Revert buttons
such as Locale, CPU Frequency, Tracker, and Mouse.
2013-03-15 21:55:53 -04:00
John Scipione
5bfc9c7091 Save and load prefs window position to and from a file. 2013-03-15 21:44:59 -04:00
John Scipione
f49eecb564 Use horizontal strut instead of insets 2013-03-15 21:35:02 -04:00
John Scipione
a3f512d524 Rename Recent items back to Menu and tweak to make fit.
* Put the Open in Tracker... button back in Menu.
* Put the window checkboxes in 2 columns.
* Use vertical struts instead of insets for spacing in a couple places.
2013-03-15 21:35:01 -04:00
John Scipione
a601c3f172 Add 'Open menu in Tracker' button at bottom 2013-03-15 21:35:00 -04:00
John Scipione
633232da4c Reorder buttons.
Defaults then Revert both on left like Tracker and Locale and other preflets.
2013-03-15 21:34:59 -04:00
John Scipione
43917ef2e0 Refactor settings so that defaults get set in 1 place.
* Move desk_settings and clock_settings struct to a new header entitled
  'BarSettings.h' so it can be included in BarApp.h and PreferencesWindow.h.
* Refactor desk_settings to only include used, or at least relevant settings,
  some cruft had built up over time.
* Refactor the InitSettings() method, all the B_OK checking wasn't working so
  I removed it. Defaults get set up to and if the corresponding setting is
  found in the settings file it is replaced, else, it is not.
* Reorder the struct and code so it goes in the order that the settings appear:
  applications, then recent items, then window settings.
* Simplify the preferences window revert and defaults code based on using the
  prebuild desk_settings structs in BarApp instead of creating our own and
  copying. All initial setup is in the constructor.
2013-03-15 21:34:58 -04:00
John Scipione
cb42238603 Destroy prefs window on close once again 2013-03-15 21:34:57 -04:00
John Scipione
1ec3d37252 Rename 'Sort running applications' to 'Sort applications by name' 2013-03-15 21:34:56 -04:00
John Scipione
cb0602cf81 Implement Revert and Default buttons in Deskbar prefs 2013-03-15 21:34:36 -04:00
John Scipione
93a58e5028 Reformat Deskbar prefs all in one with no tabs 2013-03-15 21:33:59 -04:00
Ziusudra
41130d1c52 Terminal: Fixed small code duplication
SetTermSize(BRect) already contains all the code calling SetTermSize(int, int).
Partially fixes #9293.
2013-03-15 15:15:43 +00:00
Ziusudra
9f726b367b Terminal:Add ACS symbols supported by xterm-256color
More ACS (also known line drawing) symbols should be supported by
xterm-256color terminal emulator.
Partially fixes #9293.
2013-03-15 15:15:19 +00:00
Fredrik Holmqvist
39a81e5ac6 The optimised aligned version was broken and not used.
As pointed out by Hamish the alignment used && in second case
instead of &, which meant it was never used.

Another error when a32 was 0xFF000000 and b32 was 0xFF00FFFF
would return a non zero value. A simple fix for the issues
with going over to the byte by byte comparison failed, so
rather than leave broken code I remove this for the time being.

Not the best code I've written obviously.
2013-03-15 11:49:13 +01:00
François Revol
3881911cce Add the !DOCTYPE element to the text/html sniff rule 2013-03-15 00:55:38 +01:00
Siarzhuk Zharski
5b41331f11 CodeStyle fixes, some refactoring and cleanup
* Clear some codestyle issues catched by checker script;
* Rename RestartDebugCapture to more consistent StartStopDebugCapture;
* Updated Copyrights and authors lists, some occurences of the raw MIT
  licence text replaced with "under the terms of MIT licence" reference;
* Fixes for x86_64 build.

This is cumulative cleanup commit for series of Terminal refactoring
changes I have introduced last time. No significant functional changes.
2013-03-14 07:44:52 +00:00
Siarzhuk Zharski
fe25686978 Move colors table from TermView to TerminalBuffer
* ColorsTable moved to TerminalBuffer to let easy lookup of table
  during parsing of control sequences;
* Default Palette initialized from now in TermApp and preserved
  from modifying by applications;
2013-03-14 07:44:50 +00:00
Siarzhuk Zharski
bbfd23abd5 Use native bold style drawing (+ switchable emulation)
Use native bold font for rendering characters with corresponding
attribute set. Possibility for switching to R5-like bold characters
emulation is also implemented. This one uses uses the left-down shadow
in B_OP_BLEND drawing mode instead of the rigth-down one as previously.
2013-03-14 07:44:48 +00:00