Part of #9460
* If there is an operation between signed and unsigned int, the unsigned is changed to signed one,
except for some operations (if before the operation the signed one is checked to be less than
zero or not, then the signed one get cast to be unsigned (errors due to sign error when casting
are impossible))
* When doing operations on pointers, integers get cast to uintptr_t type
Untested: I don't have the hardware.
Change-Id: I6a959c004862e055ee99f6f2ad5ca3397b32cdd2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7484
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Needed for the echo indigo soundcard driver build.
IRQ is used as a field name in pmcia/cs.h. The IRQ() macro should only
be used with parameters. So we can avoid the use of IRQ in cs.h being
accidentally replaced by the macro.
Change-Id: Ib10f3c5148cfb7c87a0b258a95a590778b6e5cb4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7608
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
In the new "automatic" mode, the number of displayed colors
is just 3, as opposed to the full 38. Much more manageable!
The HSL routines added in this commit were derived from
https://gist.github.com/ciembor/1494530 which is itself derived
from the Wikipedia page describing HSL/HSV.
Part of #15543 and #11636.
Change-Id: I230a358d18c379fb0673162e0b3cbdb8d1b8d84e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7479
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
There seem to be a gcc2 bug resulting in bitfields of uint32 type being cast to int.
The bitfield is mostly not needed here, since the fields are 8, 16 or 32
bits, so just use the appropriate types.
Change-Id: Ie4297db8bcda8ca0937c7f55915b318a1f4f6e55
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7599
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Most of the time when this function is invoked,
the menu is not yet attached to a window, and so
there is no looper to lock. But some of the time,
there is, leading to a crash if we don't lock it.
Fixes#18875.
* Don't allocate a context up front if we're
just going to free it anyway.
* Actually set the various flags originally set
in the constructor in the place where the context
is actually allocated.
* Remove now-duplicate thread_count assignment.
This commit in no form is intended to provide a working/functional
driver, but rather as a starting base and minimal code contribution
for GSoC.
This driver can only identify if the current device is a Sound
VirtIO device.
Change-Id: I718bb87c768dd84ff2be77a14e839f94955671fc
Signed-off-by: Diego Roux <diegoroux04@protonmail.com>
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7557
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
Regression from hrev57294.
The code introduced there relies on the state of the "open" button being
updated from a previous selection in the file panel. But that is no the
case if the B_REFS_RECEIVED message does not come from the file panel
(in this case it comes directly from the favorites menu).
Fixes#18627.
Change-Id: Ic12b1989a4fbd631ce048aa6286d4d7c60ab1d99
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7577
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
background: Inodes structure needs to be updated in the same on Disk format for uniforming the code.
Inode structure is Updated to the OnDisk format same as that of Extent Header and the relative Changes are made to Inode class.
Change-Id: I1e89c514a7abe29479b152c6b038ff8b7c94abce
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7552
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
The frame rate in the codec context isn't always a frame frate in the
video sense. It may be a smaller time unit used as a base for the frame
presentation timestamps.
I did not initially notice this because we set it to a default value
from the AVFormat passed input encoded_video format, but it is erased
after reading the first frame.
Fixes#18797.
Change-Id: I6157ae9942f6d5ca32aad7bac012df0822659a21
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7563
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Back when this log was introduced, it could not be tested because no
hardware hitting that limit was known. Now there is some.
Add the actual number of IOAPIC redirection entries to the log, so we
can know how many redirection entries we need, and also add a missing
newline.
Change-Id: I00fa0c21628fc336c364cd975dd48801add75302
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7579
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Otherwise the logfile always exists on all Haiku installs. There is
nothing useful logged to it if no hardware is found.
Change-Id: I290cb0ac070256dbd2647d5fe36ab71f825600e8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7578
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Try to handle two cases mentionned here: https://github.com/xCuri0/ReBarUEFI/wiki/DSDT-Patching
- Min/Max/Length/Gran are all zero, but no resource tag (ignore the range)
- Length is larger than Min/Max window (recompute the length)
Should fix#18454
Change-Id: I536dc06fcfbfc9aacf5eb6b9563cf03f9d09178a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7581
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Linux implementation: https://www.spinics.net/lists/kernel/msg2665216.html
In our case it is not possible to read the original descriptor from
quirk handlers, so, I had to hardcode it all. The descriptor is the same
as the original one with just 3 bytes changed (detailed in comments).
Other Elecom hardware requires similar quirks, but can have different
number of buttons, so I did not add it for now.
Change-Id: Ie24c8535f3b4535eb414a4e35a62696ea1f9056d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7580
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
The same fix was done some time ago in Appearance preferences, but the
version in WebPositive had not been updated.
Allows to select the current version of Noto Sans Mono as the monospace font.
Change-Id: I829f80cab3ea224c9963147cc333877edafdeebe
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7576
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
Use BDateTimeFormat, BDateFormat, and BNumberFormat for
various date, time, decimal, and percent formatting.
Change-Id: I994563d207db8bd28342ca6543b69a356ced38af
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7505
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
The fd was passed to strerror instead of the error code.
Also add CALLED() macro to trace function calls in the btrfs code and in
fs_shell (disabled by default but enabled by TRACE defines as usual).
Change-Id: I3b8958679412132349b33d5cd686ddbafc120f1c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7494
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
On IPv4-only configurations, there is no need to try to ping an IPv6
address. This flag tells getaddrinfo to filter out these addresses (or
likewise for IPv6 only).
Fixes#18867
Change-Id: I22295b0f33cf7c01d5cfacc562594c936cf97ee3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7560
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Requires HaikuPorts#7573 to be merged.
Closes#17836.
Smoke-tested on beta4 32 bits:
Gutenprint printer addon loads libgutenprint.so.9.5.0, shows new
printer models from where to choose from at "install new printer"
time, and "prints something" when using the Print-To-File transport.
Change-Id: Ia40dfd3c2163795e83c2cc173fd510d64c4bf6c9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5969
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Change-Id: I45b3fbe0b4ec014d185ea8c3ed8798ae316e54a9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7554
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Partial change, for testing on x86_64. You need to build with
-sHAIKU_NO_DOWNLOADS=1 and manually provide the needed packages in
generated/downloads.
Confirmed working on x86_64. Other platforms will need similar updates.
Change-Id: I81ca4b1d81bd18e64f50250970e00e0a072072d3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7278
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
* This condition here is "we are unaware of this filesystem
or it is not formatted"
* Since a filesystem could exist, we don't want to falsely
guide users that data doesn't exist within a partition,
when it could actually exist.
* In this case, I had a bcachefs filesystem, which showed
in DriveSetup as "Not formatted (Linux data)"
* With this change, the language adjusts to "Unknown (Linux data)"
Change-Id: Ib88fea16ee9403419d54bb5223ceee950591ce56
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7540
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Reviewed-by: humdinger humdinger <humdinger@mailbox.org>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
