Commit Graph

59369 Commits

Author SHA1 Message Date
Augustin Cavalier
d520204085 Fix various instances of -Wsign-compare. 2018-11-24 17:48:02 -05:00
Augustin Cavalier
f6fe382433 MainBuildRules: Fail if the generated struct-offsets header is empty.
In some LTO-related experiments, it came out empty due to GCC
not generating actual assembly but rather intermediate code,
resulting in various later targets failing with quite literally
thousands of errors.
2018-11-24 14:35:10 -05:00
Augustin Cavalier
1e30709b20 repositories: On @minimum profile, don't build unneeded packages.
This significantly speeds up @minimum builds (by a few minutes,
depending on your CPU and disk speed.)
2018-11-24 13:57:03 -05:00
Murai Takashi
137ac19964 String.cpp: Fix PVS 625
Fix 'newBuffer' is assigned values twice successively.

Change-Id: Id6ec9d40ba279a68e17922931098a6a908eb7156
Reviewed-on: https://review.haiku-os.org/728
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2018-11-24 12:04:41 +00:00
Murai Takashi
a9002af95e UndoBuffer.cpp: Fix PVS 471
Fix 'fTypedText' is assigned values twice successively.

Change-Id: Ibadf2fced0f448441e541293d04b86bc14909c35
Reviewed-on: https://review.haiku-os.org/729
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2018-11-24 12:04:32 +00:00
Jérôme Duval
bf98f7960d Added license file for GNU GPL v2 with classpath exception. 2018-11-24 11:43:22 +01:00
Augustin Cavalier
e5b11ae3c7 ArchitectureRules: Remove -Wno-unused-parameter.
I added this here so that one could set -Wextra in BuildConfig and
not be bombarded with useless warnings; but it seems that GCC2 chokes
on it instead of ignoring it. Oh well.
2018-11-23 19:58:22 -05:00
Augustin Cavalier
382fff8961 ArchitectureRules: Enable -Wuninitialized and -Wunused-but-set.
Also clean up the warning flags in general; they are now
more readable.
2018-11-23 19:14:49 -05:00
Augustin Cavalier
003a1997d5 ps2/elantech: Initialize variables to shut up GCC. 2018-11-23 19:13:37 -05:00
Augustin Cavalier
d4c38925ba configure: Restore execute bit.
It seems "git stash" on Windows loses filemodes... sorry about that.
2018-11-23 18:40:47 -05:00
Augustin Cavalier
62c7ec5c06 Fix various instances of -Wset-but-unused.
Largely no functional change; most of these are just
removing the unused variables.
2018-11-23 18:04:38 -05:00
Augustin Cavalier
8732e626e2 pkgman: Handle -y argument to "drop-repo" command.
Found by -Werror=set-but-unused.
2018-11-23 18:00:08 -05:00
Augustin Cavalier
430f303fda file_systems/cdda: Set CDDB lookups based on the actual parameter.
Found by -Werror=set-but-unused.
2018-11-23 17:59:35 -05:00
Barrett17
e0a6d5ceeb MediaClient: Fix -Werror=set-but-unused
* The error wasn't checked.
2018-11-23 23:46:31 +01:00
Augustin Cavalier
d113c00b5a Remove more HOST_PLATFORM_SUNOS cruft. 2018-11-23 16:29:57 -05:00
Augustin Cavalier
807304b100 build: Add basic support for MinGW hosts.
This doesn't fully work yet (the FS code in libroot_build
needs to be adapted, as some of the symlink-related calls
are not available on MinGW), but it gets much further than
the "Cygwin" target did.
2018-11-23 16:24:25 -05:00
Augustin Cavalier
37c106060a build: Remove support for cross-building from Cygwin and SunOS.
These have been broken for a long time. Some Cygwin changes that
are relevant on MinGW are kept here, but users on Windows who
want to build Haiku should probably use WSL at this point.

However, now that we are using relative paths and don't need
to worry about drive path kludges, it's actually possible to
get some host tools built on MinGW. Changes for that coming.
2018-11-23 15:40:50 -05:00
Murai Takashi
26b2733af3 Locale kit: Fix PVS 550, 551
Use BStackOrHeapArray instead of applying auto_ptr to array.

Change-Id: I204dcb97a1bc2d047783bc6015f86b36ca0cc15b
Reviewed-on: https://review.haiku-os.org/725
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
2018-11-23 18:57:02 +00:00
Humdinger
6f1cd477d4 Improved "Get Haiku" download graphic 2018-11-23 07:31:06 +01:00
Augustin Cavalier
cb101bdad6 BootRules: Fix BuildMBR under Clang.
We need to force -m32 here, and we also need to tell Clang that we
want to allow relocations in .text.

Clang builds now get to kernel entry, but the bootloader fails to
load the early-boot modules with strange remapping errors, and so
panics with "get boot partitions failed!"
2018-11-23 00:06:23 -05:00
Augustin Cavalier
2b69731ab3 Jamfile: Remove doc_files.
Unused.
2018-11-23 00:06:23 -05:00
Augustin Cavalier
c371f18d7e OverriddenJamRules: Remove TODO.
All relevant flags have been added to ASFLAGS where necessary.
2018-11-23 00:06:23 -05:00
Augustin Cavalier
df34a27137 build: Do not use regular TARGET_*FLAGS in kernel and bootloader.
The generic CCFLAGS are already appended to the HAIKU_KERNEL_*FLAGS
and HAIKU_BOOT_*FLAGS, so these were just duplicates. And now that
we strip certain flags out of the base ones, this was incorrect
(and causes Clang to error in some circumstances.)
2018-11-23 00:06:23 -05:00
Augustin Cavalier
58b7901304 ArchitectureRules: Bootloader rules cleanup.
* Move -fPIC to ccBaseFlags, as we don't want it in ASFLAGS.
 * Remove -fPIC from BOOT_CCFLAGS, as we never want it in there.
 * Move EFI flags to the actual EFI setup location.
2018-11-23 00:06:23 -05:00
Barrett17
44fc903a8f Codec Kit: Introduce BCodecRoster
* This class include almost everything you need to
manage codecs and iterate over them.
2018-11-22 17:41:26 +01:00
Peter Kosyh
fa94c7d6a5 mail: IMAP fix recv forever loop on server close connection
When reading stream from closed (by server) TCP socket throw StreamException (not ParseException).
This fixes forever loop in Protocol::HandleResponse on server disconnect.

This patch fixes #14710

Change-Id: I29e9830b360cb56cb1ef037c0378d64422075c4d
Reviewed-on: https://review.haiku-os.org/724
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2018-11-22 15:23:14 +00:00
Murai Takashi
81728c84c5 modifiers: Fix PVS 743
Fix  'gotone' is assigned values twice successively.

Change-Id: Ibe9f531ba4d16cec61b49cc49e842486b5ab6f64
Reviewed-on: https://review.haiku-os.org/700
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
2018-11-22 15:22:19 +00:00
Barrett17
f5a452910a Codec Kit: Add some TODO for the future
* Little beauty fixes included.
2018-11-22 09:48:04 +01:00
Barrett17
06b088bd62 Streamer: Make constructor private 2018-11-22 09:47:12 +01:00
Barrett17
f40547016d Encoder: Make constructor private 2018-11-22 09:47:12 +01:00
Barrett17
c09a589891 Decoder: Make constructor protected 2018-11-22 09:47:12 +01:00
Barrett17
a741fb49a6 Writer: Make constructor and Init protected 2018-11-22 09:47:12 +01:00
Barrett17
75b5f33c19 Reader: Make constructor protected 2018-11-22 09:47:11 +01:00
Barrett17
af34e7abcc Codec Kit: Beauty fixes 2018-11-22 09:47:11 +01:00
Augustin Cavalier
c6c8dd4e2c syslog_daemon: We don't need strlcpy.c anymore. 2018-11-21 23:52:49 -05:00
Augustin Cavalier
b54ed691ed ArchitectureRules: Remove duplicate GCC_BASE_FLAGS.
We append the full CC_FLAGS in KernelArchitectureSetup,
so these are redundant and not used anywhere else,
so scrap them completely.
2018-11-21 23:52:35 -05:00
Augustin Cavalier
a87c7773e8 EFI: Make the loader build under Clang.
Clang doesn't support -maccumulate-outgoing-args, -nostartfiles
is not needed in LDFLAGS (and lld doesn't know about it anyway),
and Clang uses .dynstr so we need to copy it also.
2018-11-21 22:02:06 -05:00
Augustin Cavalier
2e15a0f6b9 registrar: Move R5Compatibility to test directory.
Only the test_registrar uses it now (but maybe this is a leftover
that can be removed from it, too?)
2018-11-21 21:27:12 -05:00
Augustin Cavalier
241b61a7f5 Revert "configure: Change default ARFLAGS to use deterministic mode."
This reverts commit da693d1fdc.

GCC2 binutils doesn't like this. As mentioned in the previous commit,
"u" is a no-op on modern binutils and only issues a warning.
2018-11-21 21:16:40 -05:00
Augustin Cavalier
da693d1fdc configure: Change default ARFLAGS to use deterministic mode.
Jambase now expects this (and its defaults were changed); and this
is already the default on most systems, so adding this should
silence the "D is now the default mode" warning.
2018-11-21 19:16:50 -05:00
Augustin Cavalier
633e29aeb6 Jamrules: Add a hard requirement on the new Jambase.
And remove the overridden rules that were migrated back to it.
2018-11-21 19:16:50 -05:00
Barrett17
32bcb26dfc Remove inadvently added merge-conflict file
* Sorry about that, I've been splitting the
commits and it did end up here.
2018-11-21 17:35:04 +01:00
Barrett17
b1c8bb2c46 MediaFile/MediaTrack: Use MetaData API internally 2018-11-21 17:24:33 +01:00
Barrett17
854c698a52 ffmpeg: Move AVCodecWriter to BMetaData 2018-11-21 17:23:58 +01:00
Barrett17
608c9d9ae1 Codek Kit: Introduce BMetaData in Writer/MediaWriter
* Remove SetCopyright as well.
2018-11-21 17:22:58 +01:00
Barrett17
9b50ad1db8 MediaFile/MediaTrack: Use metadata to retrieve copyright 2018-11-21 16:57:05 +01:00
Barrett17
c6a23a5827 ffmpeg: Use new BMetaData API 2018-11-21 16:56:41 +01:00
Barrett17
3e8f721b3b Codec Kit: Introduce BMetaData in Reader/Extractor
* Remove superfluous Copyright method.
2018-11-21 16:55:02 +01:00
Barrett17
9bbd53a288 BMetaData: Add missing functionality
* Add more metadata keys needed to support ffmpeg.
* Implement methods allowing to embed BMetaData into
BMetaData.
* Add methods to handle more types.
2018-11-21 16:51:19 +01:00
Barrett17
f722040584 BMetaData: Finalize implementation
* Use string keys. I am still convinced we need BValue.
* Use boolean instead of status_t in return, this is
much more handy in pratical use given that there's no
really a status to check.
2018-11-21 12:46:54 +01:00