Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
26,246 Commits 9 Branches 0 Tags 473 MiB
c96c57848d
Commit Graph

26246 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Michael Lotz
bdff2c8222 * CID 1044: Add more explicit NULL check before dereferencing in TRACE statement. 
* Whitespace cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27470 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-13 00:44:12 +00:00
Michael Lotz
4e9bf24dd5 CID 26: The status variable was shadowed inside the while loop causing the outer 
status to always be B_OK, resulting in an incomplete buffer instead of an error
if the append failed.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27469 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-13 00:28:29 +00:00
Michael Lotz
0c397beb9c CID 1021: Move NULL check before dereferencing "string" in the TRACE statement. 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27468 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-13 00:10:40 +00:00
Michael Lotz
d02cde3053 CID 877: Fix memory leak in error case. 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27467 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-13 00:06:59 +00:00
Michael Lotz
2c0a05cce1 CID 1258: This was probably missed when replacing all "write" with 
operation->IsWrite().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27466 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-13 00:01:48 +00:00
Fredrik Modeen
a426099957 fixes CID 455 Check for NULL and use std::nothrow 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27465 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 19:08:31 +00:00
Fredrik Modeen
2d9f1f59b3 fixes pointed by Axel and some stile changes. 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27464 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 18:29:30 +00:00
Fredrik Modeen
327a88fbc1 fixes pointed out by Axel, and style changes. 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27463 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 18:29:16 +00:00
Fredrik Modeen
80f39d66d4 fixes pointed out by Michael and Axel, thanks for pointing those out. 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27462 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 18:06:52 +00:00
Michael Lotz
b57520d4a9 * Don't leak the decoded instructions in case the device object cannot be 
allocated.
* Remove accidentally added debug device id.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27461 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 18:02:07 +00:00
Stephan Aßmus
8008c36e34 Fixed CID 1272. Looks like _addressLength is allowed to be NULL, but 
at function exit, it was still dereferenced.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27460 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 17:31:48 +00:00
Stephan Aßmus
870dc73f78 Fixed CID 1292. If the allocation or adding to the list of the very first Buffer failed, 
the buffer data would be leaked. Note that for failure to allocate later buffers, the
data is correctly freed in _FreeBuffers().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27459 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 17:24:32 +00:00
Michael Lotz
0a28b4e324 CID 1261: The "previous" list entry wasn't maintained, causing lost list items 
when removing a non-first element.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27458 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 17:17:29 +00:00
Michael Lotz
5565f43e07 Check the allocation of the endpoint pipe object. 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27457 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 17:10:35 +00:00
Michael Lotz
11b9aad7f7 * Use new(std::nothrow) everywhere (NULL checks were already there). 
* Fix a warning if trace output is not enabled.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27456 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 17:00:28 +00:00
Michael Lotz
8395debafa * CID 7: The fObjectArray that holds the usb_id to object association was never 
freed.
* Also the allocation of said array was not checked.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27455 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 16:48:41 +00:00
Stephan Aßmus
67710adc92 Fixed CID 1303. The config message was dereferenced in the constructor list. 
I don't know if it can be NULL at all, but let's be defensive. It was
already checked later anyways.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27454 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 16:29:52 +00:00
Fredrik Modeen
f1ca556caf Fixed CID 321, 868: check item for NULL and delete recource leak 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27453 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 14:15:47 +00:00
Fredrik Modeen
ee652e3aab reverted to 11769 and added (std::nothrow) 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27452 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 14:06:56 +00:00
Ryan Leavengood
dd84bf1de8 Reverting r27437 as per Axel's advice. The variable size is initialized by the 
call to ElementAt. Marked CID 1306 as false.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27451 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 13:46:50 +00:00
Ryan Leavengood
c2a59f2305 Remove the null check as per Axel's advice: valid arguments within the range 
are never null.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27450 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 13:44:00 +00:00
Axel Dörfler
90e8094e1e * Added test application for the AttributeIterator implementation. Note that 
this test fails under BeOS, while it works just fine under Haiku.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27449 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 12:23:39 +00:00
Fredrik Modeen
ba65711eb2 Fixed CID 1033: fMouseDownBounds will never be null as we do a new BBitmap before we check for NULL 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27448 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 11:32:40 +00:00
Stefano Ceccherini
1e8da5fd15 fAppName was leaked (CID 6). Also moved the initialization of fText to the end of the function, so that we avoid a BString::Adopt() call 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27447 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 10:26:05 +00:00
Stefano Ceccherini
746cac055a fixed buffer overrun, CID 649 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27446 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 10:10:13 +00:00
Stefano Ceccherini
b5d458a508 First round of style changes: renamed all member variables from m_var_name to fVarName 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27445 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 09:55:02 +00:00
Axel Dörfler
fa23653d48 * Improved reported inode number to the be actual index. 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27444 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 09:53:58 +00:00
Stefano Ceccherini
866ece3115 build fix 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27443 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 09:34:47 +00:00
Stefano Ceccherini
1adaf58e1f gcc4 noticed GenericThread::GetName() was returning a pointer to a local variable. No code is using this function, so it's safe to strdup() it. This class needs a serious restyling, though, as it doesn't conform to our coding guidelines 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27442 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 09:33:59 +00:00
Axel Dörfler
c4b2fd5be3 * Reverted r27196 and solved it differently (in a more robust way): instead of 
guessing that the first attribute will be a name attribute, fCurrentSmallData
  now takes hidden attributes into account.
* I haven't tested this change, though, so if it messes things up again, please
  yell at me :-)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27441 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 09:25:17 +00:00
Stefano Ceccherini
2e2bff94a9 buttons could be used initialized if locking the looper failed (CID 1134) 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27440 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 08:09:13 +00:00
Stefano Ceccherini
fc16834e55 buffer is an array, so use delete[]. CID 130 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27439 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 07:34:37 +00:00
Fredrik Modeen
c1d9a877a4 Fixed CID 1031: removed check _fDevice for NULL as we do new BList in constructor also removed temp var count as _fDevice->CountItems() should return 0 if empty 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27438 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 07:07:00 +00:00
Ryan Leavengood
52a542adfc Fixed CID 1306: initialize size to 0. 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27437 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 06:43:07 +00:00
Ryan Leavengood
e65fb49a85 Apply Michael Pfeiffer's advice and move the delete outside the if. 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27436 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 06:34:39 +00:00
Ryan Leavengood
bf2c508181 Fixed CID 1289: if name cannot be strdup'ed, we should delete entry before 
returning B_NO_MEMORY;


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27435 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 06:30:07 +00:00
Ryan Leavengood
4239ee5d66 Fixed CID 1290 and 1291: the temp BString is initialized with a new BString and then immediately replaced. A later null check ensures it is OK to initialize it to NULL. 
Also fixed a GCC warning about comparison between signed and unsigned.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27434 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 06:21:34 +00:00
Ryan Leavengood
3d65935d2d Fixed CID 1294 and 1295: delete the entry_ref on the terminating conditions. 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27433 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 06:10:56 +00:00
Ryan Leavengood
5043f13cc7 Fixed CID 1297: the buffList array was never deleted. 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27432 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 05:29:27 +00:00
Ryan Leavengood
78cc6f918f Fixed CID 1298: In the case that sSelectedIcon is not valid, checkMark could be 
leaked. So I reorganized the if statement to remove this possibility.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27431 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 05:20:49 +00:00
Ryan Leavengood
1594b70bc1 Fixed CID 1301: we should probably have the null check of defaultPipe before it 
is first dereferenced...


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27430 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 04:44:55 +00:00
Ryan Leavengood
0f3a576f7e Fixed CID 1300: the pointer last is never modified in the loop, so there is no 
need for a null check. Or the null check needs to be moved to after last is
initialized. But if the user_memcpy of cookie succeeds, last should not be null
since it is just a copy of cookie. Probably.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27429 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 04:40:37 +00:00
Ryan Leavengood
d1363991a8 Fixed CID 1299: the char* name was used in a call to strtoul on line 1220 
before being NULL checked on line 1234. I moved the null check to be after name
is initialized and removed it from line 1234.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27428 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 04:28:09 +00:00
Ryan Leavengood
9b54ac7464 Fixing CID 1305: the null check of fPageFormatText on line 483 was redundant 
since fPageFormatText is accessed in both branches of the if before the null
check. If it was actually null there would be a crash well before line 483. In
addition this member is initialized in the constructor. I assume the null check
was added to provide symmetry with the null check of fJobSetupText below it.
But that latter null check is needed since fJobSetupText may not have been
created in the constructor.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27427 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-12 04:13:30 +00:00
Karsten Heimrich
dcddeb4c1c * Bug #264 appeared again after I removed the disabled programmatically resize during user resize. 
Obviously we ported the bug over from BeOS, during the FrameResized call the preferred size of
  the window was calculated based on the current size of the window, calculating the same size
  FrameResized reported. Thus resulting in trying to resize it to the same size ending in an loop.
  It seems they worked arround the oversight using the outline resize thing.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27426 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-11 23:09:45 +00:00
Karsten Heimrich
dc68795074 * automatic whitespace cleanup 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27425 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-11 22:52:44 +00:00
Jérôme Duval
53e8a878e6 isnan and isfinite are macros 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27424 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-11 22:45:17 +00:00
Jérôme Duval
645fa87a21 added lsearch and lfind 
remove unknown infnanf and strtcopy functions


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27423 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-11 22:27:55 +00:00
Jérôme Duval
eabd7df4a2 added insque and remque 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27422 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-11 22:23:21 +00:00
Jérôme Duval
9f1337c6f0 fixed ls to be ls and not dir (bug #2646) 
added dir


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27421 a95241bf-73f2-0310-859d-f6bbb57e9c96
 2008-09-11 22:14:55 +00:00