Commit Graph

62167 Commits

Author SHA1 Message Date
Murai Takashi
8e71287b6f BeDecorator: remove dead assignment
Pointed out by clang static analyzer.

Change-Id: Ib91123f70bc07666737bbfedbb794ff43ac39905
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3287
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-10-04 08:29:40 +00:00
Murai Takashi
93c530009c pairs: remove more dead nested assignment
Pointed out by clang static analyzer.

Change-Id: I21cd0a779a50f26d713ae1203024b2b0f2f4bd49
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3288
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-10-04 08:27:47 +00:00
Murai Takashi
aa2632939c intel_extreme: Fix dead store
Pointed out by clang static analyzer.

Change-Id: If75c625a9d568db1081ddc83f98a85d361ebf5e2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3286
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-10-04 08:26:55 +00:00
Jérôme Duval
513955e6c0 GraphicsCard.h: remove declarations for dprintf and set_dprintf_enabled
Change-Id: Ie8bbfcf2f23cf0ee36dc74e76062f21c99effc96
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3281
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-10-03 11:52:37 +00:00
Jérôme Duval
fa51454b25 userlandsfs: needs AppDefs.h for B_QUERY_UPDATE
Change-Id: If39a60089873b20dedadd05ee69628d14585fdbd
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3278
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-10-03 11:52:37 +00:00
Jérôme Duval
5e43ea2ed8 block_cache: use printf when not built in kernel mode
this is used by userlandfs

Change-Id: I2f7971be819c36fcab78eca2d18b45bb0b1a5fad
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3277
Reviewed-by: Rene Gollent <rene@gollent.com>
2020-10-03 11:52:37 +00:00
Jérôme Duval
1a58c4171d accelerants/common: useless include
Change-Id: Ice7aa5a01347d8052fea0de5bd2ee854d08b8b38
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3276
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-10-03 11:52:37 +00:00
Autocomitter
d0e006f556 Update translations from Pootle 2020-10-03 08:53:57 +00:00
Alexander von Gluck IV
14d8c772a1 configure: Break out cross-tools source path
* Stops the ackward "buildtools sources on first --build-cross-tools"

Change-Id: I683acf5ccc2a83b526a58aa54c7716d28d47b52d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3206
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Reviewed-by: John Scipione <jscipione@gmail.com>
2020-10-02 19:52:41 +00:00
Jérôme Duval
64331e96ca kernel/x86: extend CR4 flags
Change-Id: I4861f6cd61d0daeeb2403d07e703b83cd6a00666
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3280
Reviewed-by: Rene Gollent <rene@gollent.com>
2020-10-02 17:12:06 +00:00
Jérôme Duval
011fd524a1 kernel/x86: dump features 7 ecx
Change-Id: I4c166ceb64c3a472ee2a849beca6ee041ef3af89
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3279
Reviewed-by: Rene Gollent <rene@gollent.com>
2020-10-02 17:12:06 +00:00
Jérôme Duval
c0de5f6a5f KMessage: panic is valid for kernel and bootloader code
Change-Id: I4473160d809c490cc8862dfd42b41290238e22e3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3274
Reviewed-by: Rene Gollent <rene@gollent.com>
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
2020-10-02 14:09:26 +00:00
Niels Sascha Reedijk
d458e592eb HaikuBook: Apply layout customizations after default Doxygen stylesheet
Previously the 'book.css' file was applied as the sole stylesheet for the
Doxygen generated documentation. This stylesheet now applies it as a secondary
stylesheet to override Doxygen's defaults. The main advantage is that when
Doxygen adds new features, they will now be styled by default.

I did my best to clean up the book.css file, though it is not unlikely that
there still is a lot of duplicate CSS. For now though, the output looks mostly
the same, the code blocks no longer have an empty line between each of the lines
and the tooltip text - while not working - are no longer visible on the bottom
of the page.

Change-Id: Ia50915245ecd981843d0d8ec42e362b538187920
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3269
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-29 19:14:01 +00:00
Adrien Destugues
0d87f2555a app_server: missing null pointer check.
Should fix #16551.
2020-09-29 20:01:46 +02:00
Adrien Destugues
7ace34a6ba app_server: don't reset brightness when switching workspaces
Fixes #16538.
2020-09-28 20:51:10 +02:00
Murai Takashi
68a0df3e0e usb/uhci: Remove unneeded NULL check
Thanks to mmlr for pointing out element could not be NULL.

Change-Id: I89d85fdd2cc30efd54c81f6c50a5497208bab5d2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3259
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2020-09-27 14:19:50 +00:00
Murai Takashi
f30ba67705 cortex: Remove dead code
Pointed out by clang static analyzer.

Change-Id: Ic647109e5e7d2e304be6f8c542ea9bfca551c3a3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3271
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-27 11:33:59 +00:00
Murai Takashi
d7093b2437 pairs: Remove dead code
Pointed out by clang static analyzer.

Change-Id: I72fe5dc823f96b49446d1e5a1d9a71600a585053
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3272
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-27 11:33:24 +00:00
Murai Takashi
6023f2a6ce mail: Remove dead code
Pointed out by clang static analyzer.

Change-Id: I911c6e664ca043ee49f9343b034b0c6ed78b0178
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3270
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-27 11:02:20 +00:00
John Scipione
b76afa5bc0 BTextView: Draw string even if foundTab
Fixes #16544 (regression from hrev54549.)

Change-Id: Icca0b50f5432351b9c7ffcb82b1c8195a7ed286b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3267
Reviewed-by: humdinger <humdingerb@gmail.com>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2020-09-26 16:37:02 +00:00
Autocomitter
09c2ad7991 Update translations from Pootle 2020-09-26 08:48:31 +00:00
Humdinger
03e7ffef52 Installer: add missing linebreak in GUI string
It was either adding a separating space or go for a linebreak.
I opted for the line break.
2020-09-25 20:54:15 +02:00
Anarchos
edbeede442 typo and missing parameter
Change-Id: Ibb29c8621a981b489ce10d1f9d18df1d5ea3a079
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3266
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-25 12:39:16 +00:00
Adrien Destugues
64ab6cf0db FirstBootPrompt: even more fixes
The previous code tried to add a boolean to the quit requested message,
but that is not propagated from the app to the window QuitRequested, so
it didn't work. Instead, split the task between the app and the window'
QuitRequested functions.
2020-09-24 21:43:10 +02:00
Sylvain78
da30d8fafc Typo in documentation
Change-Id: I7c27b3a3b624a7291d00c321d48733368c4e2b4a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3265
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-23 11:12:13 +00:00
Pascal Abresch
b8bd451e9f AboutSystem: Respect system colors
Change-Id: I2fac8c2a7ab9033cc730db373710a856a8827eb8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3262
Reviewed-by: John Scipione <jscipione@gmail.com>
2020-09-23 06:30:19 +00:00
Pascal Abresch
4b1f514b08 Teammonitor: Respect system colors
Change-Id: I5cc69376ade425c46bc76f8179f93bb74428da68
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3261
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-23 06:30:19 +00:00
Adrien Destugues
0b07cea059 FirstBootPrompt: Another fix for #16525
If we quit the app before handling the "reboot requested" message, the
system doesn't reboot.
2020-09-22 17:37:59 +02:00
Sylvain78
56ce1249b2 Adding a keyboard layout for the Fizzbook Zoostorm NL2
Change-Id: I534055ab9f37c8489900970b4662e52c1ec6a7b7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3231
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-22 06:36:52 +00:00
Andrew Lindesay
05880d133e HaikuDepot: Custom List Removal (Depots)
Remove use of custom list class where it is not
really required in the area of Depots.  Also
convert the use of Depots to be wrapped in
BReference to match other model objects. At the
same time some data-loading logic has been
simplified.

Relates To #15534

Change-Id: Ie6fcc35f258a0c69c44990e4b09f6c32ec79945d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3225
Reviewed-by: Rene Gollent <rene@gollent.com>
2020-09-21 20:49:37 +00:00
Alexander G. M. Smith
a22fa0c977 package kit: Add pre-uninstall scripts feature.
Just like post-install scripts which run shortly after a package is
installed, pre-uninstall scripts are run just before a package is
removed.  Implements enhancement #13427

* Fix script exit code handling vs script launch errors.
* Bump package and repo file version numbers due to new attribute,
  unfortunately makes new .hpkg files not backwards compatible.
* Add pre-uninstall functionality, mostly cloning the post-install
  except in a few places.
* Discover that _RunQueuedScripts() is never called, a future TODO:?
* Update package documentation for pre-uninstall scripts, and use of
  the boot/post-install directory.

Change-Id: I45596255ce74bc102f6e5b606cbf83e4e4347a17
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1504
Reviewed-by: Alexander G. M. Smith <agmsmith@ncf.ca>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-21 10:47:57 +00:00
Adrien Destugues
e6f60cad2a FirstBootPrompt: some NULL pointer checks
Should fix #16525
2020-09-20 18:52:45 +02:00
JackBurton79
e2ee966fc0 Terminal: fix cursor blinking
When the window was deactivated once, cursor wouldn't blink anymore on next activation. Fixes #16388

Change-Id: Id7042e078df2a5c5b397763cf544626efc5e589a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3258
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-20 13:33:02 +00:00
Adrien Destugues
8b2b301059 app_server: save/restore screen brightness settings
The brightness is saved in the screen configurations of the first
workspace. For now, all screens get the same brightness (I can't get
screen IDs to work today). Since we only support setting the brightness
for laptop displays for now, this shouldn't matter. It can be fixed when
app_server gets actual multiple display support.

Fixes #14254

Change-Id: Ib33aa65a73407a65bd469d0efa8542210fec02d4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/362
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-20 13:30:29 +00:00
Adrien Destugues
f6d0ea5cad MediaPlayer: improve handling of cover art.
Fixes #16531.
2020-09-20 14:44:42 +02:00
Adrien Destugues
5dbf9531ea ffmpeg: remove some asserts in aspect ratio computations
Use a default or undefined aspect ratio when ffmpeg won't tell us the
video size, rather than crashing the whole app.
2020-09-20 10:17:49 +02:00
Alexander von Gluck IV
d8c41a8ab0 partitioning/intel: Allow creation of EFI partitions on MBR
* Essentially, EFI system partitions are just FAT32 formatted.
* We really haven't tried EFI booting on MBR (normal choice is GPT)
* I see no reason to *not* allow folks to create these.
* Align partition name to GPT's naming

Change-Id: I4cd52d542ea618f1ffe52927e15237fc10bb386c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3224
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-19 19:22:36 +00:00
Adrien Destugues
135dff4381 Prevent turning the backlight completely of by setting the brightness.
Change-Id: Idb8658f97045f6c0491223bbe8bf52914ca98402
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2934
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-19 19:14:10 +00:00
Adrien Destugues
ab1a16dea1 btrfs: build fix 2020-09-19 21:13:28 +02:00
brjhaiku
1519703abf btrfs: implement btrfs_write_fs_info
Change-Id: I507fc4154f8a11235b6b6f8812c3b38924f533f7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1560
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-19 15:47:20 +00:00
brjhaiku
ba6665a3dd btrfs: add stub write function
Only does the parameter error checking.

Change-Id: Idee4a8e8e183d45c4a14236c32ff40e52ccb2555
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1534
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-19 15:47:20 +00:00
Autocomitter
5986ba8cb1 Update translations from Pootle 2020-09-19 09:16:39 +00:00
Adrien Destugues
a99221e61a build fix. 2020-09-19 11:07:06 +02:00
X512
6fd2274306 app_server pointer/ownership cleanup: trivial changes
Split apart the work done in https://review.haiku-os.org/c/haiku/+/2695
in smaller, easier to review parts.

This commit contains self-contained/local changes that are unlikely to
cause problems.

Change-Id: Idae27ca440791423e3d090bcfe33f4cc83bbea3d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3174
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-19 07:13:19 +00:00
Andrew Lindesay
4af3fbf906 HaikuDepot: Lists & Prominences
Use BStringList instead of bespoke List class for
lists of strings.

Also fix the prominences so that the sort
ordering in the featured packages uses the sorting
algorithm properly.

Relates To #15534

Change-Id: I56e67931aa08e6bfee6d2be21a459152216790e2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3232
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-18 11:59:16 +00:00
CodeforEvolution
5c32512076 GNU Compatibility: Implement qsort_r
This is a version of the qsort function allowing you to pass a "cookie" to the function.

Change-Id: I60c645213b9c9590e38b112634fcac1d7969b6d9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2449
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-18 06:25:20 +00:00
Adrien Destugues
1c889d23fe ffmpeg/MediaPlayer: fix seeking in audio with cover art
MediaPlayer is basing its time on both the audio and video frames. This
doesn't go so well when there is a single video frame, resulting in the
whole file being one single "timepoint".

Avoid this problem by having the video decoder set the frame time to
"infinite" when the video stream is finished, which allows for the audio
timings to be used in this case.

Also improve the framerate handling of ffmpeg further, to avoid
MediaPlayer trying to frameskip at 90000fps (it would give up
frameskipping after a few frames and eventually notice that the next
frame was the end of stream, but still, not very clean). Now we report
an FPS of 0 instead, which should make it clear to applications what to
expect from single-frame files.

It seems the cover art is now hidden by a black screen, I'm not sure
why. But I'll leave debugging this for another day.

Fixes #13622.

Change-Id: Ie1dd1358cbb41c11649103dfce52a0e1317b26f8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2562
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-18 06:24:46 +00:00
sushilhub
ab05d36868 src/apps: style fixes
* add break statement to the last clause of switch/cases
* fix some other minor issues

Change-Id: I9ac3dac0cda0b14043b975938caea88b79bb749f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1299
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-18 06:23:19 +00:00
Jérôme Duval
dfed08e0de intel_pstates: enable HWP when available
* don't reset the APERF and MPERF MSRs, they could be in use otherwise.
* use EPP or EPB to select power-save or performance mode
* HWP_REQUEST_PACKAGE disabled (as other OSes seem to do).

Change-Id: I26eb0b05c402b131a4ab174ad6f9ddf8e9367709
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3222
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2020-09-17 15:46:58 +00:00
Jérôme Duval
80ad523bc2 intel_pstates: enable CPUs having HWP
also update model list from Linux intel_pstate_cpu_ids.

Change-Id: I20926dc8553fbf1ade8afcccaaedfc2846787bb3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3221
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-09-17 15:46:19 +00:00