Stephan Aßmus
c6077ae7ec
Cleanup: No need to check the BMessenger status twice. No need to
...
keep the BMessageRunner message around.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38234 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 13:50:50 +00:00
Axel Dörfler
f072d0a87a
* The "route" command now uses BNetworkAddress instead of its home brewn
...
solution, too.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38233 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 13:04:50 +00:00
Axel Dörfler
c141a31f83
* Fixed CID 1447 which was an actual bug which completely voided the whole
...
discard mechanism eventually causing the conflicts between the file cache
and the block cache it intended to fix.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38232 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 12:23:38 +00:00
Axel Dörfler
7ac6de66a4
* Removed a few superfluous "else" keywords.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38231 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 11:58:27 +00:00
Adrien Destugues
24fcc1eecb
Fix parsing of numbers in svg files : the code used obsolete atod instead of strtod and led to numbers in the form 2.5e-4 to make the parsing fail as 'e' was interpreted as the end of the number.
...
Fixes #5728 .
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38230 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 11:50:49 +00:00
Axel Dörfler
3e86abbd71
* Added an extra check as requested by CID 1567, but also added a comment why
...
this (and other checks) should not be necessary in the first place.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38229 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 11:39:39 +00:00
Axel Dörfler
d74f5f5bb5
* Cleaned up the code which also closes CID 176 which was not a bug, though.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38228 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 11:26:23 +00:00
Axel Dörfler
adc92cdef7
* Fixed CID 1750: the team args could be leaked in exec_team() on error.
...
* Also fixed a leak of the same object in team_create_thread_start() I spotted
while looking into it.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38227 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 11:07:20 +00:00
Stephan Aßmus
132cbf8cf7
Updated indentation and style.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38226 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 10:59:56 +00:00
Stephan Aßmus
81db321da2
Updated header indentation, no functional change.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38225 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 10:38:30 +00:00
Stephan Aßmus
52ede95cd7
* Removed outdated USE_MULTI_LOCKER build option
...
* Don't acquire the read-lock in WindowForClientLooperPort,
since MultiLocker does not support nested read-locks.
Use an assert instead, however the method does not appear
to be used anywhere at the moment.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38224 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 10:10:27 +00:00
Adrien Destugues
e20a602919
* Use Shift instead of Option as modifier to load workspace settings, as it conflicts with option+N used to open a new
...
terminal
* Also ensure that the terminal end up on the current workspace if there is a problem with the settings or the key isn't
pressed.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38223 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 09:57:17 +00:00
Adrien Destugues
b234b3fc4e
The color attributes were lost in scrollback buffer since the 256-color change.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38222 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 08:48:45 +00:00
Rene Gollent
420cd21c94
Move the password structs outside of the inner block as well. Fixes #6464 .
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 03:43:02 +00:00
Clemens Zeidler
de8a0836ac
Fix coding style.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38219 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 23:48:47 +00:00
Clemens Zeidler
bba6f48d64
Add Notify* prefix to DesktopObservable hooks.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38218 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 23:44:30 +00:00
Clemens Zeidler
c0eff34541
Remove unused PortLinkRef again.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38217 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 23:27:22 +00:00
Clemens Zeidler
ee9246d5f5
Remove unused communication port, pointed out by Axel.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38216 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 23:23:02 +00:00
Clemens Zeidler
26d8064ea8
Lock WindowForClientLooperPort method and add comment that the window lock has to be held if accessing the a WindowList.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38215 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 22:56:19 +00:00
Clemens Zeidler
94892dc091
Make arguments const if appropriated. Style issues and port_id error check. Thanks Stippi.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38214 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 22:54:00 +00:00
Oliver Tappe
e0ef64750f
* fix #6373 by switching the BD... macros to take the address of corresponding
...
constants, which had to be defined in several places in order to be available
in the kernel addons, network protocols and the server/kit.
* enable -Werror for all servers
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38213 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 21:46:32 +00:00
Clemens Zeidler
7640bbb6cd
Fix coding style.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38212 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 21:35:16 +00:00
Clemens Zeidler
488c90defe
Fix style issues, thanks Axel.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38211 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 21:15:13 +00:00
Stefano Ceccherini
42f0a4a120
Fixed build after Layout api change (hopefully the fix is correct)
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38210 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 20:09:25 +00:00
Axel Dörfler
9189743037
* Style cleanup.
...
* Made an enum out of the mailbox type.
* Rearranged some code to get rid of CID 1328 which was not a bug, though.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38209 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 19:07:16 +00:00
Alex Wilson
352fb78f1f
Fix Gcc4 build error from my previous commit.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38208 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 19:04:45 +00:00
Alex Wilson
1d6c7b6cb6
Big change deriving BLayout from BLayoutItem, and allowing viewless BLayouts.
...
a few highlights:
* BLayout now derives publicly from BLayoutItem
* Added BAbstractLayout class, which our layouts now derive from
* updated layout builders to avoid creating views when they don't need to
* updated layout classes
* updated AboutSystem to fix a little regression
* more details on #6407
* please tell me about any regressions, I've tried to find them all, but some
may have slipped by.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38207 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 18:43:41 +00:00
Axel Dörfler
0f274fd5b2
* Calmed down CID 1976; the problematic situation should not be able to occur,
...
but I've changed it anyway to make the code clearer.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38206 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 18:22:17 +00:00
Oliver Tappe
77d9a1e9bc
* of course, gcc4 had more issues with the Joystick preflet
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38205 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 18:08:38 +00:00
Oliver Tappe
f3e4c16e4c
* fix warning to get really all preflets compilable
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38204 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 18:03:12 +00:00
Oliver Tappe
8f62243f37
* fix warnings in Keymap preflet about hidden virtual by renaming SetFont()
...
to SetBaseFont() (and fFont to fBaseFont)
* enabled -Werror for all preflets
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38203 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 17:37:15 +00:00
Alex Wilson
1fd91b7ffd
Small compilation fixes for coming layout changes... (really!!)
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38202 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 17:11:11 +00:00
Oliver Tappe
e0ae658ae2
* style adjustments - no functional change
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38201 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 16:53:25 +00:00
Oliver Tappe
1195f511e5
* style adjustments - no functional change
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38200 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 16:47:14 +00:00
Oliver Tappe
37cebf6883
* fixed all warnings in FileTypes preflet and enabled -Werror
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38199 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 16:41:28 +00:00
Alex Wilson
1f1606e745
Update DataTranslations to use BGroupLayout and BGridLayout instead of BALMLayout. This works around a regression with some changes I'll be committing soon, although I'd still like to find the source of it... Also do some style cleanup and remove fTranslatorNameView var which was never actually displayed.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38198 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 16:39:02 +00:00
Oliver Tappe
54123ac0e8
* style adjustments - no functional change
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38197 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 16:25:45 +00:00
Axel Dörfler
87de0cb4e1
* Fixed CID 1199-1202: only call the cache listener in case the open succeeded
...
(this might also have derefenced a potentially freed vnode).
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38196 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 16:15:45 +00:00
Axel Dörfler
297e601d68
* Fixed CID 1293: a vnode reference, and the cookie could be leaked.
...
* Minor cleanup.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38195 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 16:08:50 +00:00
Axel Dörfler
6dcca7f6ab
* Fixed CID 1472: "next" could be NULL and dereferenced.
...
* Simplified code a bit.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38194 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 15:39:26 +00:00
Axel Dörfler
ed64d4e0f5
* Fixed CID 1511: protocol could be NULL.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38193 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 15:34:24 +00:00
Adrien Destugues
d18fc3994c
Patch by rossi, but I ended u rewriting half of it :
...
* Save terminal windows positions
* Also save their size and workspace, but these aren't used (size is overriden by the menu setting and workspace is annoying)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38192 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 15:29:08 +00:00
Axel Dörfler
579e19f5b9
* Fixed CID 1703: buffer could be leaked. Thanks to Stefano for the note.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38191 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 15:21:39 +00:00
Oliver Tappe
9602d07543
CID-1512: ensure that label is never dereferenced while being NULL
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38190 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 15:02:37 +00:00
Adrien Destugues
26411b5359
* Remove legacy BeOS code
...
* Ensure the argument list passed to execve is NULL-terminated
* Also declare it earlier to make sure gcc4 doesn't erase it from memory when getting out of the if block.
This *should* fix gcc4 Terminal, and *does not* break it under gcc2.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38189 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 15:02:10 +00:00
Oliver Tappe
2655efc395
Fixes to Notifications preflet
...
* CID-1501: protect against dynamic_cast potentially returning NULL
* additional style fixes
* fixed all warnings and enabled -Werror
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38188 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 14:56:51 +00:00
Oliver Tappe
6137279338
CID-639: Protect against FindItem() potentially returning NULL
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38187 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 14:42:14 +00:00
Oliver Tappe
529fd9af5d
Fixed all warnings in Shortcuts preflet and enabled -Werror for it
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38186 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 14:35:28 +00:00
Oliver Tappe
ef9095fbe2
* CID-1742: delete SortArray when we are done using it
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38185 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 14:07:33 +00:00
Oliver Tappe
6effcf12f2
* CID-1741: remove useless piece of code that did nothing but leak the label
...
* don't check against NULL before deleting fLabel
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38184 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 13:56:23 +00:00