Bug introduced in 810f0a42e5.
The uint8 cast were also acting as masks for each of the pixel
components, moving them out of the multiplications made things go wrong.
Use rgb_color instead of messing with bitshifts and masks for better
readbility (the colors are out of order, but the processing is the same
on each color so the end result is valid).
... shown when website has no favicon.
This avoids the URL moving by 16 pixels as the favicon is downloaded and
rendered.
Fixes#8888.
The icon is from Zumi's BToolbar set ("insert link") with some
tweakings. Something less colorful may be better.
The GroupView sometimes has visible pixels when the text size is smaller
than the favicon height. Draw those with the same color as the textview
background.
As WebKit is asynchronous to the window, when launching a request in a
BWebView, IsBlankTab() will keep returning true until it gets the
BMessage and updates its state.
When opening bookmarks or refs, we would send them too fast, not detect
this, and reuse the same tab for several items. Make sure the blank tab
is only used once when looping over the refs, and force opening all
remaining refs in new tabs of the same window.
Fixes#6625.
Also optimizes the ref loading by not looking up the window for each
ref. Pick one window, then use it for all the bookmarks in the loop.
- The search query position is signified by %s in the search string,
- Automatically migrate the old default search string to the new one.
Patch from #9926 with some rework from me.
* Shortcut issue - closing EULA window with Alt-W continues to main
application window instead of sticking windowless application in
the Deskbar tasks list. The idea is closing only the one window
of two;
* Fixes#9982.
- GCI 2013
The symbol is needed for global objects. Usually, GCC also requires
this, but for some reason, the linking error only occurs when using
Clang.
Signed-off-by: Jérôme Duval <jerome.duval@gmail.com>
Interestingly, [0] should be as invalid in C++ as [] in this case, yet
Clang refuses [], but accepts [0].
Signed-off-by: Jérôme Duval <jerome.duval@gmail.com>
This way, it is a compile time constant and Clang does no longer
complain about dynamic arrays of non-POD types.
Signed-off-by: Jérôme Duval <jerome.duval@gmail.com>
This dummy was intended for boot code, however, atomic_add seems to be
already properly defined in boot code.
Signed-off-by: Jérôme Duval <jerome.duval@gmail.com>
Older versions will not work anymore because of the API changes in
network kit (removal of nonstandard B_PROT_* status codes). x86 and
x86_64 packages have to be updated again.
Use standard error codes instead.
This allows using error code returned by the underlying functions
directly, and makes it possible to use strerror for debugging. So, we
can also remove StatusString() from the various *Request classes.
* The package info area toggles a package's rating to a "Rate package..."
button when the mouse hovers it.
* Clicking that button opens a window where one can enter a rating.
* Totally not working yet, but I want this in VCS.
This uses a variable CLANG that should be set to the Clang version. For
now, this has to be done manually (e.g. when invoking jam using jam
-sCLANG=34), but later, this will be auto-detected.
Work towards bug #10396
* Displays standard CPUID, and shows what the
internal CPUID used by OS.h *should* be.
* Should help out in identifying new CPU's
as all end users have to do is run sysinfo
to get the CPU info + value for OS.h
Nested functions are a (again, broken) GNU extension which is not
supported by Clang. It has been replaced by a bunch of gotos and a
variable that works as a return address.
Variable length arrays of non-PODs are not part of the C++ standard, but
a GNU extension that never worked correctly. Instead, BStackOrHeap array
is used now, which makes sure that it's not too big for the stack, calls
all constructors and is valid C++.
Use the EPFL (Easily Parsed File Listing) format. This is one of the
formats that WebKit allows for directory listings, and it's easily
parsed and generated.
Alexander von Gluck IV