Commit Graph

48533 Commits

Author SHA1 Message Date
Ingo Weinhold
05826ec74b ext2_get_file_map(): Fix broken termination condition 2013-11-11 22:27:54 +01:00
Ingo Weinhold
fd91d2cbe1 ext2: ExtentStream::FindBlock(): Restructure/fix
* The binary search was somewhat broken.
* Restructure a bit so that only the binary/linear search itself is
  handled separately. The handling afterwards is common again.
* Fix sparse block handling:
  - There can be sparse blocks before the first extend.
  - Set the return parameter _count in this case as well.
  - Set the return parameter block to 0 instead of 0xffffffff. That's
    what ext2_get_file_map() expects.

Fixes an infinite loop in ext2_get_file_map() when sparse blocks are
involved, due to previously returning a wrong block and a 0 count.
Ticket #9274 may be related.
2013-11-11 22:27:54 +01:00
Ingo Weinhold
24d0e21f51 do_iterative_fd_io_iterate(): Support sparse files
* Check whether the vectors we get are sparse file vectors and satisfy
  them immediately instead of creating a subrequest. Untested, since the
  API isn't used by ext2 as it should be.
* Add error == B_OK to the condition of the outer loop.
2013-11-11 22:27:53 +01:00
Ingo Weinhold
9f7e78ee79 IORequest::Init(): Assert offset >= 0
Just to make sure we catch sparse file vectors that shouldn't be passed
here.
2013-11-11 22:27:53 +01:00
Ingo Weinhold
c63b3de665 IORequest: Add ClearData() 2013-11-11 22:27:53 +01:00
Ingo Weinhold
426fe7db1d IORequest::_CopyData(): Small optimization
If we're running in the context of the user team the I/O buffer belongs
to, we can use _CopySimple() as well.
2013-11-11 22:27:53 +01:00
Ingo Weinhold
07f6506eb6 VFS: Fix broken zero_pages()
Besides that it failed to actually iterate through the vectors, it
shouldn't try to clear physical memory in the first place. The iovecs
refer to virtual address ranges. Rename it to zero_iovecs() to avoid
confusion.
2013-11-11 22:27:52 +01:00
Ingo Weinhold
e5f6591382 VM: vm_memset_physical(): Correct length parameter type 2013-11-11 22:27:52 +01:00
Jérôme Duval
81fd469dcf iprowifi4965: fixed firmware filename for iwn6000g2afw.
see #10197
2013-11-11 22:09:46 +01:00
Jérôme Duval
4377c66f87 acpi_lid and acpi_ac: moved init to the driver hooks.
* notification handlers are now called correctly.
2013-11-11 19:38:38 +01:00
Jérôme Duval
847ab5a734 acpi: EcGpeHandler() should return ACPI_REENABLE_GPE.
* this clears the GPE if level triggered and possibly enables the GPE.
See AcpiEvFinishGpe() and AcpiEvGpeDispatch().
2013-11-11 18:59:38 +01:00
Jérôme Duval
e94bffa072 vm: allocate wrappers on the heap with small stack array fallback
see comments on #10169. Thanks Ingo for reviewing!
2013-11-11 18:34:14 +01:00
Ingo Weinhold
c93efdb37f Keymap preflet: Sort the lists 2013-11-11 01:07:58 +01:00
Rene Gollent
1c56f25236 HaikuDepot: Fix #10189.
- Move InstallPackageAction's _FindPackageByName to PackageAction, so
UninstallPackageAction can make use of it as well.

- Rename DownloadProgressListener to PackageProgressListener and add
hooks for the package manager's DownloadProgressComplete,
StartApplyingChanges and ApplyingChangesDone events.

- InstallPackageAction implements DownloadProgressComplete in order to
gather all dependent packages that were downloaded as part of the
installation request. These are then set to active, or reset to available
depending on the outcome. Fixes the problem reported in #10189.

- UninstallPackageAction now implements the aforementioned ApplyingChanges
hooks in order to track all packages to be uninstalled as part of the
transaction. Upon completion, they are all accordingly marked as Available.
Previously the state wasn't correctly reset for any dependent packages that
were also removed as a consequence of the requested package's removal.
2013-11-10 18:44:40 -05:00
Murai Takashi
b781fcec00 GridLayout.cpp: use delete[] instead of delete. Fixes #9875.
Signed-off-by: Matt Madia <mattmadia@gmail.com>
2013-11-10 18:37:33 -05:00
Murai Takashi
3b49d99436 Use delete[] instead of delete. Fixes #9985.
Signed-off-by: Matt Madia <mattmadia@gmail.com>
2013-11-10 18:35:43 -05:00
Murai Takashi
9e0f440c1c Fix mismatching allocation and deallocation
Fixes #9901.

Signed-off-by: Matt Madia <mattmadia@gmail.com>
2013-11-10 18:33:35 -05:00
Murai Takashi
5750cec747 Fix memory leak for threeDaysAgoMenu
Fixes #9938.

Signed-off-by: Matt Madia <mattmadia@gmail.com>
2013-11-10 18:30:30 -05:00
Matt Madia
ade6fe2e93 Adjust array length.
As per Axel: The "+1" is not needed; B_FILE_NAME_LENGTH already includes the
terminating null byte.
2013-11-10 18:26:32 -05:00
Murai Takashi
c801b51ce8 Fix size argument is greater than the length of the destination buffer
Signed-off-by: Matt Madia <mattmadia@gmail.com>
2013-11-10 18:25:58 -05:00
Murai Takashi
c347a4d4d4 Fix called C++ object pointer is null
Signed-off-by: Jérôme Duval <jerome.duval@gmail.com>
2013-11-10 23:44:12 +01:00
Olivier Coursière
be6d2f97cd libroot: Accept NULL for the resolved_name argument of realpath()
as specified in IEEE Std 1003.1, 2013 Edition, see
http://pubs.opengroup.org/onlinepubs/9699919799/functions/realpath.html

In this case, the returned buffer is allocated with realpath() and can be
deallocated by the caller with free().
The behavior was only "implementation defined" in previous revisions like
IEEE Std 1003.1, 2004 Edition, see
http://pubs.opengroup.org/onlinepubs/000095399/functions/realpath.html

Signed-off-by: Jérôme Duval <jerome.duval@gmail.com>
2013-11-10 23:26:18 +01:00
Matt Madia
1bb144a926 Automatic whitespace cleanup. No functional change. 2013-11-10 17:15:34 -05:00
Humdinger
3c527b719f /boot/home/Desktop/Untitled 2013-11-10 19:15:29 +01:00
Przemysław Buczkowski
dfbb97132f Notifications: fix issue with launch folder. #10185
* App tried to create symlink in folder ~/config/boot/launch,
what throw an error, because this folder is read-only now.
    * Now it creates such in ~/config/settings/boot/launch.

Signed-off-by: Matt Madia <mattmadia@gmail.com>
2013-11-10 12:31:30 -05:00
Matt Madia
b1f0ca873f Whitespace cleanup: two blank lines between functions. 2013-11-10 12:05:45 -05:00
Przemysław Buczkowski
5bb799c2d3 NetworkStatus: show authentication mode in WiFi list. #9666
* now WirelessNetworkMenuItem appends authentication mode to its label

Signed-off-by: Matt Madia <mattmadia@gmail.com>
2013-11-10 11:57:09 -05:00
Stefano Ceccherini
f05b8e3873 Check the given path for ".." 2013-11-10 17:30:02 +01:00
Stefano Ceccherini
5ae9ef055c Check if device exists before creating ethernet interface.
Fix ticket #10183.
2013-11-10 17:30:01 +01:00
Ingo Weinhold
8e416d27ff Add a simple RAM disk driver
* It uses physical pages directly, not wasting kernel address space.
* The user interface is somewhat crude, it uses writes to a control
  device (output to serial debug/syslog), e.g.
    echo register 4g > /dev/disk/virtual/ram/control
  to register a 4 GB RAM disk. It is published under
  /dev/disk/virtual/ram/<index>/raw and can be formatted with DriveSetup
  like any other disk. Unregistering is broken ATM.
* It's not on the image by default, but can be added via
    AddNewDriversToHaikuImage disk virtual : ram_disk ;
* I found it quite useful when working on large HaikuPorts ports.
  E.g. mounting a RAM disk at the port's work directory shaves a lot of
  time off disk heavy operations. Obviously one shouldn't let changes
  lie around on it without back up.
2013-11-10 15:43:43 +01:00
Ingo Weinhold
9778589fc7 Set the Haiku image's system dir to non-packaged
Set HAIKU_CONTAINER_SYSTEM_DIR_TOKENS for the Haiku image to "system
non-packaged". All the rules using the variable would put stuff in
directories that will be read-only in the end (and aren't used anymore).
This way they can be used in UserBuildConfig.
2013-11-10 15:43:43 +01:00
Ingo Weinhold
18640f25d9 vfs: dir_vnode_to_path(): Fix bug with chroot on mount
Simplify the code, which also fixes the bug that the I/O context's root
was ignored when it was a mount point, thus resulting in globally rooted
paths in this case.
2013-11-10 15:43:43 +01:00
Ingo Weinhold
faf4ddb291 packagefs: PackageLinkSymlink: Fix crash on custom mount 2013-11-10 15:43:43 +01:00
Stephan Aßmus
baeed3f04e HaikuDepot: Get rid of dummy resources. 2013-11-10 11:03:13 +01:00
Stephan Aßmus
c05743fbc8 HaikuDepot: Give focus to the search terms after launch. 2013-11-10 10:59:32 +01:00
Stephan Aßmus
59062d32b7 HaikuDepot: Morestable layout in title ar
* Try to obtain a more stable layout in the title
   area by forcing unlimited width and using weights.
2013-11-10 10:46:25 +01:00
Axel Dörfler
efc3172fba ahci: Dump some TRIM device specifics.
* Maximum LBA range blocks per trim are now read, but not yet taken into
  account.
* Minor cleanup.
2013-11-09 23:05:59 +01:00
Humdinger
61571fa66a Added icons for HaikuDepot and HPKG archives.
Anyone feel free to come umoroe sphisticated ones. :)
2013-11-09 18:12:01 +01:00
Jérôme Duval
c5e233d388 usb: hub port reset is also done when the port status reset bit is zero.
* encountered on QEmu 1.6.50 with nec-usb-xhci and usb-storage devices.
2013-11-09 14:34:37 +01:00
Jérôme Duval
f559e51835 CID 991592 Uninitialized scalar variable 2013-11-09 13:55:57 +01:00
Jérôme Duval
7f0b39a791 CID 991479 Out-of-bounds access 2013-11-09 13:40:07 +01:00
Jérôme Duval
a0f124211a scsi: define SCSI_DEVICE_MAX_LUN_COUNT to set a custom max lun count.
* virtio_scsi can have 16384 luns, though we cap at 256 as our scsi_ccb
only uses uchar as a type for target_lun and target_id members.
* minor code cleanup in scsi_scan_bus().
2013-11-09 13:09:20 +01:00
Jérôme Duval
1ab38414b1 CID 1108455 Structurally dead code 2013-11-09 13:09:16 +01:00
Jérôme Duval
21f7dc3d40 scsi: checks for B_OK instead of SCSI_REQ_CMP in scsi_scan_bus()
* scsi_scan_lun() actually returns a status_t
2013-11-09 13:09:16 +01:00
Jérôme Duval
ecadc4c696 CID 1108428 Uninitialized scalar field 2013-11-09 13:09:06 +01:00
Jérôme Duval
426c95e5b0 CID 1108333, 1108192, 1108443
* 1108333 Out-of-bounds access
* 1108192 Operands don't affect result
* 1108443 Uninitialized pointer field
2013-11-09 13:08:57 +01:00
Jérôme Duval
1149fa6ece CID 1108447 Uninitialized scalar field 2013-11-09 13:08:48 +01:00
autonielx
b7f865a04d Update translations from Pootle 2013-11-09 06:14:35 +01:00
John Scipione
0096a29e9c Add BMenuField class documentation 2013-11-08 19:29:13 -05:00
John Scipione
d7d2ff5bde Minor updates to the BMenu and BMenuBar classes.
Remove the reimplemented hook methods groups because some
hook methods are there, some are not, unfortunately doxygen can’t
tell if a hook method just calls the default or does something else and
we tend to include all the hook methods even if we don’t actually make
any functional changes to them making the docs a bit more verbose
than they otherwise would be.
2013-11-08 19:29:13 -05:00