The hash table member still uses the element array memeber to clear
itself on destruction. We must therefore ensure that the element array
isn't destroyed before the hash table. Since the destruction order of
memebers is the reverse order of their declaration, reordering them
is enough.
The BShelf sets itself as a handler on the containing view on creation
but didn't unset itself on destruction. When the containing view was
later destroyed it would unset the shelf which triggered a
use-after-free if you deleted the BShelf beforehand.
Since the ownership of a BShelf isn't explicitly documented I took the
shelf in DeskWindow of Tracker as a reference, which does delete it
explicitly.
The inner loop to skip the function declaration stops at the
terminating null but didn't break out of the loop in that case, causing
the outer loop increment to skip the terminator and read beyond the
string end.
Well formatted symbols do not trigger this, but there sometimes are
false positives that would cause it to happen. It was seen in Debugger
that reuses this code.
* After start, the first item will now be selected.
* The InterfaceAddressView will no longer restrict its width, so
that the window doesn't have to be resized anymore when switching
to it.
* This implements ticket #11923.
* Ie. an add-on "Super duper service" in ~/config will override
one with the same name in /system (and non-packaged in packaged,
etc.).
* Fixed size of the scroller to ignore the content size vertically.
* So that you know how much already was, and still has to be downloaded.
* Automatic whitespace cleanup.
* The link in FetchFileJob.h did not fetch the correct header under
Haiku anymore (since the addition of the private headers to the
image).
* kBaudrates is an int not a char
* Just look at first kBaudrates member to figure out array size.
* Drop a few *extremely* uncommon speeds that you'll never see to
shorten the list.
Changing this many lines of code to add a single boolean preference
is absolutely insane. We need a new preference-tracking system, and
one that can be reused in other applications, too.
Fixes#9200.
This was a regression from hrev39870 where a private Referenceable class
was replaced with BReferenceable. Referenceable::RemoveReference()
returned a boolean to indicate whether the last reference was released
while BReferenceable::ReleaseReference() returns the previous reference
count.
A file system would therefore be deleted when any but the last reference
to it would be released (when multiple volumes of that file system were
mounted and one of them was unmounted) and leaked otherwise (when only
one volume of that file system was mounted and then unmounted).
Fixes#11718.
