Previously, there were two instances of the actual variables, named in
ControlLook.cpp and Utilities.cpp. This caused clashes on gcc4 builds, leading
to various crashes during initialization. Instead we now declare them as
static constants in the header itself as is done for various other interface
color constants elsewhere. Fixes ticket #8358.
* This value is card internal framebuffer offset
* 0 is the proper value, however it was causing issues for me
* The mode setting issues I saw before are now gone, and this
seems to make mode setting more stable now.
* This was a *big* oops on my part.
* We were missing initial setup call for
Kaleidoscope and DP Bridge encoders.
* If you were having radeon HD mode setting
issues, try this change.
* Potential fix for #5722, #7397, #8059, #8151, #8282,
#8289, #8310, #8322, #8331
* Begin storing the lcd flags in lvds info call as the
encoder needs them.
* Fill out laptop / lvds todo in encoder code.
* Stub out dvo encoder calls, not sure use cases for dvo.
* Copied the essential parts from the Font preflet into the Appearance
preflet folder.
* Adopted these files to better direct where BMessage arrive and why.
The Font preflet just forwarded them from the BWindow handler,
which was quite messy.
* Embedded the Font preferences as another tab. The first one actually,
with the Decor settings also moved in front of the Anti-Aliasing tab.
* Refactored the Defaults and Revert button updates in the window code.
* AInclude all active settings tabs in the Defaults and Revert handling
for consistency. But eventually, the buttons should only affect the
currently visible page.
* Cleaned up header (why declare some methods protected?!)
* Refactoring by applying basic "write only once" rule
* DecorInfoUtility is now cached as member
* This also fixes multiple instances of it being leaked.
* Return code of SetDecorator() is now checked, so it should be hard
to go out of sync with actually visible Decorator.
* fSavedDecor and fCurrentDecor were pointers to the memory of
temporary BStrings, this never worked!
* IsDefaultable() always returned true, despite it being pretty easy
to implement properly.
* Revert() didn't do anything, probably because fSavedDecor was never
initialized anywhere.
* The UI was not updated in all situations to decorator changes.
Alexander, please have a close look at these changes.
