Commit Graph

56166 Commits

Author SHA1 Message Date
Dario Casalinuovo
95a5e62515 MediaFile: Correctly delete the source on exit
* The delete flag of BUrl constructors was reset by _Init,
this lead to a zombie thread on the background under certain
conditions.
2016-09-07 18:02:34 +02:00
Gabriel Maia
c6b4e47a50 Screenshot: create destination folder if it doesn't exist
This ensures the artwork folder is created if it doesn't exist,
fixing the remainder of #10928.

Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
2016-09-07 07:15:31 +02:00
Rene Gollent
584fd9619c libdebugger: Fix #12944.
LocatableFile:
- If there is no parent path, don't insert a path separator between parent
  and filename. This may be the case depending on how the source file was
  specified during compilation.

FileManager:
- When constructing an EntryPath from a LocatableEntry, ensure that the
  parent folder actually has a path string that isn't simply empty to ensure
  consistency with the raw dir/file case. Otherwise, hash lookups that are
  dependent on the parent dir being NULL if not specified will fail, causing
  us to not locate the file successfully. This was preventing us from updating
  source location information for make 4.2's main.c, as the latter was
  specified in such a way that the above combination of conditions would
  occur, and consequently when asking the FileManager to update the source
  location with the actual file, the entry couldn't be found in the table,
  and no information would be updated.
2016-09-06 22:56:52 -04:00
John Scipione
ed99a95f35 Tracker: Add list view menu to virtual directory window 2016-09-03 12:06:45 -07:00
John Scipione
8fdd2629eb Tracker: 32x32 icon size option in list mode
16x16 is same old default
32x32 is new and fun

Adjust start offset to depend on icon size

Remove the kColumnStart variable and instead use StartOffset()
method which calculates the column start offset based on the icon
size. When you switch between icon sizes in list mode recalculate
the first column width to make room for the icon or more text.

Add some padding to list height in large icon mode.
2016-09-03 12:06:44 -07:00
John Scipione
41b9b4ad9d Tracker: Remove some left behind code
A couple of lines of code were left behind in a previous
refactor. Code just checked some list items.
2016-09-02 22:01:08 -07:00
John Scipione
b339ee18c5 Tracker: Make mini mode default for list mode
but if you are in icon mode (like Desktop) use large icons instead.

This change will be important going forwards.
2016-09-02 21:59:49 -07:00
John Scipione
ee20ff95a4 Tracker: Style fixes
More style fixes
2016-09-02 21:02:06 -07:00
Humdinger
bb5847906b Updated rdesktop package
Old one wasn't installable because of outdated libcrypto dependence.
2016-09-02 17:01:11 +02:00
Automatic Committer
a8b89fbd8a Update pci.ids from pciids.sourceforge.net 2016-09-01 05:20:21 +02:00
John Scipione
8f3b807d64 A few more PRI macro substitutions
Tested on x86_64 build thanks to jessicah.

Should fix x86_64 build.
2016-08-30 16:54:03 -07:00
John Scipione
22fa1929e0 Use appropriate format macros in ERROR macro
(hopefully fixing x86_64 build)
2016-08-30 15:43:23 -07:00
John Scipione
5cf9407148 Revert "Tracker: Add some zoom padding in list mode"
This reverts commit f76147aa9a.
2016-08-30 13:40:48 -07:00
John Scipione
27c911e8bb Revert "Tracker: Add zoom padding in list mode take 2"
This reverts commit 7d009616aa.
2016-08-30 13:40:35 -07:00
Kacper Kasper
020362191a PowerStatus: Show extended info window on middle button click.
* Fixes #7473.
* Minor style cleanup.

Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
2016-08-28 10:50:22 +02:00
Adrien Destugues
915ff0f535 intel_extreme: fix a warning on 64bit platform. 2016-08-27 09:38:06 +02:00
Adrien Destugues
2080509cb0 Fix some missing parentheses
* Problem found by gcc4.
2016-08-27 09:31:16 +02:00
Adrien Destugues
96658eaed9 elf.h: add some defines from Linux version
For completeness and compatibility.
2016-08-27 09:10:01 +02:00
Adrien Destugues
6980817672 Remove pthread.h include from netdb.h
- It is not needed in the .h, and makes gawk build fail.
2016-08-27 09:04:22 +02:00
Adrien Destugues
8a3177ff3f intel_extreme: enable Werror and fix warnings. 2016-08-27 09:03:56 +02:00
Adrien Destugues
8dd9b6f0cf intel_extreme: style fixes and clarifications
Thanks to Axel for review.
2016-08-27 08:34:45 +02:00
John Scipione
7d009616aa Tracker: Add zoom padding in list mode take 2
Add 16px to right and bottom of content when zoom

fixup of last commit
2016-08-26 23:07:18 -07:00
John Scipione
f76147aa9a Tracker: Add some zoom padding in list mode
Add some padding to the right and bottom of the content when
you zoom.

16px the size of a mini-icon
2016-08-26 23:00:14 -07:00
Axel Dörfler
d5f016704d app_server: Also log the incorrect version. 2016-08-26 21:29:00 +02:00
Adrien Destugues
187ad82a62 intel_extreme: fix wait_for_vblank on SandyBridge
There was some mixup with the interrupt registers, still:
- The driver uses 16-bit read/write, but on SandyBridge the register is
  32 bits
- There is a global interrupt enable bit, which must be set to unmask
  everything else
- The bits for vblank interrupt are not the same on SNB and later PCH
  based devices, and the code mixed the two.

Move the computation of the interrupt bits to an helper function, and
use it everywhere to make sure we always use the right bits.
2016-08-26 21:45:38 +02:00
Adrien Destugues
580cd77d0c PS/2: remove all the dead code
Sorry, missed that this would also become useless after removing the
resyncs. Thanks to Kacper for reviewing.
2016-08-26 19:04:35 +02:00
Adrien Destugues
8ae5ad2ccd PS/2: fix dead code.
hrev50506 extended the range of acceptable X and Y movement for PS/2
mouse. However, the value is sent on 1 byte (+ sign) so the check would
now always be valid.

Remove the check completely, we now rely only on bit 3 of the first byte
to be set (and not missing packets) to remain in sync with the mouse.

Thanks to Marcus Overhagen for reviewing the changes.
2016-08-26 07:10:01 +02:00
Adrien Destugues
adc0f76e64 More SandyBridge fixes and cleanups
Modesetting
===========

My previous hack was setting the transcoder registers, instead of the
display ones. Do that the way it is designed in the driver instead:

- If there is a transcoder, set its registers, but do not set the
display timings. The display will remain set at its native (and only)
resolution, and panel fitting will adjust the output of the transcoder
to match.
- If there is no transcoder, set the display registers directly to the
native resolution, as it was done on previous generation devices.
- fPipeOffset hacks no longer needed

DPMS
====

It seems the panel control register is not readable on PCH? Anyway, the
code would loop forever waiting for the bit to become unset when turning
the display off. Waiting seems to not be needed, so just remove it as
well as the "unlock" bit, which does not work for me and results in a
black screen.

Remaining hacks
===============

I still need to force HEAD_MODE_A_ANALOG to get output on pipe B (LVDS
display) working. I suspect something is common to the two pipes or not
allocated to the right one.

This version will have less side effects on other generations and help
with getting things to work on SandyBridge and possibly later devices.
Please test and report.
2016-08-25 23:17:12 +02:00
Automatic Committer
81a9bf1a88 Update pci.ids from pciids.sourceforge.net 2016-08-25 05:20:22 +02:00
Adrien Destugues
5298c29729 Fix regressions introduced in hrev 50503
- Missing "dontAsk" when renaming some files,
- Missing exceptions in the warning alert construction to automatically
  allow modifying some files (anything inside the settings folder)
- Missing translations

Fixes #12925.
2016-08-24 07:26:53 +02:00
John Scipione
c2507fb82b Deskbar: get default collator from BLocale
...using BLocale::Default()->GetCollator(&collator)

Thanks waddlesplash
2016-08-22 17:15:56 -07:00
John Scipione
dd6fccb062 Deskbar: Add new apps using locale collator
... sorry I overlooked this case in my last commit. Need to add apps using
the locale collator Compare() method instead of strcasecmp() as well.

Fixes #7712 better.
2016-08-22 16:52:25 -07:00
0xffea
bd6dcb363f Deskbar: item sorting is not locale-sensitive
Fix using a global BCollator defined in BarApp.

Called static CompareByName() method in TTeamMenu instead of
duplicating code, made method public.

This comes from a patch by 0xffea for GSoC 2014.

A locale aware version of NaturalCompare in WindowMenuItem.cpp
is still needed.

Fixes #7712

Signed-off-by: John Scipione <jscipione@gmail.com>
2016-08-22 15:14:09 -07:00
John Scipione
ca45c75350 PS/2 bus manager check all valid values
According to korli "Valid values seem to be between 255 and -256" which
is verified by syslog running on virtual box with a PS/2 mouse on Haiku
hrev47470.

Fixes #7802

Signed-off-by: John Scipione <jscipione@gmail.com>
2016-08-22 11:24:44 -07:00
Humdinger
a394a16a61 Updated packages for Chat and HaikuPorter 2016-08-21 17:59:23 +02:00
Adrien Destugues
9b1935445c CID 608995: buffer overflow.
This should not happen, so in case a file has an unexpectedly large
name, drop to debugger.
2016-08-21 17:49:52 +02:00
Adrien Destugues
bb4190f050 Fix SandyBridge support.
This reverts commit 4f2b258c32.
This reverts commit c86f3dba23.
This reverts commit 61fbdb0667.
This reverts commit b3f14fb7c7.
2016-08-21 16:54:03 +02:00
Adrien Destugues
c2775a3bbe Revert "intel_extreme: Disable 'experimental' GPUs SNB or higher"
This reverts commit debb71f548.
2016-08-21 16:53:59 +02:00
Adrien Destugues
e43cfe781f netresolv: Remove or disable unused variables
Fixes #12746.
2016-08-21 16:53:56 +02:00
Adrien Destugues
4072c4f1b3 Tracker: fix localization of warning when editing system dirs
Programatically generating a string usually doesn't work well with
localization. Better unfold all the possiblities.

Moreover, the callers of the functions had a long if condition with
3 B_TRANSLATE calls embedded in, and there was an erroneous ; at the end
of those, so the supposedly protected statement was executed anyway.

Fixes #12747.
2016-08-21 16:53:52 +02:00
Adrien Destugues
a8aeb8a9e2 Fix mixed indentation
Fixes #12758.
2016-08-21 16:53:49 +02:00
Adrien Destugues
385ee03ba8 Fix mixed indentation.
This file uses a mix of tab styles, which gcc6 will warn about because
it sees "misleading indentation". Fix the function where this happens.

Fixes #12759.
2016-08-21 16:53:45 +02:00
Murai Takashi
777ff37166 Tracker: Fix -Wlogical-not-parentheses
Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>

With style fix: comparison must still be a boolean value.

Fixes #12892
2016-08-21 16:53:42 +02:00
Murai Takashi
d3c5c6dfeb Terminal: Fix -Wlogical-not-parentheses 2016-08-21 16:53:38 +02:00
Murai Takashi
d41bd688b3 HaikuDepot: Fix -Wlogical-not-parentheses 2016-08-21 16:53:35 +02:00
Adrien Destugues
a6e2839785 Terminal: remove limitation to 6 tabs
- This has been bothering me for quite a while. My screen is wide enough
  to accomodate more, and even if they don't fit the BTabView, it's still
  possible to navigate many more tabs with the keyboard shortcuts.
- We should still remember to fix BTabView to accomodate more tabs than
  it can fit with some scrolling support or similar, however.
2016-08-21 16:53:31 +02:00
Adrien Destugues
36a9daf663 Package kit: more style fixes.
Pointed out by Axel this time. Thanks!
2016-08-21 16:53:27 +02:00
Adrien Destugues
a22f114f7d chroot support in package kit: style fixes
- Catching an exception in the normal flow is not a good thing, instead,
  test before calling the function (I've been doing too much python
  lately)
- Avoid using uninitialized nodeRef if there is no system root and also
  no specified root in the message.

Thanks to Ingo or the code review.
2016-08-21 10:38:23 +02:00
Adrien Destugues
e0c25f9892 VESA: compare modes by index, instead of contents
We only compared the height, width, and depth of modes to decide if the
mode was already set. However, at boot, we may have these settings right
and other things not properly configured, preventing VESA to set a
working mode unless forced from the boot menu.

Fixes #12918
2016-08-20 16:37:13 +02:00
Adrien Destugues
928f78f5a3 FontDemo: localization security fixes
- Avoid use of fixed size buffer without checks, use BString.SetToFormat
  instead.
- Use the same format for the initial setting of the values, so there
  are less strings to translate, and locales using a different
  representation for numbers get the right thing done as well.
- Fix initial label for the outline slider, which did not show the value
  unlike others (problem spotted by Diver, thanks!)
2016-08-20 14:16:17 +02:00