Commit Graph

1807 Commits

Author SHA1 Message Date
Axel Dörfler
7125795f6a E-mail: Fixed initial window size.
* It did not take the height-for-width view into account.
* However, the explicitly set preferred size seems to be ignored.
2015-11-16 20:44:56 +01:00
Adrien Destugues
7460727d4a IP address control: don't try to DNS resolve
* This is used when configuring the DNS client, so resolving will not
  work
* It is supposed to be a control for entering IPs, not domain names.

Fixes #12464.
2015-11-13 21:50:11 +01:00
Axel Dörfler
be741f6ec1 Minor cleanup of translator roster commit, updated copyright. 2015-11-13 11:37:15 +01:00
Markus Himmel
a1eccae96f Make sure images containing BTranslators are not unloaded early
When a translator is uninstalled, BTranslatorPrivate::_RemoveTranslators is
called. This method used to unload the image containing the translator after
calling Release() on it resulting in several problems:

- If the translator was still busy, e.g. translating something while being
  installed, it crashed since the image was unloaded even though its refcount
  was larger than 0.
- Applications using code from one of the translators (e.g. its config view)
  would crash when the translator is uninstalled (this is bug #12005).

This problem is now fixed. The roster keeps track of all translators whose
image it manages (even if the translator was already removed from the roster).
It also keeps a refcount to all images. When a translator's refcount drops to
zero and it belonged to a roster at some point, it does not delete itself, but
notifies the roster that it is ready to destruct, which then removes it from
the roster if the translator is still in it, destroys the translator, decrements
the refcount of the image and if the new refcount is zero, unloads the image.
All of this is done in a message handler, since if the translator called
TranslatorDeleted like before, the unloaded image would be referenced when
the stack is walked up.

Finally, the DataTranslations preflet is required to Acquire() the translator
whose config view it is showing, because otherwise its refcount could be reduced
to 0 and the image unloaded. BTranslatorRoster now enables users to acquire a
translator by ID. By the time the translator has to be released, it might not
be part of the roster anymore though. Since BTranslatorRoster tries not to give
out raw pointers to the translators it manages, users who acquire a translator
through a roster now are given a BTranslatorReleaseDelegate, which allows for
releasing the BTranslator exactly once and then self-destructs.

Signed-off-by: Axel Dörfler <axeld@pinc-software.de>
2015-11-13 11:26:53 +01:00
Adrien Destugues
7218744e73 Network preferences: missing translations.
* Some files with localized items were not added to the jamfile.
2015-11-08 09:22:13 +01:00
Humdinger
ad926b253a Improve/fix tab view layout as discussed
See http://www.freelists.org/post/haiku-development/Unifying-visuals-of-BTabView-usage

Besides the tab bar going the full width of the window, also some
layouting tweaks to several apps and prefs.

Still missing: the first (and last) tabs in the tab bar should be inset by
B_USE_WINDOW_SPACING so the controls in the tab view line up nicely.
I think I remember stippi wanting to look into it... :)
2015-11-07 17:40:24 +01:00
Humdinger
3c5208e439 Improve/fix layout
Some tweaks to the layout of apps/prefs in the course of using
B_USE_WINDOW_SPACING.
2015-11-07 17:40:22 +01:00
Humdinger
744a39273b Use templatized version of BLayoutBuilder
...also more B_USE_WINDOW_SPACING
2015-11-07 17:40:18 +01:00
Humdinger
d0ac609964 Use B_USE_WINDOW_SPACING
Use B_USE_WINDOW_SPACING as inset from contents to window border.
Some whitespace cleanup.
2015-11-07 17:40:16 +01:00
Axel Dörfler
268e4ea27d ScreenSaver: Make preview relative to font size.
* This commit got somehow eaten by git rebase :-/
2015-09-14 20:54:26 +02:00
Axel Dörfler
64ee9242db Time: properly center the window.
* The previous code was broken, and did not take the actual window
  size into account; it's now using BWindow::MoveOnScreen().
* Also, make the width of the time zone list relative to the font size.
2015-09-14 20:46:02 +02:00
Axel Dörfler
8d46a99fe9 Sounds: Center initial window.
* Now uses BWindow::MoveOnScreen().
2015-09-14 20:46:00 +02:00
Axel Dörfler
8bf216d6dd Screen: improved window position, fixed empty line.
* The monitor size now scales with the font size.
* It now uses BWindow::MoveOnScreen() to find a good position on screen.
* The monitor info is now properly hidden when there is no info (this
  removes a blank line at the top of the left box).
2015-09-14 20:45:58 +02:00
Axel Dörfler
4d9fc65ec7 Mouse: let the mouse scale with the font size.
* It's really confusing that SetOrigin() ignores the current
  scaling.
2015-09-14 20:45:55 +02:00
Axel Dörfler
881325a06e Keymap: improve initial window size, and position.
* By making it scale with the font size, and by using
  BWindow::MoveOnScreen().
2015-09-14 20:45:53 +02:00
Axel Dörfler
3f772f525b Backgrounds: let the preview scale with the font size. 2015-09-14 20:45:51 +02:00
Axel Dörfler
f74aab0a2e Appearance: Added font sizes 19, and 20 to the set.
* We might want to find a better solution for this, and also use it
  for the Terminal then.
2015-09-09 20:56:11 +02:00
Humdinger
e10d416e69 Improved warning alert. Spaces were missing. 2015-08-29 08:27:20 +02:00
Dario Casalinuovo
8a28f84965 Media: Fix restart button alignment 2015-08-28 18:27:16 +02:00
Stefano Ceccherini
d6039d2b23 Midi: Remove some duplicated code
Introduced new private read/write_midi_settings() and used them
in MidiSettingsView and SoftSynth.
2015-08-27 11:51:57 +02:00
Augustin Cavalier
281409fdc0 Revert accidental addition to Jamfile. 2015-08-26 15:54:15 -04:00
Augustin Cavalier
41f43d568f Screen: Rework AlertView to just use BAlert.
Fixes #12330.
2015-08-26 14:42:14 -04:00
Dario Casalinuovo
d9971ae7aa Media: Show alert while media services restart 2015-08-26 16:39:42 +02:00
Stefano Ceccherini
3ffaf5c263 MidiSettingsView: renamed box label
Renamed box label from "SoundFont" to "Available SoundFonts", hopefully
improves the user experience by making it clearer that this is a list
of the available soundfonts.
2015-08-24 10:23:28 +02:00
Stefano Ceccherini
a6fb27a3f6 Improved comment. Added TODO 2015-08-24 10:03:54 +02:00
John Scipione
a0ba79fbff Split BSpinner into BAbstractSpinner and...
2 concrete classes which are currently implemented:
* BSpinner (works on int32s)
* BDecimalSpinner (works on doubles)

In addition BAbstractSpinner now inherits from BControl instead of
BView/BInvoker. This allowed for code simplification at the cost of needing to
cast for the decimal version because SetValue(int32 value) comes from BControl.

Also, add a spinner_button_style enum with 3 options:
* SPINNER_BUTTON_HORIZONTAL_ARROWS
* SPINNER_BUTTON_VERTICAL_ARROWS
* SPINNER_BUTTON_PLUS_MINUS

which sets the spinner arrows to either use horizontal arrows (left/right)
vertical arrows, (up/down), or +/- symbols (the default).

If the spinner button is using horizontal arrows you can decrement and increment
the spinner value by pushing control+left/right, otherwise you can increment and
decrement by pushing up or down. The reason for needing control is so that you
can move the cursor in the textbox otherwise.

Switch the 3 apps that are currently using BSpinners to use the integer variety
in Deskbar preferences, WebPostive preferences, and Screen preferences.
2015-08-22 15:15:08 -07:00
John Scipione
a3fa81bd03 Update Screen prefs to use BSpinner class 2015-08-22 15:15:03 -07:00
Humdinger
26cc9e9e07 Small cosmetics for the preference panel
* Prevent the scrollview from jumping vertically when selecting a service
* Glue the services view to the top
2015-08-11 19:05:04 +02:00
Dario Casalinuovo
7bdc7eec03 Media: Refresh window also at QUIT event.
* Since the Media preferences are always watching for media
  status, it's good to clean up the window when the media services
  are not running. This avoid the user try to use controls where
  services are down.
2015-07-30 19:14:13 +02:00
Dario Casalinuovo
922d2034b2 Media: Reinit media also when the restart thread finish 2015-07-30 13:23:27 +02:00
Dario Casalinuovo
7482390ab4 Media: Improve both notifications and quit mechanism
* Media is now waiting for media_server to start if the window
  is closed before to finish, this was proposed by stippi.
* Moved out anything related to notifications as they are now
  managed by the media_kit.
* Solved some TODOs and minor issues too.
2015-07-29 18:05:04 +02:00
Dario Casalinuovo
009034bdf0 Media: Display alert before to quit when restarting
* Fixes 10770.
* While more complex solutions are proposed, i think
  of it as a way to get out of an eventual deadlock or
  to protect from accident close.
2015-07-27 20:25:26 +02:00
Jérôme Duval
9cd62a24e5 Fixed C++11 warnings.
invalid suffix on literal; C++11 requires a space between literal and string macro
[-Werror=literal-suffix]
2015-07-25 23:42:13 +02:00
Dario Casalinuovo
b43b20d38f Media: Add support for media services notifications 2015-07-24 12:19:34 +02:00
Augustin Cavalier
f3dd3a96c8 FileTypes: ApplicationTypesWindow: Fix UI updates when the file doesn't exist.
If the filetype existed but the entry_ref did not, then the path from
the previously shown application would be used. This fixes that.
2015-07-23 11:50:20 -04:00
Augustin Cavalier
0267bc5f22 FileTypes: We don't plan on building for BeOS, so get rid of the ifdef. 2015-07-23 11:50:16 -04:00
Philippe Saint-Pierre
02ab820d0e Backgrounds: FlattenedSize() can be negative (error status)
CID 610928.
2015-07-01 22:18:11 -04:00
Philippe Saint-Pierre
1443b2798f CID 1249930: Don't scanf uninitialized buffer
Would happen in case of a missing config file, for instance.
2015-06-25 19:29:13 -04:00
Augustin Cavalier
8db7ed33fc Delete useless gunk (mostly old Makefiles). 2015-06-22 14:53:23 -04:00
Janus
0a3ea2cfa4 Printers: the window has a proper minimum size
* Fixes #8675.
2015-06-07 15:24:29 +02:00
Janus
1503b7f02b Backgrounds: saves the state of ImageFilePanel
* Fixes #8787.
2015-06-05 15:36:42 +02:00
Janus
1ad18684bb Background: avoid 100% CPU usage
* There was an infinite exchange of messages between
  the main window and the BackgroundView.
* Fixes #11996.
2015-06-04 18:31:59 +02:00
Murai Takashi
25122be50e Fix GCC 5 unused-variable warning.
Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
2015-06-01 18:32:17 -04:00
Janus
f9f8bce6d2 Printers: fix glitches in PrinterListView and JobListView.
* Fix 12103.
2015-05-31 21:30:29 +02:00
Janus
03f60b036c Printers: remove unused header 2015-05-30 21:42:04 +02:00
Janus
51c4f366c4 Printers: use a vector icon for the overlay checkmark.
* The checkmark is a McClintock's icon  (Pref icon without the shadow)
2015-05-30 20:34:00 +02:00
Jérôme Duval
73de58376a Update icu x86_64 package with namespace renaming enabled.
"Renaming" means the icu namespace is suffixed with the version number,
atm icu_55. Using "renaming" allows to use two different versions of ICU,
thus easing upgrades. For instance haikuwebkit uses a current version of ICU,
while the system uses a newer one after an upgrade.

* Replace all uses of the icu namespace in our public headers, with a macro
defaulting to icu. As the namespace is only used for private fields pointers,
there should be no impact.
* Locale kit *.cpp have to import the macro from <unicode/uversion.h> *before*
including any locale headers. Ditto for a Time preferences cpp file. This way,
the correct current icu namespace is referenced.
* Fixes bug #12057.
2015-05-10 21:52:36 +02:00
Janus
86213fcb0d Printers: printers preferences uses layout.
* Partialy fix #4178.
2015-05-09 23:20:12 +02:00
Janus
91a14c7c9b Time: reintroduces seconds for aesthetic reasons.
* Thanks to Humdinger for point out the problem.
* Problem discussed in #10840.
2015-05-02 17:33:00 +02:00
Janus
3c7469c1c1 DataTranslations: Put the dragged translators in the nonpackage dir.
* Fixes #12008
2015-04-25 19:08:05 +02:00