5411 Commits

Author SHA1 Message Date
Adrien Destugues
6e24fc677f CID 1498 (and others) : when deleting a NULL pointer, operator delete is actually called. So, it must not dereference the
given pointer without checking first.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38147 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-16 15:07:29 +00:00
Oliver Tappe
f23b9d8a72 * added possibility to pass in the timezone when formatting the time
* added TODOs about the need to get rid of some of the date/time-formatting
  shortcut methods

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38146 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-16 15:03:54 +00:00
Oliver Tappe
559cf371bc * fix oversight that gmtime() and localtime() may return NULL, which would lead
to a crash


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38143 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-16 14:52:37 +00:00
Adrien Destugues
a20769b39c CID 1500 : Potential NULL poiner dereference.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38140 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-16 13:37:10 +00:00
Rene Gollent
606e627e76 Remove unnecessary NULL check (the view in question is created in all cases in InitCommon(), and is already dereferenced several times prior to the check in the function anyways).
Fixes CID 1078.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38129 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-16 02:45:08 +00:00
Stefano Ceccherini
372b00b0f7 Style (pointer & spaces/tabs)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38115 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-15 12:18:26 +00:00
Stefano Ceccherini
f97e560e1c Fixed incorrect check. CID 1339
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38112 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-15 11:05:28 +00:00
François Revol
a4c54e94e8 Delete types when that's what you mean, not strings from the wrong list. Fixes a double free() that made ThemeManager crash.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38105 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-15 03:52:35 +00:00
Stefano Ceccherini
1345706a9f Fix typo (CID 392)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38104 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-14 21:25:16 +00:00
Alex Wilson
e70fa080b2 Should have been part of my previous commit.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38065 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-12 16:56:46 +00:00
Alex Wilson
aa818be69a Update BView to call debugger when passed a NULL archive for its archive constructor. This means there is no need to check for a NULL archive in BSeparatorView. Also update BUnarchiver and friends to be NULL safe. Pointed out by Adrien, fixes CID 1754.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38063 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-12 14:50:57 +00:00
Axel Dörfler
97ef73e074 * Added convenience methods FindAddress(), and FindFirstAddress().
* Added BNetworkInterfaceAddress::Destination() as synonym for Broadcast()
  (depending on the configuration, it could be either one).
* Media() will now return -1 in case of an error.
* Added "const" where it makes sense.
* Added convenience functions for AddAddress(), and RemoveAddress() that only
  take the actual address.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38060 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-12 13:50:32 +00:00
Axel Dörfler
530f548320 * Implemented AddInterface(), and RemoveInterface().
* Added comment explaining why using AF_INET is not really a good idea.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38057 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-12 13:30:39 +00:00
Axel Dörfler
b85c513ee7 * B_NO_ADDRESS_RESOLUTION now implies not setting AI_ADDRCONFIG, as that flag
doesn't really make sense in this case.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38056 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-12 13:29:44 +00:00
Axel Dörfler
31a49a69c7 * Added support for printing AF_LINK addresses.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38055 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-12 13:28:55 +00:00
Adrien Destugues
db8d0b8781 CID 898 : Memory leak.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38049 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-12 12:42:58 +00:00
Axel Dörfler
cd8ca1e595 * Improved error reporting.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38040 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-12 11:43:20 +00:00
Axel Dörfler
836c43f2b8 * Factored out a BNetworkAddressResolver from BNetworkAddress, that also allows
to iterate over all possible addresses, as suggested privately by Rene.
* Added flags to the resolving methods that allow more control over the
  addresses returned.
* Added setters to BNetworkAddress that accept a service name instead of port
  number, renamed PortName() to ServiceName().
* Made the sockaddr* cast operators return a const sockaddr as it was supposed
  to be, although I should probably add non-const ones as well.
* This also simplified the code somewhat.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38039 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-12 11:27:14 +00:00
Oliver Tappe
0bae871739 Closing #2334:
* fix incorrect implicit type extension in WidthBuffer::CharToCode() that led 
  to some values not being represented correctly (depending on input chars)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38034 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-11 18:08:45 +00:00
Oliver Tappe
2feea51f57 * cleanup and style fixes in WidthBuffer
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38033 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-11 18:03:37 +00:00
Jérôme Duval
5091a866ec To be validated as part of bug #6386. Update glibc regex to 2.11, headers/posix/regex.h included. This imposes some changes in some of our sources using the regex.h,
mostly bin tools and mail kit. The use of __USE_GNU macro is needed for instance when the expected regex implementation is the GNU one.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38031 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-11 16:49:58 +00:00
Axel Dörfler
23f2073215 * Implemented SetToMask(), and added PrefixLength() method, mostly reusing
code from ifconfig.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38026 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-11 13:53:31 +00:00
Axel Dörfler
9de96be375 * Added methods to get/set the media/metric.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38024 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-11 13:18:36 +00:00
Axel Dörfler
54b6869f51 * Forgot to implement the sockaddr* cast operator.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38023 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-11 13:18:03 +00:00
Adrien Destugues
0417c0fd7e * Remove everything related to direct access to unicode.properties file. All of it should be done through ICU.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38017 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-11 12:00:59 +00:00
Axel Dörfler
b232302077 * The leading spaces and zeros are now actually skipped, instead of copied first
and then replaced.
* Now considers a space to end a number chunk. In the future, we might want to
  think about sorting fractional amounts correctly as well, but I guess that's
  not that important for Tracker.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38013 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-11 10:29:00 +00:00
Axel Dörfler
6a960972b5 * We cannot use a natural sorting algorithm that only supports int32 - that
cannot be stable for entries with up to B_FILE_NAME_LENGTH (256) bytes.
* Rewrote the natural sorting code to be simpler where possible, but also
  supports sorting numbers of arbitrary length.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38012 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-11 10:14:20 +00:00
Adrien Destugues
15575718e8 * Don't build stubbed and useless files in liblocale.so
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38011 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-11 10:05:06 +00:00
Adrien Destugues
5509491f57 * Style fix. Sorry, looks like I spent too much time on other projects today.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38009 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-10 21:09:56 +00:00
Adrien Destugues
aed7e5e9ae * Make BCountry::Measurement() actually do something useful.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38007 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-10 16:22:30 +00:00
Oliver Tappe
e70da3e14c Closing #5959:
* _DoInsertText() must not assume that the text is actually being inserted
  by InsertText(), since that's a virtual method meant to be overridden by
  subclasses. So the updating of caret-position and selection start/end has
  to happen in InsertText().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38006 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-10 14:02:22 +00:00
Oliver Tappe
cb06c64a5d * style fixes to textview_support class LineBuffer
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38005 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-10 13:58:19 +00:00
Axel Dörfler
cb7ce9a32f * Renamed DescriptorCloser to FileDescriptorCloser as suggested by Ingo.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37995 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-09 21:23:05 +00:00
Axel Dörfler
f65256c2e7 * Fixed a bug in BNetworkRoster::GetNextInterface() that caused an endless loop
and always returned the first interface.
* Fixed bug #6436 by using the new BNetworkRoster functionality.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37994 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-09 19:12:51 +00:00
Fredrik Holmqvist
719c470746 Header defines the default value for Archive's second param. Fixes build bustage.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37992 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-09 18:40:26 +00:00
Oliver Tappe
a4bcdeaaf1 Fix another glitch reported in #6435
* when shrinking the gap, avoid that deleting the next character will shrink
  the gap again


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37989 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-09 16:39:43 +00:00
Axel Dörfler
c2808ea7b2 * Adapted API as needed, and implemented most of the C++ API - it's completely
untested at this point, though.
* Will port ifconfig, NetworkStatus, and the Network preferences application
  later in order to test the API.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37988 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-09 16:31:40 +00:00
Oliver Tappe
7e31a05ca5 Close #6435:
* fix problem in TextGapBuffer which could lead to data loss at end of buffer
  when deleting large chunks of text
 

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37987 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-09 16:30:28 +00:00
Axel Dörfler
969d58acec * Minor cleanup.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37985 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-09 16:30:04 +00:00
Oliver Tappe
c34238562b * style cleanup - no functional change
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37984 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-09 15:12:43 +00:00
Alexandre Deckner
894cf4f363 * Apply patch from Takashi Murai: use layouting for Tracker settings window/views.
Slight modifications to the patch:
    Put back passing the view names (eventhough it seem useless atm).
    One or two small indenting issues.
    Implemented your todo (listview width adapts to the longest item).
  
  Thanks a lot.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37978 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-08 23:46:59 +00:00
Alexandre Deckner
43f24e051b * Apply patch by Takashi Murai, find menu items by message code instead of item name (correcting previous patch)
I've found more occurences but i will solve it differently since they are about finding messageless submenus.
  Thanks!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37974 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-08 14:37:06 +00:00
Stefano Ceccherini
e749444dfb Style
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37973 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-08 12:48:19 +00:00
Stefano Ceccherini
6fa16ae6e5 Add parenthesis, otherwise the code is broken
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37972 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-08 12:43:01 +00:00
Stefano Ceccherini
e571dc2536 free buffer in case of error.
CID 1695


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37971 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-08 12:35:15 +00:00
Alex Wilson
afe949d2f1 Fix incorrect initialization of boolean in BGridLayout::ItemRemoved() that lead to unreachable code, fixes CID 58.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37966 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-08 02:54:01 +00:00
Jérôme Duval
446287462b CID 1463: Delete an array with delete[]
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37960 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-07 23:17:26 +00:00
Adrien Destugues
c9b2be8bea CID 1643 : Off-byÃ-one rray access.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37956 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-07 17:31:36 +00:00
Adrien Destugues
4a7b2e0484 * Add FormatDateTime function to BLocale
* Use the function to localize the date/time in tracker.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37949 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-07 11:22:16 +00:00
Axel Dörfler
bf58f252de * Adapted headers after Stippi's suggestions - I won't add the const until I
know how I implement that function :-)
* Cleaned up libbnetapi.so Jamfile, removed non-Haiku target code.
* Added empty files to the build to see that the headers are compiling.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37942 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-06 13:22:25 +00:00