Commit Graph

61932 Commits

Author SHA1 Message Date
Heinrich Schuchardt
35323f65d5 efi: create map file
When debugging the EFI bootloader it is helpful to have a map file
available.

Write file efi.map when linking.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Change-Id: I6d566df50fb2713f53375970f6645353bac54042
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2964
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
2020-06-28 21:04:29 +00:00
Andrew Lindesay
dc8d6e73f8 HaikuDepot: Custom List Removal
Remove use of custom list class in the python-
generated model classes for interaction with
HDS; use STL container classes instead.

Relates To #15534

Change-Id: Ib8f4942b55859c1af38da816591e911174ba52ea
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2957
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-06-28 08:39:20 +00:00
X512
43def5e333 Fix source code encoding
Make it correctly readable as UTF-8 encoding.

Change-Id: Ifef77aa988b8d45c485927b698526e234711425c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2955
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-06-27 16:58:05 +00:00
Murai Takashi
c23cd33c75 file_systems/fat: Fix usage of sizeof()
Fix suspicious usage of 'sizeof' with a numeric constant
as parameter.
Pointed out by cppcheck.

Change-Id: Icf43843bb92b3db0634c20ddce38e2fe1099c552
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2954
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-06-27 15:09:04 +00:00
Autocomitter
1a83eab65b Update translations from Pootle 2020-06-27 08:16:31 +00:00
Murai Takashi
6b3cfabfd4 libnetapi: Fix if condition
Fix length[0] != '+' could not be checked.
Pointed out by cppcheck.

Change-Id: Ic4697dc9ffd04afcd92ef3ed65485e1fe3f32e76
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2950
Reviewed-by: leorize <leorize+oss@disroot.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-06-26 23:50:53 +00:00
Axel Dörfler
1487a24238 lsindex: Fixed wrong errno code to be shown
* When we want to inspect errno after readdir() (or fs_read_index_dir(),
  which is the same), we need to reset errno beforehand as documented
  in the OpenGroup Base.
* Minor coding style, and license header fixes.
* This fixes the wrong error code from #16301, but not the underlying
  issue.
2020-06-25 22:21:23 +02:00
Axel Dörfler
60162d0118 fs_index: Clarified errno setting 2020-06-25 19:11:05 +02:00
Murai Takashi
1e9cdb0bd8 bin/setversion: Fix if condition
Fix str = "gm" could not be checked.
Pointed out by cppcheck.

Change-Id: I433a98cef851e07be0905eee2f5100a02fa6a32b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2949
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-06-25 14:11:37 +00:00
Murai Takashi
c89d626d0e kernel/arch/x86: Fix PVS V773
Fix choose_link_device_configurations() was exited
without releasing the 'link' pointer.

Change-Id: I1620e63779975305776ffad717cbe2c07f4e022f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2948
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-06-25 14:11:37 +00:00
Murai Takashi
69d1697649 userlandfs/server/fuse: Fix PVS V773
Fix FUSEVolume::OpenAttr() was exited
without releasing the 'cookie' pointer.

Change-Id: I8bf08268c77e1c9704227b1d4c7c94ddcc8b09a3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2947
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-06-25 14:11:37 +00:00
Murai Takashi
ece405c749 add-ons/kernel/busses/i2c: Fix Memory leak
Fix init_device() was exited without releasing the 'bus' pointer.
Pointed out by cppcheck.

Change-Id: I0ec1a78caa83d7d34a3d88fee64716dcbbc82dd2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2951
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-06-25 14:09:30 +00:00
X512
9bc51ee07c BLooper: implement scripting
Change-Id: I73dd301ca7109675a4b629464ba7275a8095c77b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2940
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-06-24 14:08:28 +00:00
X512
079e9eef15 BListView: complete scripting support
Change-Id: Iff4b5cb775d1c0b0e588459429d6df7fb93a760e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2945
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-06-24 14:08:16 +00:00
X512
8fbce87334 BMenu: implement scripting
Fixes #15540.

Change-Id: I965d04bcbb6db41cc7a744d18fa3c9ffab2a81f1
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2941
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-06-24 14:08:16 +00:00
Preetpal Kaur
abbd654ba9 Added 6th button in Mouse GUI
- Correct button size of 4 and 5 buttons in Mouse GUI.
- Button number are in squence now, added the default values.

Change-Id: I915077d11f9212c47c782fd9296b9f5b8909ed09
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2509
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-06-24 06:28:04 +00:00
Alexander von Gluck IV
398b7899e8 arm: Generate proper mmc image
* Stub out makebootable like on u-boot
* Place haiku_loader.efi at EFI/BOOT/BOOTXXX.EFI
* Generate boot.scr for u-boot + EFI
* haiku-mmc.image now attempts to auto-boot in qemu-system-arm
* Same code paths should roughly apply for arm64,riscv,etc

Change-Id: I563ebd77422d9e5dfcfeeedadcbc60471e8a57f4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2938
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-06-22 18:48:20 +00:00
Adrien Destugues
90530755d2 Build fix. 2020-06-22 20:08:15 +02:00
Augustin Cavalier
cbf71a819f libnetwork: Replace some basic inet_* functions with the musl versions.
This beings the replacement of the libbind/netresolv-based implementation
with musl's equivalent. The code is less well commented in some places,
but it is well-designed and well-maintained, and the licensing situation
is much cleaner than the multi-BSD-licensed libbind-derivative code,
as well as being actively maintained (supposedly NetBSD has taken over
libbind/netresolv, but have not posted any portable code since 2013.)

The eventual goal is to replace the entirety of NetResolv with code
from musl, which will be an involved process as ABI compatibility
will be a problem. These functions at least are extremely
straightforward to replace.

Change-Id: Icfefaa90cbf56b012e4e42360be5b0f0c16d73bf
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2943
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
2020-06-22 16:02:31 +00:00
Augustin Cavalier
17dab0d52b inet.h: Remove "cidr" functions.
These are not in the standard and are not declared by glibc at all.
The symbols remain for any applications that are still using them,
for now.\

Change-Id: Ie6b4a6b5ec3231c304e05ce9cb38c67d9ee51ad7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2942
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-06-22 16:02:31 +00:00
Preetpal Kaur
13b45a2ea3 Integrate PadBlocker in input preferences
- Import padblocker sources
- Add slider to set padblocking time
- Generates PadBlocker settings

Fixes #11673

Change-Id: Ic88416215aabb1ae6aba79ff41cb55a7f0f8008d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1590
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-06-22 15:08:48 +00:00
X512
1e4192fc86 Magnify: fix scripting
Change-Id: If7f283d35c4af894c0db58ea015b4f3ea278ecdd
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2939
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-06-21 18:08:07 +00:00
Augustin Cavalier
176d0e1041 app_server: Make use of BReferenceable in AlphaMask.
Extracted from https://review.haiku-os.org/c/haiku/+/2695
with a few minor tweaks.

May help with #16246, but I could only reproduce it intermittently.
2020-06-20 20:02:35 -04:00
Augustin Cavalier
67ace0bfab app_server: Use RecursiveLocker in AlphaMask instead of BLocker.
This avoids creaing a semaphore where it is not needed, especially
as most of these locks are never used from another thread (in the
reports in #16246, there are thousands of semaphores from this
with only a small handful having a "last acquirer" != 0.)
2020-06-20 19:46:22 -04:00
Augustin Cavalier
b344d252e9 kernel/file_cache: Move write_zeros_... call out of else.
Style only, no functional change. Requested by axeld.
2020-06-20 17:21:56 -04:00
Augustin Cavalier
be1cc9c890 kernel/vm: Make the page_scrubber wait on a condition.
On an idle system with 1GB RAM and the 100ms timeout, it takes multiple
minutes for all the pages in the system to get cleared after boot, but once
they do, the page scrubber will then remain idle for seconds to even
minutes at a time, so this is clearly worth it.

The "free pages condition" was unused before this commit, so I have
repurposed it (and unpublished it.)

Change-Id: I7034677a1e51c97c2baf11b772db3a31c0e1adfa
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1699
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-06-20 21:18:57 +00:00
Augustin Cavalier
0786d50332 DMAResource: Validate that alignment <= block_size.
The code here cannot handle the case where alignment > block_size,
so anything calling Init() with these parameters is invalid.

Fixes #15902 (nvme_disk was long since adjusted, so this is a defense
against code being written in the future.)
2020-06-20 15:39:10 -04:00
Augustin Cavalier
5f9ca54d1a BHttpResult: Include errno.h. 2020-06-20 14:41:44 -04:00
Alexander von Gluck IV
0ed9b677ee arm: switch to EFI, drop FDT in loader
* This should 'fix' the arm build
* No longer parse FDT in bootloader, just pass ptr.
* The EFI loader doesn't load yet on arm
* It compiles though. Ship it!

Change-Id: I7c8ce588298dfaf4fba8054c6b6d9a92733b5943
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2903
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-06-20 18:35:36 +00:00
X512
111247c842 app_server: match behavior when drawing to BPicture
Change-Id: I7676e73bda0eb02a1905888706aab6bb1db401d5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2892
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-06-20 18:33:30 +00:00
Humdinger
bbd39960bf Installer: make alert text clearer
* Put 'settings' folder in quotes, just like 'system'.

* Break down the very long sentence.

* The "its" in "...will retain its settings folder" refers to the
  source folder, when it's actually the target that is kept.

* 'whereas' isn't the right word IMO, as the following text is more
  an explanation what 'merging' entails.

Change-Id: Iae2f1768fdf897b4c6ffb02be6800fdd85e2cde8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2919
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-06-20 18:31:33 +00:00
Andrew Lindesay
991d1a2097 PackageKit: HPKR BMessage Format Fix
Some older repositories are having problems because
they are configured with a `url` (identifier) form
that is not actually a well-formed URL.  This caused
problems when it was then interpreted as the
base-url because it did not start with "http".  I
have changed this so that the base-url is not
derived from the url and can be missing.

Resolves #16149

Change-Id: I10acd8db65082ff6c72fcff1550eb63475e86133
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2931
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-06-20 18:30:20 +00:00
Michael Lotz
2778057ccd kernel/vm: Change free swap reporting to actually free pages.
Previously system_info->free_swap_pages was using swap_available_pages
which has reservations removed. Tools like ActivityMonitor would
therefore show mere reservations as swap use which is misleading at
best.

Switch to use the sum of the free slots of all swap files instead.
This doesn't add overhead as the swap file list was already locked and
traversed for max_swap_pages before (via swap_total_swap_pages()).

Fixes #16248.

Change-Id: I3ebf223ec108bf342d4f32d68405170e72528899
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2917
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-06-20 18:27:46 +00:00
CodeforEvolution
29ae0e0f61 wacom: SMAP Fixes and Refactoring
Utilize user_memcpy and IS_USER_ADDRESS when necessary to prevent SMAP violations.
Also add a "wacom_device_header" struct to more easily share data between the wacom
kernel driver and input_server addon.

Should fix #14589

Change-Id: Ie2784020b21523f82fd450a2db2de60ccf9d6620
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2783
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-06-20 18:26:45 +00:00
Augustin Cavalier
a32381ee57 BFS: Fix typo in prior commit. 2020-06-20 14:22:31 -04:00
Adrien Destugues
fc5ce31970 Missing pluralization in Tracker InfoWindow
Fixes #16086

Change-Id: I1984ff7a9a5f6614e7a278efae45e6c7100d759f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2769
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-06-20 18:16:57 +00:00
X512
e1bb846d71 BColumnListView: fix keyboard navigation
Make expanding/collapsing logic the same as in BOutlineListView.

Change-Id: Ia8669ec6ac1be15c09879aa759474b4841451c39
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2933
Reviewed-by: John Scipione <jscipione@gmail.com>
2020-06-20 18:14:48 +00:00
Humdinger
f29b420144 Teammonitor: Add 'Open Terminal' button
* Add a button to open a Terminal to the left of the Cancel button.
  The ALT+OPT+T combo is a bit hidden, as mentioned in #16243.

* After opening a Terminal, close the Team Monitor. Being a modal
  window, the user would have to close it manually anyway to be able
  to use the Terminal.

* Remove the unneeded instructions how to use the Quit and Kill buttons.
  Now we can use a simple BStringView and avoid most of the font style
  complications.

* Put some weight on the scroll view, so it's the only view getting
  taller when vertically resize the window.

Change-Id: I4a58033c0ce9b36a0e714f9bdd5c5542bca30849
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2906
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-06-20 18:14:11 +00:00
Leorize
bbc0611099 docs: Add docs for BUrlProtocolAsynchronousListener
Change-Id: Ib9df07d42d0153a7e0135acae85c00f3a1e6bd93
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2930
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-06-20 18:13:33 +00:00
Leorize
b927cf6822 docs: Add documentation for BUrlProtocolListener
Change-Id: I6fb6092d31e9ff94a1c9466240b375b9b88f2d8f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2929
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-06-20 18:13:33 +00:00
Leorize
fcf08bbd68 docs: Add documentation for BUrlProtocolRoster
Change-Id: Id4bc0809c970ea14f814820b54e52073e3396502
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2928
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-06-20 18:13:33 +00:00
X512
fbb8bf7ee3 Preferences/Input: fix scripting
Change-Id: Iafe52399f193c079eac8c45273801c762a99e023
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2935
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-06-20 18:12:51 +00:00
Axel Dörfler
2d4d531731 bfs: CheckVisitor only deletes nodes on specific errors
* This should prevent erroneously deleting any files in low memory
  situations.

Change-Id: I21b1d042e5f7e03a5abfaaa567b6c679b95e3188
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2914
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-06-20 18:10:03 +00:00
Axel Dörfler
93845aec95 block_cache: Change signature of *_etc() functions
* This allows file systems to retrieve the actual error code on a
  failure, and report it to the user.
* All affected file systems have been adjusted to the API change.
  This is a binary incompatible change.

Change-Id: Id73392aaf9c6cb7d643ff9adcb8bf80f3037874c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2913
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-06-20 18:10:03 +00:00
Autocomitter
cc7b6b5870 Update translations from Pootle 2020-06-20 08:11:47 +00:00
Leorize
d345666ea8 libnetapi/HttpResult: improve Length() algorithm
`atoi()` maximum value is `LONG_MAX` which is smaller than `SIZE_MAX`.
This cause any Content-Length > LONG_MAX to be represented in an
erroneous value. This will also happen to any invalid Content-Length
header.

This change uses strtoul() for the extended range (should be the same as
size_t range), and combined with proper error checking to determine
whether the received Content-Length is a valid and/or representable
value. Returns 0 if the data is invalid or can not be represented.

Some shortcomings about the current implementation are also
noted accordingly. They will be solved in later patches.

Change-Id: If28c4c3b8430ed83dd0f600030ec8949cf7e0051
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2927
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-06-20 02:02:49 +00:00
Rob Gill
9bfdc55864 Add DoCatalogs entries
Signed-off-by: Rob Gill <rrobgill@protonmail.com>
Change-Id: Iee85ccda72608548b77d61fac0d6cbfe98a5c7e8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2926
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-06-19 20:58:53 +00:00
Rob Gill
f435226298 Trivial additions for localization of strings
Signed-off-by: Rob Gill <rrobgill@protonmail.com>
Change-Id: I078f2de99c6461a937f4c645b65d5caf06d54dcb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2925
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-06-19 20:57:21 +00:00
Humdinger
437e3c1c06 Notifications: Fix pluralization, max/min window width font size dependend
Plus, use kWidthStep when loading/saving slider setting.

Fixes #16119

Change-Id: I2c86bb008a8d9e089d9db09013c9af67b0f5e731
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2902
Reviewed-by: Kacper Kasper <kacperkasper@gmail.com>
2020-06-19 06:43:11 +00:00
Rob Gill
7522ed82b8 preferences/input Add default mappings to mouse buttons 4/5
* Adds default mappings to newly added buttons 4 and 5

* Include mappings of buttons 4 and 5 in settings dump

* Fixes Bug #16268

Signed-off-by: Rob Gill <rrobgill@protonmail.com>
Change-Id: If466088e622a9e818f9eb7bd67c3a65154b9ad37
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2924
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-06-17 04:51:08 +00:00