Commit Graph

38200 Commits

Author SHA1 Message Date
Ryan Leavengood
3107597abe Fix coding violations, improve variable naming, remove strange float constants
like 4.f.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40109 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-04 16:14:25 +00:00
Ryan Leavengood
bdb262352e Fix style violations and a few other issues that were pointed out. Thanks!
Also moved private methods to the bottom of source files.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40108 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-04 15:46:45 +00:00
Joachim Seemer
59eb31ce66 Who else could need a second try to fix a one-liner? Embarrassing.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40107 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-04 11:03:31 +00:00
Joachim Seemer
4adbc3ad27 Fixed coding style as pointed out by korli. Sorry about that...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40106 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-04 08:54:23 +00:00
Philippe Houdoin
1a698b259b Actually check *distinct* configurations. Checking always the first one several times wont make it works
better :-)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40105 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-04 07:37:29 +00:00
Ryan Leavengood
fc74a4ff91 Add the new screen savers Butterfly and Leaves to the image, and also
alphabatize the screen savers in this file.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40104 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-04 06:20:44 +00:00
Ryan Leavengood
e853910af2 So I'm not sure if this ever worked right or if time is just measured
differently in Germany, but NetworkTime was always setting my time 6 hours
ahead, no matter what time zone or whether I stored the time in local time or
GMT. Upon looking closer and doing some Googling I determined that the constant
Axel used for the number of seconds between 1900 and 2000 was off by 6 hours,
and that combined with the odd kUTCtoGMT constant resulted in the 6 hour
difference.

By just replacing the system_time_difference() function with a correct constant
for the number of seconds between 1900 and 1970 and getting rid of kUTCtoGMT it
now works for me (and at least one other person on #haiku-dev, thanks
kallisti5!) For those wondering NTP time is measured from 1900 hence the need
for this conversion.

I will now look into integrating this with the Time preflet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40103 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-04 06:18:51 +00:00
Rene Gollent
0d791a3062 Fix uninitialized member var that was resulting in a crash on startup. Resolves #7055.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40102 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-04 04:02:51 +00:00
Ryan Leavengood
71d86b674b Apply another patch from Hamish Morrison to improve the VirtualMemory preflet.
Pretty much implements everything needed to set a swap volume once that is
implemented on the kernel side. This also improves the behavior of the Default
button.

A few changes I made:

- When the swap volume feature is turned on in the code, default to the boot
  volume if the settings file does not have one set.
- Don't show the volumes menu field in the GUI if the swap volume feature is
  not on.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40101 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-04 02:13:13 +00:00
Ingo Weinhold
3292bde924 Opening a FIFO end is supposed to block until the other end is opened, too.
So we need a little work-around to open both ends in the shell process to
avoid blocking. Apparently Haiku's FIFO implementation isn't quite conforming
yet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40100 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-04 01:39:30 +00:00
Ryan Leavengood
6186bb4464 Add Geoffry Song and Deyan Genovski to the Contributors in AboutSystem.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40099 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-04 01:15:03 +00:00
Ryan Leavengood
57d51b24ff Add two new screensavers created by students from the GCI:
Butterfly by Geoffry Song.
Leaves by Deyan Genovski and Geoffry Song.

Thanks guys!

I fixed a few coding violations and wrote the Jamfiles.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40098 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-04 01:10:59 +00:00
Ingo Weinhold
17ebe2b021 Reimplemented the communication with the FS shell for Unixish systems (now
including also Haiku) using FIFOs instead of Unix sockets. Advantages:
* Multiple FS shells can run concurrently, since they no longer need a unique
  address.
* Killing/aborting the build_haiku_image script will automatically tear down
  the FS shell as well, so there shouldn't be any stray FS shell processes
  anymore. Hopefully also fixes #5498.

So far only tested under Haiku.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40097 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-04 01:06:56 +00:00
Ingo Weinhold
40982d1e05 Check user_strlcpy() return value (CID 4053).
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40096 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-03 19:09:14 +00:00
Ingo Weinhold
0068f3c810 Fixed uint32 underflow in backwards loop (CID 2601).
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40095 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-03 18:30:19 +00:00
Ingo Weinhold
a5270963e5 Changed put_parameter() return type to void. The value was always true and
never checked anyway.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40094 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-03 18:03:23 +00:00
Ingo Weinhold
0536ff83e9 * IS_KERNEL_ADDRESS(): Avoid the check against KERNEL_BASE or KERNEL_TOP, if
that's the limit of the addr_t domain anyway.
* Defined IS_USER_ADDRESS() to !IS_KERNEL_ADDRESS(), which semantically it was
  already, just more verbosely.

Should, in the future, avoid hundreds of useless Coverity tickets where the
macros are used.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40093 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-03 17:56:04 +00:00
Philippe Houdoin
c5f2df286e Switched to use USB_cdc.h definitions.
Expanded search in every configuration, not only first. ELSA USB modem for instance
publish two configurations, the first one being a vendor-specific one for
Windows NT.
ACMDevice now don't assume anymore union functional descriptor is always there.
The data interface index can be found also in Call Management (CM) functional
descriptor.

(Style cleanup pending...)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40092 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-03 17:15:18 +00:00
Philippe Houdoin
cf6bf46a66 Added some function descriptors definitions that were missing.
Renamed USB_CDC_*_PARITY and USB_CDC_*_STOPBIT* to follow the usual
naming pattern.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40091 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-03 16:47:50 +00:00
Joachim Seemer
6d9292c2c4 Committed patch by jalopeura fixing email setting changes, see #7058. Thanks.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40090 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-03 16:26:59 +00:00
Stefano Ceccherini
6709424150 Added TODO
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40089 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-03 09:34:46 +00:00
Ryan Leavengood
aa252ae103 Add NetworkTime as an application, based on Axel's original. This is mostly
based on Hamish Morrison's work on a GCI task. The changes I made from his
patch were to move this from preferences to apps (I think it is more of an app
than a preflet) and to change the name back to NetworkTime (he had made it
NTP, but most people probably won't know what that stands for.)

This also fixes #2412.

I noticed some changes this could use but wanted to add it before making any
changes so there is an SVN history of those changes. I'll probably also make an
icon in the next few days.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40088 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-03 05:47:33 +00:00
Ryan Leavengood
9530027447 Apply patch from augiedoggie for #6258 which adds Athlon Phenom II's to the CPU
identification list.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40087 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-03 04:10:56 +00:00
Ryan Leavengood
494c97f7f9 Apply patch from Karvjorm for #6126 to add console messages from FontDemo.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40086 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-03 03:51:25 +00:00
Ryan Leavengood
e62cadc374 Apply the patch from #6069 which makes the Vulcan Death Grip Ctrl+Shift+Cmd.
I assume if this wasn't wanted the ticket would have been closed, and I think
this is fine.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40085 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-03 03:30:00 +00:00
Ingo Weinhold
a0d93d1416 * VMCache::Unlock(): Renamed local variable consumerLocked to avoid shadowing
the parameter (CID 5329).
* _MergeWithOnlyConsumer(): Removed the somewhat weird consumerLocked
  parameter. The caller can unlock itself, if desired. Improves Unlock()
  readability.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40084 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-03 00:44:40 +00:00
Ingo Weinhold
b734adba63 find_thread(): thread::name is an array, so the NULL check is useless
(CID 4073).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40083 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-03 00:09:27 +00:00
Ingo Weinhold
66e8557230 common_rename(): Fixed incorrect check (array address instead of first
element, CID 4077).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40082 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 23:46:17 +00:00
Ingo Weinhold
e85a4793d2 strcpy() -> strlcpy() (CID 7986).
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40081 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 23:32:47 +00:00
Ingo Weinhold
b0da468aeb call_apm_bios(): Moved otherwise unreachable code into "#if __GNUC__ < 4"
block (CID 10315).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40080 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 23:30:28 +00:00
Ingo Weinhold
b51ec9de58 sprintf() -> snprintf() (CID 7985).
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40079 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 23:16:01 +00:00
Ingo Weinhold
3872a2d2fc Fixed suspicious implicit sign extension computing the frame buffer size
(CIDs 8056, 8057, 8058).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40078 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 23:14:10 +00:00
Ingo Weinhold
447e61909f Always initialize fSize in the BIOSDrive constructor -- InitCheck() uses it
(CID 10272).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40077 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 23:03:01 +00:00
Ingo Weinhold
b2330bb319 strcpy() -> strlcpy() (CID 7984).
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40076 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 22:37:31 +00:00
Ingo Weinhold
80b5decbec Init MenuItem::fShortcut in constructor (CID 10273).
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40075 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 22:35:09 +00:00
Ingo Weinhold
61aa1456a5 Check get_node_from() return value (CID 647).
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40074 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 22:27:10 +00:00
Ingo Weinhold
70fc82404f sprintf() -> snprintf() (CID 7983).
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40073 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 22:22:32 +00:00
Ingo Weinhold
3e9f742d23 Check fstat() return value (CID 2514).
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40072 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 22:20:18 +00:00
Oliver Tappe
db03311342 Closing #7056:
* inherit umask of calling process to images loaded via exec...()

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40071 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 19:12:19 +00:00
Rene Gollent
5c9b247667 The cmd+` shortcut wasn't taking into account if the user was currently holding a
window with the mouse, and as such didn't take it along to the new workspace
as the cmd+F# shortcuts do. Fixes #7057.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40070 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 16:04:15 +00:00
Ingo Weinhold
be4b43e03f At least theoretically kernelSettings and safemodeSettings can be NULL
(CID 4230).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40069 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 14:44:33 +00:00
Ingo Weinhold
8018cd7f61 Also initialize fCachedBlock, as it is used in the destructor. Related to
CID 10271, though that's actually the only member it doesn't mention.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40068 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 14:36:25 +00:00
Ingo Weinhold
10a50e7cd5 Broken if condition (CID 2600).
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40067 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 14:28:55 +00:00
Ingo Weinhold
9a3d05d795 Check return value of fstat() (CID 2513). Cannot really fail in the boot
loader, but the check doesn't harm either.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40066 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 14:22:32 +00:00
Ingo Weinhold
a037e9b3d0 Init fNode (CID 10264).
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40065 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 14:16:19 +00:00
Ingo Weinhold
f746d7fb49 * Removed my copyright. I had nothing to do with this file.
* FileMapDisk::RegisterFileMapBootItem(): Commented out unreachable code
  (CID 10367).
* Automatic whitespace cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40064 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 14:13:21 +00:00
Ryan Leavengood
3a0ecaabad Add Hamish Morrison to the Contributors list.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40063 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 05:53:32 +00:00
Ryan Leavengood
a89161d34b More changes for #1746 from hamish with a few small changes by me.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40062 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 05:44:43 +00:00
Ingo Weinhold
097b4917d3 Use the unnamed namespace instead of an unofficial one.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40061 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 00:44:41 +00:00
Ingo Weinhold
7e36984164 Removed Humdinger's resize mode.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40060 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 00:29:17 +00:00