Commit Graph

6 Commits

Author SHA1 Message Date
Rene Gollent 90b7764dc3 Move WidthBuffer and TextGapBuffer into BPrivate and use them from there in BPoseView and BTextView. This (correctly) fixes the previous gcc4 build issues.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27675 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-09-21 20:47:16 +00:00
Stephan Aßmus a682d9819f Quite a cleanup action to avoid polluting the global namespace with private
BTextView classes:

* Declared the directly used BTextView helper classes as private BTextView
  classes and changed all affected files.
* Realized that Tracker's BPoseView was (accidentally?) using what used to
  be _BWidthBuffer_. It had declared it's own class with the same name and
  same members/size in headers/private/tracker/TextViewSupport.h, but the
  implementation was nowhere to be found. I can only explain this that
  the BTextView implementation was then actually linked and used. But the big
  problem was that it was used without locking (unlike in BTextView)! When
  many Tracker windows opened during system startup or later and they happened
  to each request characters not yet in the cache, I imagine things could have
  gone bad and corrupted memory. Anyways, since I can see the usefulness of
  the cache, BPoseView uses BTextView::WidthBuffer on purpose now. And I moved
  the locking inside BTextView::WidthBuffer::StringWidth().
* Adjusted InterfaceDefs.cpp accordingly.
* TODO: Move subsequent classes into BTextView namespace as well, ie derived
  classes that BTextView doesn't directly know about. All stuff in src/kits/
   inteface/textview_support/
* Added preliminary and not yet implemented layout friendly BTextView
  constructors.
* I will try to handle the insets imposed by BTextView::fTextRect a bit
  differently when used inside the new layout management framework. For this,
  I added BTextView::SetInsets() and GetInsets(). SetInsets() doesn't do
  anything yet.

So far, everything seems to work still... ;-)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27654 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-09-20 15:08:40 +00:00
beveloper 54c0657bab another build fix
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@8080 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-06-20 17:43:32 +00:00
Stefano Ceccherini ac41b0f103 Added license
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@7188 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-04-09 11:07:35 +00:00
Stefano Ceccherini e064995715 Removed an unneeded dependency
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@7016 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-03-18 07:37:38 +00:00
Stefano Ceccherini f1569dbb9e Moved some headers here so they can be included by Globals.cpp in the interface kit folder
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6092 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-01-15 07:15:37 +00:00