Commit Graph

46421 Commits

Author SHA1 Message Date
Philippe Saint-Pierre
cd15d8c3d0 Style fix, no functional change intended 2013-07-17 13:38:46 -04:00
Philippe Saint-Pierre
68aca9a477 Message screensaver: memory leak fix - CID 601698 2013-07-17 13:25:42 -04:00
Philippe Saint-Pierre
fa30ef5640 Message screensaver: close pipe with pclose - CID 990944 2013-07-17 13:06:10 -04:00
Philippe Saint-Pierre
f293052d9f Style fix, no functional change intended 2013-07-17 12:44:40 -04:00
Murai Takashi
fa49409097 Use delete[] instead of delete
Signed-off-by: Jérôme Duval <jerome.duval@gmail.com>
2013-07-17 18:31:28 +02:00
Murai Takashi
15be2c6018 Fix called C++ object pointer is null
Signed-off-by: Jérôme Duval <jerome.duval@gmail.com>
2013-07-17 18:29:29 +02:00
Murai Takashi
2aa0e54e4f Fix called C++ object pointer is null
Signed-off-by: Jérôme Duval <jerome.duval@gmail.com>
2013-07-17 18:26:10 +02:00
Murai Takashi
7a569c8250 Fix Called C++ object pointer is null
Signed-off-by: Jérôme Duval <jerome.duval@gmail.com>
2013-07-17 18:26:08 +02:00
Philippe Saint-Pierre
be064b5af3 virtio_pci.cpp: check for (un)supported hardware never fit
CID #1032255
2013-07-17 12:15:24 -04:00
Philippe Saint-Pierre
da1f251a8f DiskUsage: drawing artefact in TabView 2013-07-17 12:01:26 -04:00
Jérôme Duval
e598dee752 virtio_scsi: now handles events like capacity data changed.
* push event requests on the event queue, handles them.
* activate feature VIRTIO_SCSI_F_CHANGE.
* when a capacity data changed event is received, schedule a rescan of the scsi device node
on the scsi dpc queue. we find out unique child node and call the rescan_node() hook.
* Haiku only handles media changed events on removable devices, so the feature
only actually works when the device is defined as such, aka for QEMU the following option:
-device scsi-hd,drive=hd,removable=true
2013-07-17 17:48:33 +02:00
Jérôme Duval
ed4a8e4d11 virtio: changed a bit the driver API by adding a driverCookie.
* the processing of requests in drivers is eased a bit with this change, but
this could be improved for instance by enabling a driver to dequeue items
in a service thread instead of the interrupt handler.
* made a few methods const.
2013-07-17 17:30:18 +02:00
Jérôme Duval
b3a0911eb7 virtio_scsi: added configuration change definitions.
* supported by at least QEmu 1.4
2013-07-17 17:19:47 +02:00
Jérôme Duval
ea2fa87219 scsi_cmds.h: added SCSIS_ASC_CAPACITY_DATA_HAS_CHANGED
* indicates the device data capacity has changed..
2013-07-17 17:19:46 +02:00
Jérôme Duval
f08e2e6b2a scsi: propagates the rescan to our child device
... when registering finds an existing device with a registered child node.
2013-07-17 17:19:46 +02:00
Jérôme Duval
a6ffcfb320 scsi_disk: added a hook for rescanning devices
* a call indicates the media was changed.
2013-07-17 17:19:45 +02:00
Rene Gollent
71fec49e67 DwarfFile: Implement handling of .debug_types section.
- Refactor ExpressionEvaluationContext::GetCallTarget() and
DwarfFile::_ResolveReference() to use an enum value for the type of
reference being passed in, as we now need to support signature
references in addition to local/global. Adjust callers.
- Factor out an _ParseDebugInfoSection() and add a corresponding
_ParseTypesSection() for the top level loops that handle .debug_info and
.debug_types respectively.
- Refactor _ParseDebugInfoEntry(), _ParseEntryAttributes() and
_ResolveReference to take a pointer to the relevant BaseUnit in order
to allow sharing between parsing of the types and info sections.
- Implement support for DW_FORM_ref_sig8. In order to handle this, we
use a hash table that maps from the corresponding 64-bit DW_AT_signature
values to their respective type units.
- Adjust debug output to more closely match offsets and values used by
objdump for ease of troubleshooting parsing issues.

Combined, these changes allow us to load DWARF 4 binaries sufficiently
to get source information and unwind call frame, though support is still
incomplete. In particular, global references aren't yet implemented,
and neither are location expression attributes, which are now used
quite heavily, and consequently we can't yet resolve variable values
and a few other things properly.
2013-07-16 23:29:22 -04:00
Rene Gollent
4bf8368675 Add TypeUnit and refactor.
- Pull common base class BaseUnit out of CompilationUnit and adjust the
latter to inherit.
- Add TypeUnit to represent the top level units for .debug_types.
2013-07-16 23:29:18 -04:00
Rene Gollent
18c9c018a1 Add DIETypeUnit.
Represents a top level unit from DWARF 4's .debug_types section, akin
to a compilation unit.
2013-07-16 23:00:23 -04:00
Rene Gollent
cbf9b7b177 Update attribute classes to match DWARF 4. 2013-07-16 23:00:22 -04:00
Rene Gollent
db935bfbe9 Implement support for DW_FORM_sec_offset.
This form denotes references to other debug sections, and is sized based
on whether the 32 or 64-bit DWARF format is used.
2013-07-16 23:00:21 -04:00
Rene Gollent
a074f3547a Fix incorrect handling of DW_FORM_flag_present.
This form implicitly indicates a flag value of true without a
corresponding byte in the datastream. As such, we were introducing off
by one errors when parsing one.
2013-07-16 23:00:20 -04:00
Rene Gollent
d3a795bcb4 Debugger: Extend FunctionDebugInfo interface.
- Add hook to FunctionDebugInfo to determine if the represented function
is the main function of the program. Adjust
{Basic,Dwarf}FunctionDebugInfo accordingly.

- {Team,Image}DebugInfo: When loading, see if the current image contains
the main function. If so, cache it for later retrieval.
2013-07-16 23:00:20 -04:00
Ingo Weinhold
e89d7992e5 virtio_block_callback(): prevent rescheduling
... since it can be called with interrupts disabled.
2013-07-16 23:50:19 +02:00
Alexander von Gluck IV
42eed3ba69 RadeonHD: Fix incorrect name -> chipset mapping
* Put names and chipsets next to each other to
  help prevent further mismatch.
* Fix potential (but unlikely) string overflow
* CID 611140
2013-07-16 11:20:24 -05:00
Alexander von Gluck IV
1207554139 RadeonHD: Missing curly braces for temporal logic
* Great catch stpere!
* CID 991343
2013-07-16 11:02:15 -05:00
John Scipione
f47bef09a2 Deskbar: Check if window is NULL. Fixes #9860
It is possible, through the right combination of steps, for this method to
be run on startup before the view is attached to the window causing a crash
because Window() returns NULL. This fix returns false in this case instead.
Later, when an application such as Tracker is started and added to Deskbar
this method will be run again with the view attached to the window.
2013-07-15 19:33:17 -04:00
Murai Takashi
ddc2a758e6 Chunk::Chunk(), Fix Null pointer argument in call to memory copy function
Signed-off-by: Jérôme Duval <jerome.duval@gmail.com>
2013-07-15 17:25:13 +02:00
Murai Takashi
517050adb5 BCollator::Archive(), use free() instead of delete
Signed-off-by: Oliver Tappe <zooey@hirschkaefer.de>
2013-07-15 13:13:22 +02:00
Murai Takashi
10dbe57ef3 PackageItem::ParseAttribute(), use delete[] for deleing *attrData.
Signed-off-by: Oliver Tappe <zooey@hirschkaefer.de>
2013-07-15 13:09:26 +02:00
Murai Takashi
aa419051e6 Fix memory leak for LocalePreflet.cpp
Signed-off-by: Oliver Tappe <zooey@hirschkaefer.de>
2013-07-15 13:04:04 +02:00
Murai Takashi
e5ab37ae70 Fix "Called C++ object pointer is null" for EditableCatalog.cpp
Signed-off-by: Oliver Tappe <zooey@hirschkaefer.de>
2013-07-14 14:36:17 +02:00
Philippe Saint-Pierre
4ba4d40bb2 Addons shortcuts: fix override
Under some specific circumstances (changing the key and the modifier in a specific way
at the same time), Tracker would get confused and not change the shortcut.

Thanks Diver
2013-07-13 16:57:40 -04:00
Philippe Saint-Pierre
073218a8ae Mail kit: use KiB unit (and localize) 2013-07-13 14:55:20 -04:00
Philippe Saint-Pierre
fffc0e2a7b DiskUsage: reuse string_for_size in libshared.a 2013-07-13 14:19:09 -04:00
Philippe Saint-Pierre
3fe416173c Tracker add-on shortcuts, move resource to BEOS: namespace 2013-07-13 14:19:09 -04:00
Philippe Saint-Pierre
1cac1bebcb ActivityMonitor: use new units KiB/MiB for display (#5378) 2013-07-13 14:19:08 -04:00
Rene Gollent
07438277e7 Expander settings: Fix text control alignment. 2013-07-13 11:12:45 -04:00
Niels Sascha Reedijk
cf5c715a4a Update translations from Pootle 2013-07-13 06:13:35 +02:00
John Scipione
747612e390 ExpressionParser: Simplify pi detection 2013-07-12 22:39:37 -04:00
John Scipione
786b0f8f1e DeskCalc: Resize a bit more efficiently.
Remove B_FULL_UPDATE_ON_RESIZE flag from view.

We already Invalidate() on FrameResized() which redraws the
view on resize for us. This reduces the number of times Draw() is called
from 3+ in some cases to just one. Unfortunately Draw() is still called
multiple times in some cases producing noticable flickering and drawing
artifacts but it is marginally better.
2013-07-12 22:19:16 -04:00
John Scipione
49620f7b7d DeskCalc: Preserve selection on resize 2013-07-12 22:19:15 -04:00
John Scipione
fbc8aeaac8 DeskCalc: Replace comment with equivalent code 2013-07-12 22:19:14 -04:00
John Scipione
43f09adbe2 DeskCalc: Add private _IsEmbedded() method 2013-07-12 22:19:14 -04:00
John Scipione
d2577d74af DeskCalc: Remove ResizeTo() 2013-07-12 22:19:14 -04:00
John Scipione
ed7d3e22f9 DeskCalc: Remove pre-ControlLook drawing code 2013-07-12 22:19:13 -04:00
John Scipione
29fbfe3110 DeskCalc: Style fixes 2013-07-12 22:19:13 -04:00
John Scipione
b98de092d8 DeskCalc: Update copyright headers
Style fixes to header, update copyright years, remove my name
from files that I didn't have anything to do with besides style fixes,
add myself to ExpressionTextView.cpp
2013-07-12 22:19:12 -04:00
Philippe Saint-Pierre
8f9c2223a3 Shortcut catcher: crash fix, better monitoring of setting file
* Fix bad memory cleaning I introduced in earlier commit, causing crash in add-on
* Upon detecting the deletion of setting file, shortcuts weren't properly removed
* The node monitoring would not filter the right file on every case

Thanks Diver.
2013-07-12 15:35:59 -04:00
Philippe Saint-Pierre
29cfb63041 Regression fix in Tracker
A delay on Tracker quit request was wrongly introduced
(via reboot, or hey Tracker quit, for example)
2013-07-11 15:47:35 -04:00