Commit Graph

38027 Commits

Author SHA1 Message Date
Marcus Overhagen
27d38ee976 Drop into debugger if the looper can't be locked.
This gets triggered randomly by net_server.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39934 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-24 02:41:08 +00:00
Michael Lotz
5377c49be4 CID 4383 and 4384: Fix wrong checks of index values against kMaxWorkspaces that
could otherwise lead to out of bound access.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39933 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-24 02:20:33 +00:00
Michael Lotz
2e3c20430a CID 4091: fTabOffset is unsigned so the < 0 comparison makes no sense.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39932 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-24 02:08:54 +00:00
Michael Lotz
95e95fee39 * CID 10247: Initialize those two members. Didn't do any harm since they depend
on a set view bitmap and are set when setting one.
* We can safe that resize_frame() call in case no view bitmap is set.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39931 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-24 01:40:36 +00:00
Michael Lotz
3b1679f9c5 * CID 8120: The size supplied to the attach call was the one of the pointer, so
the data was never correctly attached.
* CID 5886 and 5887: escapements and offsets were not freed in the error case.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39930 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-24 01:13:28 +00:00
Michael Lotz
e910a0a3b7 CID 4186: The glyph_index is unsigned, so a >= 0 comparison is always true. The
"empty glyph index" as per freetype (which is eventually called) actually is 0,
so a != 0 comparison should be correct. Untested though.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39929 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-24 00:58:57 +00:00
Marcus Overhagen
1550ecf11a The IN_CLASS* macros use host byte order.
This fixes netmask and broadcast ip for PXE booting.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39928 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-24 00:32:19 +00:00
Marcus Overhagen
84011d2394 data should be const
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39927 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-23 22:54:50 +00:00
Marcus Overhagen
d398717e6d The reference should be const
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39926 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-23 22:54:09 +00:00
Michael Lotz
626e25b19e Remove the apostrophe as pointed out by Urias.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39925 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-23 22:03:08 +00:00
Michael Lotz
3a8bae7cf2 Fix a typo.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39924 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-23 21:45:17 +00:00
Oliver Tappe
cac8f7d4d3 Fix CID-10553:
* avoid possible use of deleted catalog (didn't occur because we
  currently only have a single type of catalog add-on)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39923 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-22 23:04:28 +00:00
Oliver Tappe
0119051c93 Fix CID-2358:
* check result of BMessage::FindString() (plus more ...)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39922 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-22 22:44:31 +00:00
Oliver Tappe
c905e535a2 Fix CID-5982-5985:
* assign arrays members explicitly instead in initialization list


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39921 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-22 22:39:17 +00:00
Oliver Tappe
abd80e8a97 Fix CID-9827:
* the unarchival constructor didn't initialize some members

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39920 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-22 22:08:33 +00:00
Oliver Tappe
aa754a906b Fix CID-2460:
* check result of BMessage::FindString() (plus more ...)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39919 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-22 21:41:10 +00:00
Rene Gollent
521f1d058d - Add some extra methods to DataReader which obtain a new reader with additional restrictions.
- Use new methods to simplify a few places in DwarfFile.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39918 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-22 20:30:53 +00:00
Oliver Tappe
b27cf34dc1 Close #6969 (warning about redundant declarations):
* drop function declarations from wctype.h which are already in wchar.h

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39917 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-21 23:13:47 +00:00
Jérôme Duval
141e1aad27 Added blockgroup Flags()/SetFlags() and flag definitions.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39916 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-21 19:57:48 +00:00
Jérôme Duval
54dd4c335c Based on remarks from Stephan and Axel. Thanks for reviewing.
* The list now owns its items
* MakeEmpty() is used to clear the list (also on destruction)
* RemoveIconAt() lets ItemAt() check the provided index and delete the item
* SlideToIcon(), SlideToNext(), SlideToPrevious() don't need to check invalid values as ItemAt() will return a NULL pointer in this case.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39915 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-21 19:48:12 +00:00
Philippe Houdoin
7dd47a9be5 Fix off by one iconRect sizes.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39914 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-21 10:12:34 +00:00
David McPaul
51d9b4fe14 correct yuv422 planar conversion. Seperate sse, sse2 and ssse3 asm code. Add packed convertor
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39913 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-21 07:25:40 +00:00
Michael Lotz
88cbc0dbc5 Remove unused member. Fixes CID 9579.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39912 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-21 01:09:15 +00:00
Michael Lotz
d10320e0e0 It's a HIDReportItem * array not a HIDReportItem ** one. Fixes CID 8078.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39911 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-21 01:04:13 +00:00
Michael Lotz
beaabe98d1 Fix CID 9580 although it is harmless as the _Reset() call before parsing does
initialize the member.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39910 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-21 01:01:28 +00:00
Michael Lotz
13486cf531 Fix dereference after free. CID 10543.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39909 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-21 00:49:49 +00:00
Michael Lotz
b950cc6532 * Enlarge the device name buffer a bit as with a deep enough hierarchy we might
actually hit this limit.
* Use snprintf() instead of sprintf() as suggested by CID 6447 (even though the
  USB module isn't supposed to return such a malformed string).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39908 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-21 00:42:21 +00:00
Michael Lotz
bf905cfe0c * Fix another non-problematic hidden parameter CID 5218.
* Check the length of the incoming buffer before accessing it through the union.
  It's necessary to do this dependent on the operation at hand, since the caller
  doesn't need to provide the full union size and the size may differ between
  (still compatible) protocol versions.
* Replace memcpy() by user_memcpy() where data is exchanged with userland.
* Small style cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39907 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-21 00:36:23 +00:00
Michael Lotz
3d7bd2dc23 Cosmetical change only: don't shadow the "buffer" parameter with the local
variable. Didn't matter, as the parameter is only accessed through the
usb_raw_command variable that it is casted to early in the function. CID 5219.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39906 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-21 00:06:16 +00:00
Michael Lotz
1579900f55 Fix uninitialized fAllocator member. In the error case the destructor could
crash trying to delete the not created allocator. CID 9562.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39905 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-20 23:32:39 +00:00
Michael Lotz
0153c18eed That the members aren't initialized in the constructor as pointed out by
Coverity was intentional (as explained by the comment). That the fInterval
member was somehow totally forgotten though, wasn't. This should only affect
EHCI and OHCI as they take the interval into account. Might fix some strange
behaviour, but most likely won't, as the interval range is rather narrow and
shouldn't be too noticeable if set incorrectly. CID 9558.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39904 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-20 23:24:38 +00:00
Jérôme Duval
29a98dd656 Applied patch from Karvjorm, adapted by myself (#7004): Fills empty methods in BIconRule and uses BObjectList instead of BList.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39903 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-20 22:00:04 +00:00
Jérôme Duval
230b9a69d3 resource leaks CID 5711, 5712, 5713, 5714
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39902 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-20 21:41:49 +00:00
Jérôme Duval
6535040bec missing fs_close_index_dir call CID 5821
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39901 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-20 21:21:37 +00:00
Jérôme Duval
9905c5afc8 Pass media_format via a reference CID 4401.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39900 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-20 21:05:40 +00:00
Jérôme Duval
1138c00232 array delete (CID 2976)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39899 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-20 20:42:39 +00:00
Jérôme Duval
0c79e77c75 Missing va_end call. CID 10604 and 10603
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39898 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-20 19:59:46 +00:00
Jérôme Duval
5bb7d60a94 Missing va_end call. CID 10605
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39897 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-20 19:54:50 +00:00
Philippe Houdoin
bdde2d307a Removed bilinear filter, as it was blurring all icons (and bitmap icons are
already rendered with a filter).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39896 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-20 17:31:27 +00:00
Philippe Houdoin
10c73bcbb3 Don't returns NULL if the systemCatalog is not localized yet. Instead, fallback
to native string.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39895 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-20 16:25:38 +00:00
Stephan Aßmus
1812583c05 Fixed spacing in Style group layout. (ticket #6553)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39894 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-19 12:17:20 +00:00
Stephan Aßmus
aed19c751b * Coding style cleanup.
* Removed R5 versions of the code, since I don't believe
   other parts of Icon-O-Matic still compile on R5...
 * No functional changes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39893 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-19 12:14:49 +00:00
Stephan Aßmus
32ba4befc4 Make the list view focused by default, this allows to use DriveSetup with
the keyboard and fixes ticket #4746. I did not test creating new
partitions.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39892 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-19 11:01:47 +00:00
Stephan Aßmus
b9d2622de1 Since "Mount all" is not connected to a selected disk/partition,
the Partition menu shall never be disabled. Fixed enabled state
of some other menus/entries after this change. Fixes ticket #6783.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39891 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-19 10:55:36 +00:00
Stephan Aßmus
22334353d0 Only print unexpected errors to stderr when constructing the settings file.
Fixes ticket #6899. 


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39890 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-19 10:44:20 +00:00
Stephan Aßmus
1e9af0512d Patch by jscipione: Check valid input value range
for some MAPM functions, since they will otherwise
just return 0, instead of indicating an error.
Thanks! Fixes ticket #6398.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39889 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-19 10:34:55 +00:00
François Revol
1828f3d72c Add a function to register media codec descriptions for the usual format families using the tag lists from libavformat itself. Untested. the plugin will also have to use av_codec_get_id() to get the codec ID from the tag.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39888 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-19 04:26:46 +00:00
François Revol
34bffae787 Fix description in comment, search-n-replace didn't replace it :)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39887 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-19 02:28:55 +00:00
Jérôme Duval
45af882d06 * added fsblock_t and fileblock_t definitions, used them when needed.
* validate fBlockShift in superblock.
* Volume::AllocateBlocks() now uses an absolute fsblock instead of a blockgroup related fsblock.
* AllocationBlockGroup now provides absolute fsblock values.
* added support for extents feature: ExtentStream class is the equivalent for DataStream class for extent operations.
  The extent tree implementation is very basic, should work for normal growing/shrinking
  operations, but not for sparse files. When enlarging a file and extent tree is full,
  the root is moved in a new block and a new level is added on top. Extents can usually
  be extended when adjacent blocks are allocated. Shrinking happens by removing leafs 
  one after another.
* removed empty IndexedDirectoryIterator.*


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39886 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-18 16:26:39 +00:00
Marcus Overhagen
699dc0e367 Very ugly hack to make DVB addon find the MPEG and AC3 codecs.
Something appeards to be very wrong with codec registration.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39885 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-17 23:17:21 +00:00