Commit Graph

39299 Commits

Author SHA1 Message Date
John Scipione
3a12979db2 FindPanel: Set the MIME type field to fixed width
...instead of based on the width of its contents which can make the window
grow too wide. Fixes #9719
2013-04-29 22:25:12 -04:00
John Scipione
c80aa6e4bc Simplication in Tracker Find Panel
If attribute mode and you select a mime type, Remove then add the rows first
with the first items marked, then go through and re-mark the selected item.
2013-04-29 22:22:06 -04:00
Jérôme Duval
2e00579938 bsnow: use uchar instead of char to avoid narrowing conversion warnings. 2013-04-29 21:44:01 +02:00
Jérôme Duval
cd749a7652 Terminal: use unsigned short instead of int to avoid a narrowing conversion warning.
* unsigned short is the type used in the struct winsize.
2013-04-29 21:40:34 +02:00
Jérôme Duval
e367c05620 SoundRecorder: fixed two warnings.
* warnings about comparison between signed and unsigned integer expressions.
* also use std::min() instead of min_c()
2013-04-29 21:35:40 +02:00
Jérôme Duval
a83d8d14b5 Installer: fixed two warnings.
* warnings about comparison between signed and unsigned integer expressions.
* also use std::min() instead of min_c()
2013-04-29 21:31:20 +02:00
Jérôme Duval
88499de190 attribute_overlay: fixed a warning.
* warning about comparison between signed and unsigned integer expressions.
2013-04-29 21:25:20 +02:00
Jérôme Duval
3756e0ac38 kernel: use uint64 instead of int64 to avoid narrowing conversion warnings.
* gdb_register is used only in arch_debug.cpp
2013-04-29 21:20:35 +02:00
Jérôme Duval
295cdbee6b keymap: use uchar instead of char to avoid narrowing conversion warnings. 2013-04-29 21:09:59 +02:00
Jérôme Duval
311e148798 vfs: fixed two warnings.
* warnings about comparison between signed and unsigned integer expressions.
2013-04-29 20:57:34 +02:00
Jérôme Duval
56efe80f85 nfs4: fixed two warnings.
* warnings about comparison between signed and unsigned integer expressions.
* the use of max_c() was superflous anyway as the result is only used for a comparison
with the left value.
2013-04-29 20:29:10 +02:00
Jérôme Duval
778d2528d6 write_overlay: fixed three warnings, I hope correctly.
* warnings about comparison between signed and unsigned integer expressions.
2013-04-29 20:22:13 +02:00
Jérôme Duval
d592954e3c app_server: avoids referencing a temporary IntRect instance.
* GCC lets us use a const reference to a temporary, but using it after it disappeared
  is incorrect.
* reverts hrev45576 as this patch seems more correct.
2013-04-29 20:17:14 +02:00
John Scipione
ed08c5287a Update CPUFrequency layout a bit
* Use font relative insets and spacing for window.
* Make the input box for Integration Time more reasonably sized and right
  align the label.
* Make the Install replicant into Deskbar button flush right.
* Use the standard amount of space between the Defaults and Revert buttons.
2013-04-29 01:20:52 -04:00
John Scipione
ec63fd3249 Use std::max instead of max_c 2013-04-29 01:18:13 -04:00
John Scipione
3c777060bc Fix gcc4 build, use max_c from SupportDefs instead of max 2013-04-29 01:10:06 -04:00
John Scipione
f542c5137d Fix bug involving the condition string being removed when it shouldn't
This bug occured when you selected from the mime type menu field while in
attribute mode. The rows are removed and added again but the condition string
view was left out because the menu item wasn't marked yet. Reordered to remove
row, then set marked, then add row checking if marked and adding the condition
string view based on the marked mime type. If no mime types are set it uses the
first mimetype instead which is what we want in that case.
2013-04-28 23:49:27 -04:00
John Scipione
2db4f1832a Make logic menu field more font dynamic, wasn't working for Japanese
Some style fixes and code simplications too.
2013-04-28 23:44:09 -04:00
John Scipione
e001e604b9 Consolidate strings so they are added to the catalog just once. 2013-04-28 23:41:34 -04:00
John Scipione
337a12f63f Another style fix 2013-04-28 23:39:49 -04:00
John Scipione
32994cb474 Style fixes and code simplifications 2013-04-28 23:38:04 -04:00
John Scipione
955d6389af Close window on Esc 2013-04-28 23:35:54 -04:00
John Scipione
72fb3d3984 Remove the alert dialog adjustements, they are now done in BAlert directly
The save panel adjustment has been kept and modified a bit to position the
window nicely. It too uses the BWindow::CenterIn() method that adjusts based
on the screen edges.
2013-04-28 20:30:22 -04:00
John Scipione
e894fbc0ac Adjust BAlert to position the alert using the revamped BWindow::CenterIn() method.
BAlert::AlertPosition() has been superceded by the new BWindow method and should
be considered deprecated. Note that the alert position is not in the direct center of the
screen, it is offset vertically like before.
2013-04-28 20:30:22 -04:00
John Scipione
54153cc8b2 Update CenterIn() and CenterOnScreen() methods in BWindow
* These methods now return the new point after centering.
* But more importantly CenterIn() does some new adjustments to keep the window
  position inside the screen edge. If you pass the screen frame into CenterIn()
  it skips these adjustments.
2013-04-28 20:30:21 -04:00
John Scipione
65e6ce6d53 Style changes in Alert and StyledEdit Find Window 2013-04-28 20:30:19 -04:00
Rene Gollent
23dfa8b82e Add column to threads list view for stop reason. 2013-04-28 13:53:46 -04:00
Jérôme Duval
849683f4c8 app_server: workaround for GCC 4.7 misbehavior in IntRect.
* moved the inlined BRect constructor of IntRect to the cpp file. GCC will inline the method
anyway.
* impacted methods were both AGGTextRenderer::RenderString() in
src/servers/app/drawing/Painter/AGGTextRenderer.cpp, calling the StringRenderer constructor
with a BRect reference.
* unless someone comes up with an explanation, I'll try to come with a smaller testcase to
submit this problem upstream.
2013-04-28 16:39:14 +02:00
Jérôme Duval
7db03c63a0 FontManager: fixed trace mode 2013-04-28 16:39:13 +02:00
Michael Lotz
a01dd96346 Return more than a single dirent at a time in bfs_read_dir().
Return as many dirents as fit into the provided buffer. The readdir()
implementation in libroot tries to get many dirents and caches them to
reduce the amount of syscalls and the associated overhead.

This reduces the syscall count dramatically for use cases where a lot
of directories are enumerated. A "git status" on a Haiku repository for
example goes from over 50k read dir syscalls down to just under 7k.
The performance gain is only around a moderate 5% in that use case
though.
2013-04-28 13:36:20 +02:00
Michael Lotz
91b4626a78 Check for and report an error on key buffer overrun.
This usually wasn't a problem as the key buffer is generally large
enough to hold a single value. Still on short buffers or very long
it could have silently overrun before.
2013-04-28 13:33:05 +02:00
Michael Lotz
c4dbefe0b4 Fix build with tracing turned on. 2013-04-28 03:45:55 +02:00
Michael Lotz
d057026dc4 Poll more frequently for the first explore.
This reduces needless waiting for the special case of the polled and
synchronous first explore.
2013-04-28 03:45:53 +02:00
Michael Lotz
22af7532d1 Reduce port reset recovery time from 250ms to 50ms.
The specs say the reset recovery time is 10ms only. The extra 40ms are
taken from the Linux hub driver.
2013-04-28 03:45:52 +02:00
Michael Lotz
827c7224a0 Implement debounce sequence according to USB 2.0 specs.
This replaces waiting a fixed time of 300ms for the device power to
stabilize. In the ideal case this reduces the boot time by 200ms per
connected device (including internal hubs).

This is very similar to what Linux implements and we use the same time
values. An interval of 25ms is used to check for connection state
changes, the stable time is at least 100ms as per the USB specs and the
whole process times out after 1.5 seconds.
2013-04-28 03:45:51 +02:00
John Scipione
e94d7e41e8 Remove the And/Or menu field when you remove a row 2013-04-27 20:26:46 -04:00
John Scipione
43f6509cd0 Turn off radio mode and set label from marked for fRecentQueries 2013-04-27 19:40:36 -04:00
John Scipione
35e34dda8a Use sentence case lowercasing the word "query" 2013-04-27 19:40:35 -04:00
John Scipione
0184cbec0a Eliminate variable, set directly 2013-04-27 19:40:34 -04:00
John Scipione
f7467fd1ff Set the PaneSwitch arrow rect based on the be_plain_font size 2013-04-27 19:40:32 -04:00
John Scipione
bedc69662e Put checkboxes under query box in more options 2013-04-27 19:40:31 -04:00
John Scipione
d3277fa8e7 Tweak the latch position 2013-04-27 19:40:28 -04:00
John Scipione
e8a78127bd Sentence case Recent queries, clip count from 0 to 10 2013-04-27 19:40:26 -04:00
John Scipione
1db0bf0058 Make the logic menu fields non-navigatable, tab order 2013-04-27 19:40:25 -04:00
John Scipione
16c46df9b1 Remove dead code, de-indent comment 2013-04-27 19:40:24 -04:00
John Scipione
c65c2a54bd Rename add and remove to add button and remove button 2013-04-27 19:40:22 -04:00
John Scipione
c00d064252 Right align Add and Remove buttons 2013-04-27 19:40:21 -04:00
John Scipione
56fe9fad23 Refactor attaching FindPanel to FindWindow 2013-04-27 19:40:19 -04:00
John Scipione
8e8b861c83 Set the initial rect to 0 and center the window on screen 2013-04-27 19:40:18 -04:00
John Scipione
a12df99d53 Use font relative spacing units 2013-04-27 19:40:15 -04:00