Show error messages when saving fails, to enmake sure the user is not
confused by thinking the file saved when the window doesn't close.
Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Fixes#12945
* The semaphore wasn't really needed to do what it did; using
atomic_{get|set}() as suggested by jua is much faster, anyway.
* Thanks to Dario for the initial work on this.
* For people involved please review, too much confusion seems
to have been done in past.
* The fBufferFreeSem is removed as it didn't make sense. It was
used to detected when the output thread should be stopped, a
boolean flag is used instead.
* Avoid to allocate a BAutolocker at begin of the _OutputThread,
plain Lock/Unlock is used instead.
* The fBufferLock is now locked when a buffer is handled.
* When escaping operator/quote characters, the character was properly
ignored. However, the escape char was left in the string which
altered the query.
* This fixes bug #10976.
Sets B_DOCUMENT_BACKGROUND_COLOR for the comment text view.
The former B_PANEL_BACKGROUND_COLOR made it look un-editable.
Unfortunately, I'm unable to set the text colour to
B_DOCUMENT_TEXT_COLOR; it still uses B_PANEL_TEXT_COLOR.
Currently those are both black by default.
There are still a few instances left before closing #11689.
99% acurate recreation of the icons used in the Deskbar for hidden and
visible windows. Only the yellow tab is now a gradient. Should be invisible
at the relative sizes used in Deskbar.
I added 5 notification icons. They are flat icons that appear a bit bland at
larger sizes, but are nice when smaller like in the Deskbar or in lists.
Here's a PNG of them: https://lut.im/EtRvHPsMNC/T5wXFapUOkej68B9.png
Notify_Notice - your normal info
Notify_Achtung - slightly more interesting than a notice
Notify_Caution - 1st level of escalation, "Odd..."
Notify_Warning - 2nd level of escalation, "Something's not right at all..."
Notify_Danger - 3rd level of escalation, "I smell smoke..."
* This removes Pulse(), which would constantly reconnect to
the mixer. With the previous changes to the
DefaultMediaTheme, this also makes changes to the muted
state instaneous when modified by some other app.
* Addresses TODO of sub-classing controls, registering with the
media roster for parameter changes.
* Also adds support for discrete parameter controls, which didn't
have this functionality.
* With this change, the controls no longer need to be focused or
modified for the parameter changes to register.
Revert changes from d0ac609964
The People window include a dark grey stripe, which must be next to the
window border with no spacing. The spacing was properly done inside the
main view.
Thanks to Diver for noticing the issue.
- Make sure the archive contains the replicant pop-up menu
- Make sure said menu is properly re-targetted when instanciating
Fixes#13138
Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
fMinValue was getting set to INT32_MAX then set to INT32_MIN
fMaxValue was not getting set
now set fMinValue to INT32_MIN, fMaxValue to INT32_MAX
also in _InitObject()
... reverse this to avoid confusion, you'll see why in next commit.
No functional change intended in this commit, functional change is in the
next commit.
