Aren
/
haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

long overdue fix for BScrollBar. fValue is now set in SetValue() 

instead of ValueChanged(). This fixes BScrollBar implementations
which don't call the inherited version of ValueChanged(). All kinds
of weird behaviour seems to be fixed by this: StyledEdit window
resizing, scrolling in Pe, WonderBrush, eXposer and maybe more.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17263 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Stephan Aßmus 2006-04-29 16:36:31 +00:00
parent a1a536495a
commit f87b5b9803
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/kits/interface/ScrollBar.cpp
View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2001-2005, Haiku, Inc.
* Copyright (c) 2001-2006, Haiku, Inc.
* Distributed under the terms of the MIT license.
*
* Authors:
@ -291,6 +291,7 @@ an actual BView within the scroll bar's window.
void
BScrollBar::SetValue(float value)
{
//printf("BScrollBar::SetValue(%.1f)\n", value);
if (value == fValue)
return;
@ -299,6 +300,12 @@ BScrollBar::SetValue(float value)
if (value < fMin)
value = fMin;
fValue = value;
_UpdateThumbFrame();
_UpdateArrowButtons();
//printf(" -> calling ValueChanged()\n");
ValueChanged(value);
}
@ -313,6 +320,7 @@ BScrollBar::Value() const
void
BScrollBar::ValueChanged(float newValue)
{
printf("BScrollBar::ValueChanged(%.1f)\n", newValue);
if (fTarget) {
// cache target bounds
BRect targetBounds = fTarget->Bounds();
@ -326,10 +334,7 @@ BScrollBar::ValueChanged(float newValue)
}
}
fValue = newValue;
_UpdateThumbFrame();
_UpdateArrowButtons();
SetValue(newValue);
}
// SetProportion