Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Keymap: remove iterator change inside for loop, no functional change

Browse Source 
Pointed by clang.

Change-Id: I3aaad5b1e03385358ccb729251fa31d35108f389
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2392
Reviewed-by: John Scipione <jscipione@gmail.com>
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
This commit is contained in:
X512 2020-03-22 11:29:55 +09:00 committed by waddlesplash
parent 1e3d4cf78c
commit f7db27344f
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/kits/shared/Keymap.cpp
View File

@ -420,7 +420,7 @@ BKeymap::GetChars(uint32 keyCode, uint32 modifiers, uint8 activeDeadKey,
// if dead key, we search for our current offset char in the dead key // if dead key, we search for our current offset char in the dead key
// offset table string comparison is needed // offset table string comparison is needed
for (int32 i = 0; i < 32; i++) { for (int32 i = 0; i < 32; i += 2) {
if (strncmp(&fChars[offset + 1], &fChars[deadKey[i] + 1], *numBytes) if (strncmp(&fChars[offset + 1], &fChars[deadKey[i] + 1], *numBytes)
== 0) { == 0) {
*numBytes = fChars[deadKey[i + 1]]; *numBytes = fChars[deadKey[i + 1]];
@ -441,7 +441,6 @@ BKeymap::GetChars(uint32 keyCode, uint32 modifiers, uint8 activeDeadKey,
} }
return; return;
} }
i++;
} }
// if not found we return the current char mapped // if not found we return the current char mapped