Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

AboutSystem: Minor fix for opening links

Browse Source 
It looks like it unfolds to:
> /bin/open /bin/open https://www.example.com

Instead of the expected:
> /bin/open https://www.example.com

See "src/kits/app/Roster.cpp", BRoster::ArgVector::Init() method:
    // init vector
    if (error == B_OK) {
        fArgs[0] = fAppPath.Path(); // Here
        if (argc > 0 && args != NULL) {
            for (int i = 0; i < argc; i++)
                fArgs[i + 1] = args[i];
            if (hasDocArg)
                fArgs[fArgc - 1] = fDocPath.Path();
        }
        // NULL terminate (e.g. required by load_image())
        fArgs[fArgc] = NULL;
    }

Change-Id: Ie7e7155377637b93cbc3c1d225cb91b5e0d2dd7d
Reviewed-on: https://review.haiku-os.org/754
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
This commit is contained in:
EXL 2018-12-09 09:23:20 +07:00 committed by waddlesplash
parent dbbac33163
commit f232d9d22c
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/apps/aboutsystem/HyperTextActions.cpp
View File

@ -33,9 +33,8 @@ URLAction::Clicked(HyperTextView* view, BPoint where, BMessage* message)
if (get_ref_for_path("/bin/open", &ref))
return;
const char* args[] = { "/bin/open", fURL.String(), NULL };
be_roster->Launch(&ref, 2, args);
const char* args[] = { fURL.String(), NULL };
be_roster->Launch(&ref, 1, args);
}