Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BSoundPlayer: Release the node instead to delete

Browse Source 
* It's a bad idea to delete directly a node. There are some
mechanisms behind that might break if not used correctly.
* May help with #12606.
This commit is contained in:
Dario Casalinuovo 2016-01-28 23:27:38 +01:00
parent 3d2853b218
commit f1059fbd7f
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/kits/media/SoundPlayer.cpp
View File

@ -143,8 +143,17 @@ cleanup:
// We do not call BMediaRoster::ReleaseNode(), since
// the player was created by using "new". We could
// call BMediaRoster::UnregisterNode(), but this is
// supposed to be done by BMediaNode destructor automatically
delete fPlayerNode;
// supposed to be done by BMediaNode destructor automatically.
// The node is deleted by the Release() when ref count reach 0.
// Since we are the sole owners, and no one acquired it
// this should be the case. The Quit() synchronization
// is handled by the DeleteHook inheritance.
// NOTE: this might be crucial when using a BMediaEventLooper.
if (fPlayerNode->Release() != NULL) {
TRACE("BSoundPlayer::~BSoundPlayer: Error the producer node "
"appears to be acquired by someone else than us!");
}
// do not delete fVolumeSlider, it belongs to the parameter web
delete fParameterWeb;