Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

* Made all exported safe against NULL pointers, this fixes bug #485.

Browse Source 
* Slightly improved error codes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19941 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Axel Dörfler 2007-01-24 14:32:05 +00:00
parent a9dfa85e4e
commit f0a5326923
2 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/system/runtime_loader/elf.c
View File

@ -1,5 +1,5 @@
/*
* Copyright 2003-2006, Axel Dörfler, axeld@pinc-software.de.
* Copyright 2003-2007, Axel Dörfler, axeld@pinc-software.de.
* Distributed under the terms of the MIT License.
*
* Copyright 2002, Manuel J. Petit. All rights reserved.
@ -1264,6 +1264,9 @@ load_library(char const *path, uint32 flags, bool addOn)
image_type type = (addOn ? B_ADD_ON_IMAGE : B_LIBRARY_IMAGE);
status_t status;
if (path == NULL)
return B_BAD_VALUE;
// ToDo: implement flags
(void)flags;
@ -1319,6 +1322,9 @@ unload_library(image_id imageID, bool addOn)
image_t *image;
image_type type = addOn ? B_ADD_ON_IMAGE : B_LIBRARY_IMAGE;
if (imageID < B_OK)
return B_BAD_IMAGE_ID;
rld_lock();
// for now, just do stupid simple global locking
@ -1413,6 +1419,11 @@ get_symbol(image_id imageID, char const *symbolName, int32 symbolType, void **_l
status_t status = B_OK;
image_t *image;
if (imageID < B_OK)
return B_BAD_IMAGE_ID;
if (symbolName == NULL)
return B_BAD_VALUE;
rld_lock();
// for now, just do stupid simple global locking
@ -1443,12 +1454,15 @@ get_next_image_dependency(image_id id, uint32 *cookie, const char **_name)
struct Elf32_Dyn *dynamicSection;
image_t *image;
if (_name == NULL)
return B_BAD_VALUE;
rld_lock();
image = find_loaded_image_by_id(id);
if (image == NULL) {
rld_unlock();
return B_BAD_VALUE;
return B_BAD_IMAGE_ID;
}
dynamicSection = (struct Elf32_Dyn *)image->dynamic_ptr;

5
src/system/runtime_loader/runtime_loader.c
View File

@ -1,5 +1,5 @@
/*
* Copyright 2005-2006, Axel Dörfler, axeld@pinc-software.de.
* Copyright 2005-2007, Axel Dörfler, axeld@pinc-software.de.
* Distributed under the terms of the MIT License.
*
* Copyright 2002, Manuel J. Petit. All rights reserved.
@ -269,6 +269,9 @@ test_executable(const char *name, uid_t user, gid_t group, char *invoker)
ssize_t length;
int fd;
if (name == NULL)
return B_BAD_VALUE;
strlcpy(path, name, sizeof(path));
fd = open_executable(path, B_APP_IMAGE, NULL);